* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
@ 2018-03-07 10:59 Timo Ketola
0 siblings, 0 replies; 7+ messages in thread
From: Timo Ketola @ 2018-03-07 10:59 UTC (permalink / raw)
To: buildroot
When verbosive, fbgrab reports pixel format. Green and blue offset and
msb_right fields are accidentally swapped there. This commit adds a patch
which straightens them up.
Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
---
package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
new file mode 100644
index 0000000..18bcf96
--- /dev/null
+++ b/package/fbgrab/0100-fix-pixfmt-report.patch
@@ -0,0 +1,22 @@
+Fix pixel format report
+
+When fbgrab tells about the framebuffer pixel format, blue and green
+are accidentally swapped in 'length' and 'msb_right' columns. Let's
+order everything as RGB.
+
+Signed-off-by timo.ketola at exertus.fi
+
+diff -u a/fbgrab.c b/fbgrab.c
+--- a/fbgrab.c 2018-03-07 11:42:04.739250433 +0200
++++ b/fbgrab.c 2018-03-07 11:43:26.128043877 +0200
+@@ -169,8 +169,8 @@
+ fprintf(stderr, "bits_per_pixel: %i\n", fb_varinfo_p->bits_per_pixel);
+ fprintf(stderr, "grayscale: %s\n", fb_varinfo_p->grayscale ? "true" : "false");
+ fprintf(stderr, "red: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->red.offset, fb_varinfo_p->red.length, fb_varinfo_p->red.msb_right);
+- fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
+- fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
++ fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
++ fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
+ fprintf(stderr, "alpha: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->transp.offset, fb_varinfo_p->transp.length, fb_varinfo_p->transp.msb_right);
+ fprintf(stderr, "pixel format: %s\n", fb_varinfo_p->nonstd == 0 ? "standard" : "non-standard");
+ }
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
2018-03-07 20:25 ` Thomas Petazzoni
@ 2018-03-08 7:32 ` Timo Ketola
0 siblings, 0 replies; 7+ messages in thread
From: Timo Ketola @ 2018-03-08 7:32 UTC (permalink / raw)
To: buildroot
On 07.03.2018 22:25, Thomas Petazzoni wrote:
> Hello,
>
> Thanks for this patch. One minor nit, we like the commit titles to
> always follow the format:
>
> <package>: <description>
>
> So perhaps here:
>
> fbgrab: add patch fixing pixel format report
Thanks for the comment. Did that.
> No need to resend just for that, we can fixup when applying.
I resent it anyway due to Adrian's request.
--
Timo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
2018-03-07 14:12 Timo Ketola
2018-03-07 15:15 ` Adrian Perez de Castro
@ 2018-03-07 20:25 ` Thomas Petazzoni
2018-03-08 7:32 ` Timo Ketola
1 sibling, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2018-03-07 20:25 UTC (permalink / raw)
To: buildroot
Hello,
On Wed, 7 Mar 2018 16:12:51 +0200, Timo Ketola wrote:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
>
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
Thanks for this patch. One minor nit, we like the commit titles to
always follow the format:
<package>: <description>
So perhaps here:
fbgrab: add patch fixing pixel format report
No need to resend just for that, we can fixup when applying.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
2018-03-07 17:28 ` Timo Ketola
@ 2018-03-07 20:22 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2018-03-07 20:22 UTC (permalink / raw)
To: buildroot
Hello Timo,
On Wed, 7 Mar 2018 19:28:30 +0200, Timo Ketola wrote:
> BTW, DEVELOPERS states Daniel taking care of fbgrab package but I get
> bounces from his address.
Don't hesitate to send a patch removing Daniel. And perhaps adding
yourself for the fbgrab package :-)
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
2018-03-07 15:15 ` Adrian Perez de Castro
@ 2018-03-07 17:28 ` Timo Ketola
2018-03-07 20:22 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: Timo Ketola @ 2018-03-07 17:28 UTC (permalink / raw)
To: buildroot
On 07.03.2018 17:15, Adrian Perez de Castro wrote:
> Moikka, Timo!
Terve, Adrian! :-o
> By any chance, have you tried sending the patch upstream? If not,
> that would be nice a nice thing to do.
Yes, I actually sent the patch to the author too (gmo linux.nu).
> As a small nit, could you also add an ?Upstream-Status? tag line next
> to the ?Signed-off-by? one and resubmit the patch?
Will do.
BTW, DEVELOPERS states Daniel taking care of fbgrab package but I get
bounces from his address.
--
Timo
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
2018-03-07 14:12 Timo Ketola
@ 2018-03-07 15:15 ` Adrian Perez de Castro
2018-03-07 17:28 ` Timo Ketola
2018-03-07 20:25 ` Thomas Petazzoni
1 sibling, 1 reply; 7+ messages in thread
From: Adrian Perez de Castro @ 2018-03-07 15:15 UTC (permalink / raw)
To: buildroot
Moikka, Timo!
On Wed, 7 Mar 2018 16:12:51 +0200, "Timo Ketola" <timo@exertus.fi> wrote:
> When verbosive, fbgrab reports pixel format. Green and blue offset and
> msb_right fields are accidentally swapped there. This commit adds a patch
> which straightens them up.
>
> Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
Reviewed-by: Adrian Perez de Castro <aperez@igalia.com>
By any chance, have you tried sending the patch upstream? If not, that
would be nice a nice thing to do. As a small nit, could you also add an
?Upstream-Status? tag line next to the ?Signed-off-by? one and resubmit
the patch?
BTW, I have noticed that the manual does NOT mention anything about the
?Upstream-Status? tag at all. Probably it would be a good idea to add
some notes about this.
> ---
> package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
> create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
>
> diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
> new file mode 100644
> index 0000000..18bcf96
> --- /dev/null
> +++ b/package/fbgrab/0100-fix-pixfmt-report.patch
> @@ -0,0 +1,22 @@
> +Fix pixel format report
> +
> +When fbgrab tells about the framebuffer pixel format, blue and green
> +are accidentally swapped in 'length' and 'msb_right' columns. Let's
> +order everything as RGB.
> +
> +Signed-off-by timo.ketola at exertus.fi
> +
> +diff -u a/fbgrab.c b/fbgrab.c
> +--- a/fbgrab.c 2018-03-07 11:42:04.739250433 +0200
> ++++ b/fbgrab.c 2018-03-07 11:43:26.128043877 +0200
> +@@ -169,8 +169,8 @@
> + fprintf(stderr, "bits_per_pixel: %i\n", fb_varinfo_p->bits_per_pixel);
> + fprintf(stderr, "grayscale: %s\n", fb_varinfo_p->grayscale ? "true" : "false");
> + fprintf(stderr, "red: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->red.offset, fb_varinfo_p->red.length, fb_varinfo_p->red.msb_right);
> +- fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
> +- fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
> ++ fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
> ++ fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
> + fprintf(stderr, "alpha: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->transp.offset, fb_varinfo_p->transp.length, fb_varinfo_p->transp.msb_right);
> + fprintf(stderr, "pixel format: %s\n", fb_varinfo_p->nonstd == 0 ? "standard" : "non-standard");
> + }
> --
> 2.7.4
Best regards,
--
Adri?n ?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20180307/ea1bcc15/attachment.asc>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report
@ 2018-03-07 14:12 Timo Ketola
2018-03-07 15:15 ` Adrian Perez de Castro
2018-03-07 20:25 ` Thomas Petazzoni
0 siblings, 2 replies; 7+ messages in thread
From: Timo Ketola @ 2018-03-07 14:12 UTC (permalink / raw)
To: buildroot
When verbosive, fbgrab reports pixel format. Green and blue offset and
msb_right fields are accidentally swapped there. This commit adds a patch
which straightens them up.
Signed-off-by: Timo Ketola <timo.ketola@exertus.fi>
---
package/fbgrab/0100-fix-pixfmt-report.patch | 22 ++++++++++++++++++++++
1 file changed, 22 insertions(+)
create mode 100644 package/fbgrab/0100-fix-pixfmt-report.patch
diff --git a/package/fbgrab/0100-fix-pixfmt-report.patch b/package/fbgrab/0100-fix-pixfmt-report.patch
new file mode 100644
index 0000000..18bcf96
--- /dev/null
+++ b/package/fbgrab/0100-fix-pixfmt-report.patch
@@ -0,0 +1,22 @@
+Fix pixel format report
+
+When fbgrab tells about the framebuffer pixel format, blue and green
+are accidentally swapped in 'length' and 'msb_right' columns. Let's
+order everything as RGB.
+
+Signed-off-by timo.ketola at exertus.fi
+
+diff -u a/fbgrab.c b/fbgrab.c
+--- a/fbgrab.c 2018-03-07 11:42:04.739250433 +0200
++++ b/fbgrab.c 2018-03-07 11:43:26.128043877 +0200
+@@ -169,8 +169,8 @@
+ fprintf(stderr, "bits_per_pixel: %i\n", fb_varinfo_p->bits_per_pixel);
+ fprintf(stderr, "grayscale: %s\n", fb_varinfo_p->grayscale ? "true" : "false");
+ fprintf(stderr, "red: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->red.offset, fb_varinfo_p->red.length, fb_varinfo_p->red.msb_right);
+- fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
+- fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
++ fprintf(stderr, "green: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->green.offset, fb_varinfo_p->green.length, fb_varinfo_p->green.msb_right);
++ fprintf(stderr, "blue: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->blue.offset, fb_varinfo_p->blue.length, fb_varinfo_p->blue.msb_right);
+ fprintf(stderr, "alpha: offset: %i, length: %i, msb_right: %i\n", fb_varinfo_p->transp.offset, fb_varinfo_p->transp.length, fb_varinfo_p->transp.msb_right);
+ fprintf(stderr, "pixel format: %s\n", fb_varinfo_p->nonstd == 0 ? "standard" : "non-standard");
+ }
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-08 7:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 10:59 [Buildroot] [PATCH 1/1] Fix fbgrab pixel format report Timo Ketola
2018-03-07 14:12 Timo Ketola
2018-03-07 15:15 ` Adrian Perez de Castro
2018-03-07 17:28 ` Timo Ketola
2018-03-07 20:22 ` Thomas Petazzoni
2018-03-07 20:25 ` Thomas Petazzoni
2018-03-08 7:32 ` Timo Ketola
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.