* [PATCH] mfd: ab8500-debugfs: Use kasprintf
@ 2018-03-07 18:06 ` Himanshu Jha
0 siblings, 0 replies; 4+ messages in thread
From: Himanshu Jha @ 2018-03-07 18:06 UTC (permalink / raw)
To: linus.walleij; +Cc: lee.jones, linux-arm-kernel, linux-kernel, Himanshu Jha
Use kasprintf instead of combination of kmalloc and sprintf.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/mfd/ab8500-debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 8ba4107..831a1ce 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -2519,11 +2519,10 @@ static ssize_t ab8500_subscribe_write(struct file *file,
if (!dev_attr[irq_index])
return -ENOMEM;
- event_name[irq_index] = kmalloc(count, GFP_KERNEL);
+ event_name[irq_index] = kasprintf(GFP_KERNEL, "%lu", user_val);
if (!event_name[irq_index])
return -ENOMEM;
- sprintf(event_name[irq_index], "%lu", user_val);
dev_attr[irq_index]->show = show_irq;
dev_attr[irq_index]->store = NULL;
dev_attr[irq_index]->attr.name = event_name[irq_index];
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] mfd: ab8500-debugfs: Use kasprintf
@ 2018-03-07 18:06 ` Himanshu Jha
0 siblings, 0 replies; 4+ messages in thread
From: Himanshu Jha @ 2018-03-07 18:06 UTC (permalink / raw)
To: linux-arm-kernel
Use kasprintf instead of combination of kmalloc and sprintf.
Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
drivers/mfd/ab8500-debugfs.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 8ba4107..831a1ce 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -2519,11 +2519,10 @@ static ssize_t ab8500_subscribe_write(struct file *file,
if (!dev_attr[irq_index])
return -ENOMEM;
- event_name[irq_index] = kmalloc(count, GFP_KERNEL);
+ event_name[irq_index] = kasprintf(GFP_KERNEL, "%lu", user_val);
if (!event_name[irq_index])
return -ENOMEM;
- sprintf(event_name[irq_index], "%lu", user_val);
dev_attr[irq_index]->show = show_irq;
dev_attr[irq_index]->store = NULL;
dev_attr[irq_index]->attr.name = event_name[irq_index];
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mfd: ab8500-debugfs: Use kasprintf
2018-03-07 18:06 ` Himanshu Jha
@ 2018-03-12 14:11 ` Lee Jones
-1 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2018-03-12 14:11 UTC (permalink / raw)
To: Himanshu Jha; +Cc: linus.walleij, linux-arm-kernel, linux-kernel
On Wed, 07 Mar 2018, Himanshu Jha wrote:
> Use kasprintf instead of combination of kmalloc and sprintf.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/mfd/ab8500-debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mfd: ab8500-debugfs: Use kasprintf
@ 2018-03-12 14:11 ` Lee Jones
0 siblings, 0 replies; 4+ messages in thread
From: Lee Jones @ 2018-03-12 14:11 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, 07 Mar 2018, Himanshu Jha wrote:
> Use kasprintf instead of combination of kmalloc and sprintf.
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/mfd/ab8500-debugfs.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Applied, thanks.
--
Lee Jones [???]
Linaro Services Technical Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-12 14:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 18:06 [PATCH] mfd: ab8500-debugfs: Use kasprintf Himanshu Jha
2018-03-07 18:06 ` Himanshu Jha
2018-03-12 14:11 ` Lee Jones
2018-03-12 14:11 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.