* [PATCH] common/sched: Fix ARM build following c/s 340edc3902
@ 2018-03-07 19:41 Andrew Cooper
2018-03-07 20:04 ` Stefano Stabellini
2018-03-08 9:53 ` George Dunlap
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Cooper @ 2018-03-07 19:41 UTC (permalink / raw)
To: Xen-devel
Cc: George Dunlap, Andrew Cooper, Julien Grall, Stefano Stabellini,
Dario Faggioli
The OSSTest smoke tests reports:
sched_credit2.c: In function 'csched2_alloc_domdata':
sched_credit2.c:3015:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
return ERR_PTR(-ENOMEM);
^
sched_credit2.c:3015:9: error: nested extern declaration of 'ERR_PTR' [-Werror=nested-externs]
As the ERR infrastructure is part of the main scheduler interface now, include it from xen/sched-if.h
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
---
CC: George Dunlap <george.dunlap@eu.citrix.com>
CC: Dario Faggioli <dfaggioli@suse.com>
CC: Stefano Stabellini <sstabellini@kernel.org>
CC: Julien Grall <julien.grall@arm.com>
---
xen/include/xen/sched-if.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
index 4895242..c5dd43e 100644
--- a/xen/include/xen/sched-if.h
+++ b/xen/include/xen/sched-if.h
@@ -9,6 +9,7 @@
#define __XEN_SCHED_IF_H__
#include <xen/percpu.h>
+#include <xen/err.h>
/* A global pointer to the initial cpupool (POOL0). */
extern struct cpupool *cpupool0;
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] common/sched: Fix ARM build following c/s 340edc3902
2018-03-07 19:41 [PATCH] common/sched: Fix ARM build following c/s 340edc3902 Andrew Cooper
@ 2018-03-07 20:04 ` Stefano Stabellini
2018-03-08 9:37 ` Dario Faggioli
2018-03-08 9:53 ` George Dunlap
1 sibling, 1 reply; 4+ messages in thread
From: Stefano Stabellini @ 2018-03-07 20:04 UTC (permalink / raw)
To: Andrew Cooper
Cc: George Dunlap, Julien Grall, Dario Faggioli, Stefano Stabellini,
Xen-devel
On Wed, 7 Mar 2018, Andrew Cooper wrote:
> The OSSTest smoke tests reports:
>
> sched_credit2.c: In function 'csched2_alloc_domdata':
> sched_credit2.c:3015:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
> return ERR_PTR(-ENOMEM);
> ^
> sched_credit2.c:3015:9: error: nested extern declaration of 'ERR_PTR' [-Werror=nested-externs]
>
> As the ERR infrastructure is part of the main scheduler interface now, include it from xen/sched-if.h
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
> ---
> CC: George Dunlap <george.dunlap@eu.citrix.com>
> CC: Dario Faggioli <dfaggioli@suse.com>
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: Julien Grall <julien.grall@arm.com>
> ---
> xen/include/xen/sched-if.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/include/xen/sched-if.h b/xen/include/xen/sched-if.h
> index 4895242..c5dd43e 100644
> --- a/xen/include/xen/sched-if.h
> +++ b/xen/include/xen/sched-if.h
> @@ -9,6 +9,7 @@
> #define __XEN_SCHED_IF_H__
>
> #include <xen/percpu.h>
> +#include <xen/err.h>
>
> /* A global pointer to the initial cpupool (POOL0). */
> extern struct cpupool *cpupool0;
> --
> 2.1.4
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] common/sched: Fix ARM build following c/s 340edc3902
2018-03-07 20:04 ` Stefano Stabellini
@ 2018-03-08 9:37 ` Dario Faggioli
0 siblings, 0 replies; 4+ messages in thread
From: Dario Faggioli @ 2018-03-08 9:37 UTC (permalink / raw)
To: Stefano Stabellini, Andrew Cooper; +Cc: George Dunlap, Julien Grall, Xen-devel
[-- Attachment #1.1: Type: text/plain, Size: 1059 bytes --]
On Wed, 2018-03-07 at 12:04 -0800, Stefano Stabellini wrote:
> On Wed, 7 Mar 2018, Andrew Cooper wrote:
> > The OSSTest smoke tests reports:
> >
> > sched_credit2.c: In function 'csched2_alloc_domdata':
> > sched_credit2.c:3015:9: error: implicit declaration of function
> 'ERR_PTR' [-Werror=implicit-function-declaration]
> > return ERR_PTR(-ENOMEM);
> > ^
> > sched_credit2.c:3015:9: error: nested extern declaration of
> 'ERR_PTR' [-Werror=nested-externs]
> >
> > As the ERR infrastructure is part of the main scheduler interface
> now, include it from xen/sched-if.h
> >
> > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> Reviewed-by: Stefano Stabellini <sstabellini@kernel.org>
>
Reviewed-by: Dario Faggioli <dfaggioli@suse.com>
Regards,
Dario
--
<<This happens because I choose it to happen!>> (Raistlin Majere)
-----------------------------------------------------------------
Dario Faggioli, Ph.D, http://about.me/dario.faggioli
Software Engineer @ SUSE https://www.suse.com/
[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 157 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] common/sched: Fix ARM build following c/s 340edc3902
2018-03-07 19:41 [PATCH] common/sched: Fix ARM build following c/s 340edc3902 Andrew Cooper
2018-03-07 20:04 ` Stefano Stabellini
@ 2018-03-08 9:53 ` George Dunlap
1 sibling, 0 replies; 4+ messages in thread
From: George Dunlap @ 2018-03-08 9:53 UTC (permalink / raw)
To: Andrew Cooper, Xen-devel
Cc: George Dunlap, Julien Grall, Stefano Stabellini, Dario Faggioli
On 03/07/2018 07:41 PM, Andrew Cooper wrote:
> The OSSTest smoke tests reports:
>
> sched_credit2.c: In function 'csched2_alloc_domdata':
> sched_credit2.c:3015:9: error: implicit declaration of function 'ERR_PTR' [-Werror=implicit-function-declaration]
> return ERR_PTR(-ENOMEM);
> ^
> sched_credit2.c:3015:9: error: nested extern declaration of 'ERR_PTR' [-Werror=nested-externs]
>
> As the ERR infrastructure is part of the main scheduler interface now, include it from xen/sched-if.h
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: George Dunlap <george.dunlap@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-08 9:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-07 19:41 [PATCH] common/sched: Fix ARM build following c/s 340edc3902 Andrew Cooper
2018-03-07 20:04 ` Stefano Stabellini
2018-03-08 9:37 ` Dario Faggioli
2018-03-08 9:53 ` George Dunlap
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.