[igt-dev] [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[igt-dev] [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Chris Wilson]

Actually check the error state exists (!"No error state captured") and
that it contains the expected engine dump.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/drv_hangman.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
index 38cb20c3..65f3ea1f 100644
--- a/tests/drv_hangman.c
+++ b/tests/drv_hangman.c
@@ -129,6 +129,10 @@ static void check_error_state(const char *expected_ring_name,
 	FILE *file = open_error();
 	char *line = NULL;
 	size_t line_size = 0;
+	bool found = false;
+
+	getline(&line, &line_size, file);
+	igt_assert(strcasecmp(line, "No error state captured"));
 
 	while (getline(&line, &line_size, file) > 0) {
 		char *dashes;
@@ -168,12 +172,16 @@ static void check_error_state(const char *expected_ring_name,
 					 4*i, batch[i]);
 				igt_assert(strstr(line, expected_line));
 			}
+
+			found = true;
 			break;
 		}
 	}
 
 	free(line);
 	fclose(file);
+
+	igt_assert(found);
 }
 
 static void test_error_state_capture(unsigned ring_id,
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for igt/drv_hangman: Check that the error state does hold the expected state

[Patchwork]

== Series Details ==

Series: igt/drv_hangman: Check that the error state does hold the expected state
URL   : https://patchwork.freedesktop.org/series/39329/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
8c408f981cdc5945498e4e0e7f09423313d5e706 lib: Fix MI_BATCH_BUFFER_START for hang injection

with latest DRM-Tip kernel build CI_DRM_3868
c07ef2c77d14 drm-tip: 2018y-03m-03d-08h-39m-05s UTC integration manifest

No testlist changes.

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713 +1
Test gem_mmap_gtt:
        Subgroup basic-small-bo-tiledx:
                pass       -> FAIL       (fi-gdg-551) fdo#102575
Test kms_chamelium:
        Subgroup dp-edid-read:
                fail       -> PASS       (fi-kbl-7500u) fdo#102505
Test prime_vgem:
        Subgroup basic-fence-flip:
                pass       -> FAIL       (fi-ilk-650) fdo#104008

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#102505 https://bugs.freedesktop.org/show_bug.cgi?id=102505
fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:421s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:426s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:373s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:492s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:281s
fi-bxt-dsi       total:288  pass:258  dwarn:0   dfail:0   fail:0   skip:30  time:478s
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:484s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:469s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:459s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:394s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:563s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:416s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:291s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:510s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:385s
fi-ilk-650       total:288  pass:227  dwarn:0   dfail:0   fail:1   skip:60  time:410s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:453s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:412s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:449s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:487s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:451s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:497s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:589s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:427s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:502s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:520s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:493s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:471s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:405s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:431s
fi-snb-2520m     total:245  pass:211  dwarn:0   dfail:0   fail:0   skip:33 
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:394s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1049/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for igt/drv_hangman: Check that the error state does hold the expected state

[Patchwork]

== Series Details ==

Series: igt/drv_hangman: Check that the error state does hold the expected state
URL   : https://patchwork.freedesktop.org/series/39329/
State : failure

== Summary ==

---- Possible new issues:

Test drv_hangman:
        Subgroup error-state-capture-blt:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-bsd:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-render:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-vebox:
                pass       -> FAIL       (shard-apl)
Test kms_chv_cursor_fail:
        Subgroup pipe-c-128x128-bottom-edge:
                pass       -> FAIL       (shard-apl)
Test kms_vblank:
        Subgroup pipe-a-ts-continuation-suspend:
                skip       -> PASS       (shard-snb)

---- Known issues:

Test gem_eio:
        Subgroup in-flight-external:
                incomplete -> PASS       (shard-apl) fdo#104945 +1
Test kms_chv_cursor_fail:
        Subgroup pipe-b-64x64-left-edge:
                pass       -> DMESG-WARN (shard-snb) fdo#105185
Test kms_flip:
        Subgroup blocking-wf_vblank:
                fail       -> PASS       (shard-hsw) fdo#103928 +1
Test kms_rotation_crc:
        Subgroup primary-rotation-180:
                fail       -> PASS       (shard-snb) fdo#103925
Test kms_sysfs_edid_timing:
                warn       -> PASS       (shard-apl) fdo#100047

fdo#104945 https://bugs.freedesktop.org/show_bug.cgi?id=104945
fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:3463 pass:1818 dwarn:1   dfail:0   fail:12  skip:1632 time:12347s
shard-hsw        total:3463 pass:1770 dwarn:1   dfail:0   fail:1   skip:1690 time:11906s
shard-snb        total:3463 pass:1360 dwarn:3   dfail:0   fail:1   skip:2099 time:7129s
Blacklisted hosts:
shard-kbl        total:3417 pass:1926 dwarn:1   dfail:0   fail:7   skip:1482 time:9269s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1049/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: failure for igt/drv_hangman: Check that the error state does hold the expected state

[Arkadiusz Hiler]

On Sat, Mar 03, 2018 at 12:15:41PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: igt/drv_hangman: Check that the error state does hold the expected state
> URL   : https://patchwork.freedesktop.org/series/39329/
> State : failure
> 
> == Summary ==
> 
> ---- Possible new issues:
> 
> Test drv_hangman:
>         Subgroup error-state-capture-blt:
>                 pass       -> FAIL       (shard-apl)
>         Subgroup error-state-capture-bsd:
>                 pass       -> FAIL       (shard-apl)
>         Subgroup error-state-capture-render:
>                 pass       -> FAIL       (shard-apl)
>         Subgroup error-state-capture-vebox:
>                 pass       -> FAIL       (shard-apl)

(drv_hangman:XXXX) CRITICAL: Failed assertion: found
on all of them.

Looks like a legitimate issue with state capturing on APL.

> Test kms_chv_cursor_fail:
>         Subgroup pipe-c-128x128-bottom-edge:
>                 pass       -> FAIL       (shard-apl)

This seems to be unrelated.

- Arek
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Chris Wilson]

Actually check the error state exists (!"No error state captured") and
that it contains the expected engine dump.

v2: Throw in some debug clues.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/drv_hangman.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
index 38cb20c3..fa7becf5 100644
--- a/tests/drv_hangman.c
+++ b/tests/drv_hangman.c
@@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
 	FILE *file = open_error();
 	char *line = NULL;
 	size_t line_size = 0;
+	bool found = false;
+
+	igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
+		  __func__, expected_ring_name, expected_offset);
+	igt_debugfs_dump(device, "i915_error_state");
+
+	getline(&line, &line_size, file);
+	igt_assert(strcasecmp(line, "No error state captured"));
 
 	while (getline(&line, &line_size, file) > 0) {
 		char *dashes;
@@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
 					 4*i, batch[i]);
 				igt_assert(strstr(line, expected_line));
 			}
+
+			found = true;
 			break;
 		}
 	}
 
 	free(line);
 	fclose(file);
+
+	igt_assert(found);
 }
 
 static void test_error_state_capture(unsigned ring_id,
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Chris Wilson]

Actually check the error state exists (!"No error state captured") and
that it contains the expected engine dump.

v2: Throw in some debug clues.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/drv_hangman.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
index 38cb20c3..fa7becf5 100644
--- a/tests/drv_hangman.c
+++ b/tests/drv_hangman.c
@@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
 	FILE *file = open_error();
 	char *line = NULL;
 	size_t line_size = 0;
+	bool found = false;
+
+	igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
+		  __func__, expected_ring_name, expected_offset);
+	igt_debugfs_dump(device, "i915_error_state");
+
+	getline(&line, &line_size, file);
+	igt_assert(strcasecmp(line, "No error state captured"));
 
 	while (getline(&line, &line_size, file) > 0) {
 		char *dashes;
@@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
 					 4*i, batch[i]);
 				igt_assert(strstr(line, expected_line));
 			}
+
+			found = true;
 			break;
 		}
 	}
 
 	free(line);
 	fclose(file);
+
+	igt_assert(found);
 }
 
 static void test_error_state_capture(unsigned ring_id,
-- 
2.16.2

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] ✓ Fi.CI.BAT: success for igt/drv_hangman: Check that the error state does hold the expected state (rev2)

[Patchwork]

== Series Details ==

Series: igt/drv_hangman: Check that the error state does hold the expected state (rev2)
URL   : https://patchwork.freedesktop.org/series/39329/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
23f7da18a92059610792299cfdb03d2c922a9948 lib/igt_pm: Restore runtime pm state on test exit

with latest DRM-Tip kernel build CI_DRM_3870
2501aa775c7a drm-tip: 2018y-03m-05d-10h-55m-37s UTC integration manifest

No testlist changes.

fi-bdw-5557u     total:288  pass:267  dwarn:0   dfail:0   fail:0   skip:21  time:418s
fi-bdw-gvtdvm    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:424s
fi-blb-e6850     total:288  pass:223  dwarn:1   dfail:0   fail:0   skip:64  time:374s
fi-bsw-n3050     total:288  pass:242  dwarn:0   dfail:0   fail:0   skip:46  time:494s
fi-bwr-2160      total:288  pass:183  dwarn:0   dfail:0   fail:0   skip:105 time:280s
fi-bxt-dsi       total:118  pass:106  dwarn:0   dfail:0   fail:0   skip:12 
fi-bxt-j4205     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:486s
fi-byt-j1900     total:288  pass:253  dwarn:0   dfail:0   fail:0   skip:35  time:474s
fi-byt-n2820     total:288  pass:249  dwarn:0   dfail:0   fail:0   skip:39  time:458s
fi-cfl-8700k     total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:396s
fi-cfl-s2        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:560s
fi-cnl-y3        total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:569s
fi-elk-e7500     total:288  pass:229  dwarn:0   dfail:0   fail:0   skip:59  time:417s
fi-gdg-551       total:288  pass:179  dwarn:0   dfail:0   fail:1   skip:108 time:288s
fi-glk-1         total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:510s
fi-hsw-4770      total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:389s
fi-ilk-650       total:288  pass:228  dwarn:0   dfail:0   fail:0   skip:60  time:408s
fi-ivb-3520m     total:288  pass:259  dwarn:0   dfail:0   fail:0   skip:29  time:446s
fi-ivb-3770      total:288  pass:255  dwarn:0   dfail:0   fail:0   skip:33  time:411s
fi-kbl-7500u     total:288  pass:263  dwarn:1   dfail:0   fail:0   skip:24  time:452s
fi-kbl-7560u     total:288  pass:269  dwarn:0   dfail:0   fail:0   skip:19  time:487s
fi-kbl-7567u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:449s
fi-kbl-r         total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:491s
fi-pnv-d510      total:288  pass:222  dwarn:1   dfail:0   fail:0   skip:65  time:586s
fi-skl-6260u     total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:435s
fi-skl-6600u     total:288  pass:261  dwarn:0   dfail:0   fail:0   skip:27  time:504s
fi-skl-6700hq    total:288  pass:262  dwarn:0   dfail:0   fail:0   skip:26  time:517s
fi-skl-6700k2    total:288  pass:264  dwarn:0   dfail:0   fail:0   skip:24  time:492s
fi-skl-6770hq    total:288  pass:268  dwarn:0   dfail:0   fail:0   skip:20  time:481s
fi-skl-guc       total:288  pass:260  dwarn:0   dfail:0   fail:0   skip:28  time:408s
fi-skl-gvtdvm    total:288  pass:265  dwarn:0   dfail:0   fail:0   skip:23  time:427s
fi-snb-2520m     total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:517s
fi-snb-2600      total:288  pass:248  dwarn:0   dfail:0   fail:0   skip:40  time:398s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1054/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: failure for igt/drv_hangman: Check that the error state does hold the expected state (rev2)

[Patchwork]

== Series Details ==

Series: igt/drv_hangman: Check that the error state does hold the expected state (rev2)
URL   : https://patchwork.freedesktop.org/series/39329/
State : failure

== Summary ==

---- Possible new issues:

Test drv_hangman:
        Subgroup error-state-capture-blt:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-bsd:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-render:
                pass       -> FAIL       (shard-apl)
        Subgroup error-state-capture-vebox:
                pass       -> FAIL       (shard-apl)

---- Known issues:

Test kms_chv_cursor_fail:
        Subgroup pipe-b-256x256-left-edge:
                dmesg-warn -> PASS       (shard-snb) fdo#105185 +2
Test kms_cursor_crc:
        Subgroup cursor-256x256-suspend:
                pass       -> INCOMPLETE (shard-snb) fdo#103375
Test kms_flip:
        Subgroup plain-flip-ts-check-interruptible:
                pass       -> FAIL       (shard-hsw) fdo#100368
Test kms_frontbuffer_tracking:
        Subgroup basic:
                fail       -> PASS       (shard-apl) fdo#103167
        Subgroup fbc-suspend:
                skip       -> PASS       (shard-hsw) fdo#103540
Test kms_sysfs_edid_timing:
                pass       -> WARN       (shard-apl) fdo#100047

fdo#105185 https://bugs.freedesktop.org/show_bug.cgi?id=105185
fdo#103375 https://bugs.freedesktop.org/show_bug.cgi?id=103375
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047

shard-apl        total:3457 pass:1815 dwarn:1   dfail:0   fail:10  skip:1629 time:11838s
shard-hsw        total:3468 pass:1773 dwarn:1   dfail:0   fail:2   skip:1691 time:11729s
shard-snb        total:3373 pass:1324 dwarn:2   dfail:0   fail:1   skip:2045 time:6840s
Blacklisted hosts:
shard-kbl        total:3396 pass:1911 dwarn:1   dfail:0   fail:6   skip:1476 time:8760s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1054/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Antonio Argenziano]

On 05/03/18 02:09, Chris Wilson wrote:
> Actually check the error state exists (!"No error state captured") and
> that it contains the expected engine dump.
> 
> v2: Throw in some debug clues.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/drv_hangman.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> index 38cb20c3..fa7becf5 100644
> --- a/tests/drv_hangman.c
> +++ b/tests/drv_hangman.c
> @@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
>   	FILE *file = open_error();
>   	char *line = NULL;
>   	size_t line_size = 0;
> +	bool found = false;
> +
> +	igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
> +		  __func__, expected_ring_name, expected_offset);
> +	igt_debugfs_dump(device, "i915_error_state");
> +
> +	getline(&line, &line_size, file);
> +	igt_assert(strcasecmp(line, "No error state captured"));
>   
>   	while (getline(&line, &line_size, file) > 0) {
>   		char *dashes;
> @@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
>   					 4*i, batch[i]);
>   				igt_assert(strstr(line, expected_line));
>   			}
> +
> +			found = true;
>   			break;
>   		}
>   	}
>   
>   	free(line);
>   	fclose(file);
> +
> +	igt_assert(found);

Test changes look fine to me, failures on CI seems to be caused by the 
test not waiting for reset to happen only before we would have not 
caught it.

Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>

>   }
>   
>   static void test_error_state_capture(unsigned ring_id,
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Antonio Argenziano]

On 05/03/18 02:09, Chris Wilson wrote:
> Actually check the error state exists (!"No error state captured") and
> that it contains the expected engine dump.
> 
> v2: Throw in some debug clues.
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/drv_hangman.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> index 38cb20c3..fa7becf5 100644
> --- a/tests/drv_hangman.c
> +++ b/tests/drv_hangman.c
> @@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
>   	FILE *file = open_error();
>   	char *line = NULL;
>   	size_t line_size = 0;
> +	bool found = false;
> +
> +	igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
> +		  __func__, expected_ring_name, expected_offset);
> +	igt_debugfs_dump(device, "i915_error_state");
> +
> +	getline(&line, &line_size, file);
> +	igt_assert(strcasecmp(line, "No error state captured"));
>   
>   	while (getline(&line, &line_size, file) > 0) {
>   		char *dashes;
> @@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
>   					 4*i, batch[i]);
>   				igt_assert(strstr(line, expected_line));
>   			}
> +
> +			found = true;
>   			break;
>   		}
>   	}
>   
>   	free(line);
>   	fclose(file);
> +
> +	igt_assert(found);

Test changes look fine to me, failures on CI seems to be caused by the 
test not waiting for reset to happen only before we would have not 
caught it.

Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>

>   }
>   
>   static void test_error_state_capture(unsigned ring_id,
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Chris Wilson]

Quoting Antonio Argenziano (2018-03-05 19:10:37)
> 
> 
> On 05/03/18 02:09, Chris Wilson wrote:
> > Actually check the error state exists (!"No error state captured") and
> > that it contains the expected engine dump.
> > 
> > v2: Throw in some debug clues.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   tests/drv_hangman.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> > index 38cb20c3..fa7becf5 100644
> > --- a/tests/drv_hangman.c
> > +++ b/tests/drv_hangman.c
> > @@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
> >       FILE *file = open_error();
> >       char *line = NULL;
> >       size_t line_size = 0;
> > +     bool found = false;
> > +
> > +     igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
> > +               __func__, expected_ring_name, expected_offset);
> > +     igt_debugfs_dump(device, "i915_error_state");
> > +
> > +     getline(&line, &line_size, file);
> > +     igt_assert(strcasecmp(line, "No error state captured"));
> >   
> >       while (getline(&line, &line_size, file) > 0) {
> >               char *dashes;
> > @@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
> >                                        4*i, batch[i]);
> >                               igt_assert(strstr(line, expected_line));
> >                       }
> > +
> > +                     found = true;
> >                       break;
> >               }
> >       }
> >   
> >       free(line);
> >       fclose(file);
> > +
> > +     igt_assert(found);
> 
> Test changes look fine to me, failures on CI seems to be caused by the 
> test not waiting for reset to happen only before we would have not 
> caught it.
> 
> Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>

Fixed the kernel bug, clearing the way for this patch to land.

Thanks for the review,
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [Intel-gfx] [PATCH igt] igt/drv_hangman: Check that the error state does hold the expected state

[Chris Wilson]

Quoting Antonio Argenziano (2018-03-05 19:10:37)
> 
> 
> On 05/03/18 02:09, Chris Wilson wrote:
> > Actually check the error state exists (!"No error state captured") and
> > that it contains the expected engine dump.
> > 
> > v2: Throw in some debug clues.
> > 
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > ---
> >   tests/drv_hangman.c | 12 ++++++++++++
> >   1 file changed, 12 insertions(+)
> > 
> > diff --git a/tests/drv_hangman.c b/tests/drv_hangman.c
> > index 38cb20c3..fa7becf5 100644
> > --- a/tests/drv_hangman.c
> > +++ b/tests/drv_hangman.c
> > @@ -129,6 +129,14 @@ static void check_error_state(const char *expected_ring_name,
> >       FILE *file = open_error();
> >       char *line = NULL;
> >       size_t line_size = 0;
> > +     bool found = false;
> > +
> > +     igt_debug("%s(expected ring name=%s, expected offset=%"PRIx64")\n",
> > +               __func__, expected_ring_name, expected_offset);
> > +     igt_debugfs_dump(device, "i915_error_state");
> > +
> > +     getline(&line, &line_size, file);
> > +     igt_assert(strcasecmp(line, "No error state captured"));
> >   
> >       while (getline(&line, &line_size, file) > 0) {
> >               char *dashes;
> > @@ -168,12 +176,16 @@ static void check_error_state(const char *expected_ring_name,
> >                                        4*i, batch[i]);
> >                               igt_assert(strstr(line, expected_line));
> >                       }
> > +
> > +                     found = true;
> >                       break;
> >               }
> >       }
> >   
> >       free(line);
> >       fclose(file);
> > +
> > +     igt_assert(found);
> 
> Test changes look fine to me, failures on CI seems to be caused by the 
> test not waiting for reset to happen only before we would have not 
> caught it.
> 
> Reviwed-by: Antonio Argenziano <antonio.argenziano@intel.com>

Fixed the kernel bug, clearing the way for this patch to land.

Thanks for the review,
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev