All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] wine: Drop glibc requirement
@ 2018-03-09 10:20 André Hentschel
  2018-03-11 21:25 ` Peter Korsgaard
  0 siblings, 1 reply; 3+ messages in thread
From: André Hentschel @ 2018-03-09 10:20 UTC (permalink / raw)
  To: buildroot

I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db

Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
---
 package/wine/Config.in | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/wine/Config.in b/package/wine/Config.in
index c674288..627a9a7 100644
--- a/package/wine/Config.in
+++ b/package/wine/Config.in
@@ -1,6 +1,5 @@
 config BR2_PACKAGE_WINE
 	bool "wine"
-	depends on BR2_TOOLCHAIN_USES_GLIBC
 	# Wine only builds on certain architectures
 	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86" || \
 	           BR2_HOSTARCH = "powerpc" || BR2_HOSTARCH = "arm" || \
@@ -16,8 +15,3 @@ config BR2_PACKAGE_WINE
 	  methods.
 
 	  http://www.winehq.org
-
-comment "wine needs a glibc toolchain"
-	depends on BR2_HOSTARCH = "x86_64" || BR2_HOSTARCH = "x86"
-	depends on BR2_i386
-	depends on !BR2_TOOLCHAIN_USES_GLIBC
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] wine: Drop glibc requirement
  2018-03-09 10:20 [Buildroot] [PATCH] wine: Drop glibc requirement André Hentschel
@ 2018-03-11 21:25 ` Peter Korsgaard
  2018-03-15 19:43   ` André Hentschel
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Korsgaard @ 2018-03-11 21:25 UTC (permalink / raw)
  To: buildroot

>>>>> "Andr?" == Andr? Hentschel <nerv@dawncrow.de> writes:

 > I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
 > https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db

 > Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>

Committed, thanks.

Have you verified that E.G. a static only uClibc configuration works?
test-pkg is handy for such checks.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH] wine: Drop glibc requirement
  2018-03-11 21:25 ` Peter Korsgaard
@ 2018-03-15 19:43   ` André Hentschel
  0 siblings, 0 replies; 3+ messages in thread
From: André Hentschel @ 2018-03-15 19:43 UTC (permalink / raw)
  To: buildroot

Am 11.03.2018 um 22:25 schrieb Peter Korsgaard:
>>>>>> "Andr?" == Andr? Hentschel <nerv@dawncrow.de> writes:
> 
>  > I noticed it's not needed anymore, musl went upstream at some point and uClibc is now build with bessel functions:
>  > https://git.buildroot.net/buildroot/commit/package/uclibc?id=de56d58e5d26d78161ca3b7a1a2a4decfe4e89db
> 
>  > Signed-off-by: Andr? Hentschel <nerv@dawncrow.de>
> 
> Committed, thanks.
> 
> Have you verified that E.G. a static only uClibc configuration works?
> test-pkg is handy for such checks.
> 

Hi,

Thanks!
In fact Wine has multiple issues with static only, I'll send a patch

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-15 19:43 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-09 10:20 [Buildroot] [PATCH] wine: Drop glibc requirement André Hentschel
2018-03-11 21:25 ` Peter Korsgaard
2018-03-15 19:43   ` André Hentschel

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.