All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"steve@sk2.org" <steve@sk2.org>, "hare@suse.com" <hare@suse.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH] device_handler: remove VLAs
Date: Fri, 9 Mar 2018 22:48:10 +0000	[thread overview]
Message-ID: <1520635688.2907.17.camel@wdc.com> (raw)
In-Reply-To: <20180309223211.20473-1-steve@sk2.org>

T24gRnJpLCAyMDE4LTAzLTA5IGF0IDIzOjMyICswMTAwLCBTdGVwaGVuIEtpdHQgd3JvdGU6DQo+
IEluIHByZXBhcmF0aW9uIHRvIGVuYWJsaW5nIC1XdmxhLCByZW1vdmUgVkxBcyBhbmQgcmVwbGFj
ZSB0aGVtIHdpdGgNCj4gZml4ZWQtbGVuZ3RoIGFycmF5cyBpbnN0ZWFkLg0KPiANCj4gc2NzaV9k
aF97YWx1YSxlbWMscmRhY30gdXNlIHZhcmlhYmxlLWxlbmd0aCBhcnJheSBkZWNsYXJhdGlvbnMg
dG8NCj4gc3RvcmUgY29tbWFuZCBibG9ja3MsIHdpdGggdGhlIGFwcHJvcHJpYXRlIHNpemUgYXMg
ZGV0ZXJtaW5lZCBieQ0KPiBDT01NQU5EX1NJWkUuIFRoaXMgcGF0Y2ggcmVwbGFjZXMgdGhlc2Ug
d2l0aCBmaXhlZC1zaXplZCBhcnJheXMgdXNpbmcNCj4gTUFYX0NPTU1BTkRfU0laRSwgc28gdGhh
dCB0aGUgYXJyYXkgc2l6ZSBjYW4gYmUgZGV0ZXJtaW5lZCBhdCBjb21waWxlDQo+IHRpbWUuDQoN
CklmIENPTU1BTkRfU0laRSgpIGlzIGV2YWx1YXRlZCBhdCBjb21waWxlIHRpbWUsIGRvIHdlIHN0
aWxsIG5lZWQgdGhpcyBwYXRjaD8NCg0KVGhhbmtzLA0KDQpCYXJ0Lg0KDQoNCg==

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <Bart.VanAssche@wdc.com>
To: "jejb@linux.vnet.ibm.com" <jejb@linux.vnet.ibm.com>,
	"steve@sk2.org" <steve@sk2.org>, "hare@suse.com" <hare@suse.com>,
	"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
	"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
	"kernel-hardening@lists.openwall.com"
	<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH] device_handler: remove VLAs
Date: Fri, 9 Mar 2018 22:48:10 +0000	[thread overview]
Message-ID: <1520635688.2907.17.camel@wdc.com> (raw)
In-Reply-To: <20180309223211.20473-1-steve@sk2.org>

On Fri, 2018-03-09 at 23:32 +0100, Stephen Kitt wrote:
> In preparation to enabling -Wvla, remove VLAs and replace them with
> fixed-length arrays instead.
> 
> scsi_dh_{alua,emc,rdac} use variable-length array declarations to
> store command blocks, with the appropriate size as determined by
> COMMAND_SIZE. This patch replaces these with fixed-sized arrays using
> MAX_COMMAND_SIZE, so that the array size can be determined at compile
> time.

If COMMAND_SIZE() is evaluated at compile time, do we still need this patch?

Thanks,

Bart.



  reply	other threads:[~2018-03-09 22:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09 22:29 VLA removal, device_handler and COMMAND_SIZE Stephen Kitt
2018-03-09 22:32 ` [PATCH] device_handler: remove VLAs Stephen Kitt
2018-03-09 22:48   ` Bart Van Assche [this message]
2018-03-09 22:48     ` Bart Van Assche
2018-03-10 13:14     ` Stephen Kitt
2018-03-12 15:41       ` Bart Van Assche
2018-03-12 15:41         ` Bart Van Assche
2018-03-12 19:26         ` Stephen Kitt
2018-03-12  6:25   ` Hannes Reinecke
2018-03-13  2:37   ` Martin K. Petersen
2018-03-09 22:33 ` [PATCH] scsi: resolve COMMAND_SIZE at compile time Stephen Kitt
2018-03-09 22:47   ` Bart Van Assche
2018-03-09 22:47     ` Bart Van Assche
2018-03-10 13:29     ` Stephen Kitt
2018-03-10 20:49       ` James Bottomley
2018-03-10 21:16         ` Douglas Gilbert
2018-03-11 15:01         ` Stephen Kitt
2018-03-11 15:01           ` Stephen Kitt
2018-03-13 11:34   ` David Laight
2018-03-13 11:34     ` David Laight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520635688.2907.17.camel@wdc.com \
    --to=bart.vanassche@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.com \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=steve@sk2.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.