All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Martincoski <ricardo.martincoski@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 5/7] support/dockerfile: install flake8
Date: Sun, 11 Mar 2018 02:15:32 -0300	[thread overview]
Message-ID: <1520745334-13411-6-git-send-email-ricardo.martincoski@gmail.com> (raw)
In-Reply-To: <1520745334-13411-1-git-send-email-ricardo.martincoski@gmail.com>

Use the latest version of the tool because it is actively maintained.
But use a fixed version of the tool and its dependencies to get stable
results. It can be manually bumped from time to time.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
Cc: Peter Korsgaard <peter@korsgaard.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:  (suggested by Yann E. MORIN)
  - install flake8 to the base docker image instead of adding sudo to
    install tools on the fly.
---
 support/docker/Dockerfile | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/support/docker/Dockerfile b/support/docker/Dockerfile
index ce3fdd9..f2ba064 100644
--- a/support/docker/Dockerfile
+++ b/support/docker/Dockerfile
@@ -27,10 +27,15 @@ RUN dpkg --add-architecture i386 && \
         cvs bzr git mercurial subversion wget \
         cpio unzip \
         libncurses5-dev \
-        python-nose2 python-pexpect qemu-system-arm qemu-system-x86 && \
+        python-nose2 python-pexpect qemu-system-arm qemu-system-x86 \
+        python-pip && \
     apt-get -y autoremove && \
     apt-get -y clean
 
+# For check-flake8
+RUN pip install -q setuptools
+RUN pip install -q flake8==3.5.0 mccabe==0.6.1 pycodestyle==2.3.1 pyflakes==1.6.0
+
 # To be able to generate a toolchain with locales, enable one UTF-8 locale
 RUN sed -i 's/# \(en_US.UTF-8\)/\1/' /etc/locale.gen && \
     /usr/sbin/locale-gen
-- 
2.7.4

  parent reply	other threads:[~2018-03-11  5:15 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-22  0:44 [Buildroot] [PATCH 00/14] fix Python code style Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 01/14] graph-depends: fix " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 02/14] check-uniq-files: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 03/14] graph-build-time: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 04/14] pycompile: " Ricardo Martincoski
2018-01-22  8:50   ` Yegor Yefremov
2018-01-22  0:44 ` [Buildroot] [PATCH 05/14] size-stats: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 06/14] testing/tests/boot/test_atf: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 07/14] check-package: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 08/14] diffconfig: " Ricardo Martincoski
2018-01-29 22:11   ` Thomas Petazzoni
2018-01-30 20:25     ` Marcus Folkesson
2018-02-13  3:14       ` Ricardo Martincoski
2018-02-13  7:49         ` Thomas Petazzoni
2018-02-13  8:44           ` Marcus Folkesson
2018-02-14  0:32             ` Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 09/14] genrandconfig: " Ricardo Martincoski
2018-01-29 22:12   ` Thomas Petazzoni
2018-02-13  3:12     ` Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 10/14] get-developers: " Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 11/14] scanpypi: " Ricardo Martincoski
2018-01-22  8:49   ` Yegor Yefremov
2018-01-22  0:44 ` [Buildroot] [PATCH 12/14] size-stats-compare: " Ricardo Martincoski
2018-01-29 22:13   ` Thomas Petazzoni
2018-02-03 15:24     ` Yann E. MORIN
2018-02-13  3:28       ` Ricardo Martincoski
2018-02-13  7:51         ` Thomas Petazzoni
2018-02-13 20:53           ` Thomas De Schampheleire
2018-01-22  0:44 ` [Buildroot] [PATCH 13/14] support/dockerfile: allow to install packages Ricardo Martincoski
2018-02-03 15:26   ` Yann E. MORIN
2018-02-13  3:42     ` Ricardo Martincoski
2018-01-22  0:44 ` [Buildroot] [PATCH 14/14] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-01-29 22:14 ` [Buildroot] [PATCH 00/14] fix Python code style Thomas Petazzoni
2018-03-11  5:15 ` [Buildroot] [PATCH v2 0/7] fix Python code style v2 Ricardo Martincoski
2018-03-11  5:15   ` [Buildroot] [PATCH v2 1/7] genrandconfig: fix code style Ricardo Martincoski
2018-03-11  5:15   ` [Buildroot] [PATCH v2 2/7] size-stats-compare: " Ricardo Martincoski
2018-03-11  8:57     ` Yann E. MORIN
2018-03-11  5:15   ` [Buildroot] [PATCH v2 3/7] test_python_cryptography: " Ricardo Martincoski
2018-03-11  5:15   ` [Buildroot] [PATCH v2 4/7] scanpypi: " Ricardo Martincoski
2018-03-11  5:15   ` Ricardo Martincoski [this message]
2018-03-11  8:51     ` [Buildroot] [PATCH v2 5/7] support/dockerfile: install flake8 Yann E. MORIN
2018-03-12  1:19       ` Ricardo Martincoski
2018-03-11  5:15   ` [Buildroot] [PATCH v2 6/7] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-03-11  8:54     ` Yann E. MORIN
2018-03-11  5:15   ` [Buildroot] [PATCH v2 7/7] .flake8: ignore utils/diffconfig Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520745334-13411-6-git-send-email-ricardo.martincoski@gmail.com \
    --to=ricardo.martincoski@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.