From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 12/14] size-stats-compare: fix code style
Date: Tue, 13 Feb 2018 08:51:34 +0100 [thread overview]
Message-ID: <20180213085134.0e2096dc@windsurf.lan> (raw)
In-Reply-To: <5a825b5fea220_51963fbb9ca374f047327@ultri3.mail>
Hello,
On Tue, 13 Feb 2018 01:28:31 -0200, Ricardo Martincoski wrote:
> ... This is present in other scripts and I missed that in v1. I plan to use it
> if you don't oppose to.
>
> if header[0] != 'File name' or header[1] != 'Package name' or \
> header[2] != 'File size' or header[3] != 'Package size':
> print(("Input file %s does not contain the expected header. Are you "
This version looks good to me. The parenthesis around the if condition
are useless in Python.
Thomas
--
Thomas Petazzoni, CTO, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
next prev parent reply other threads:[~2018-02-13 7:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 0:44 [Buildroot] [PATCH 00/14] fix Python code style Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 01/14] graph-depends: fix " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 02/14] check-uniq-files: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 03/14] graph-build-time: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 04/14] pycompile: " Ricardo Martincoski
2018-01-22 8:50 ` Yegor Yefremov
2018-01-22 0:44 ` [Buildroot] [PATCH 05/14] size-stats: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 06/14] testing/tests/boot/test_atf: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 07/14] check-package: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 08/14] diffconfig: " Ricardo Martincoski
2018-01-29 22:11 ` Thomas Petazzoni
2018-01-30 20:25 ` Marcus Folkesson
2018-02-13 3:14 ` Ricardo Martincoski
2018-02-13 7:49 ` Thomas Petazzoni
2018-02-13 8:44 ` Marcus Folkesson
2018-02-14 0:32 ` Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 09/14] genrandconfig: " Ricardo Martincoski
2018-01-29 22:12 ` Thomas Petazzoni
2018-02-13 3:12 ` Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 10/14] get-developers: " Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 11/14] scanpypi: " Ricardo Martincoski
2018-01-22 8:49 ` Yegor Yefremov
2018-01-22 0:44 ` [Buildroot] [PATCH 12/14] size-stats-compare: " Ricardo Martincoski
2018-01-29 22:13 ` Thomas Petazzoni
2018-02-03 15:24 ` Yann E. MORIN
2018-02-13 3:28 ` Ricardo Martincoski
2018-02-13 7:51 ` Thomas Petazzoni [this message]
2018-02-13 20:53 ` Thomas De Schampheleire
2018-01-22 0:44 ` [Buildroot] [PATCH 13/14] support/dockerfile: allow to install packages Ricardo Martincoski
2018-02-03 15:26 ` Yann E. MORIN
2018-02-13 3:42 ` Ricardo Martincoski
2018-01-22 0:44 ` [Buildroot] [PATCH 14/14] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-01-29 22:14 ` [Buildroot] [PATCH 00/14] fix Python code style Thomas Petazzoni
2018-03-11 5:15 ` [Buildroot] [PATCH v2 0/7] fix Python code style v2 Ricardo Martincoski
2018-03-11 5:15 ` [Buildroot] [PATCH v2 1/7] genrandconfig: fix code style Ricardo Martincoski
2018-03-11 5:15 ` [Buildroot] [PATCH v2 2/7] size-stats-compare: " Ricardo Martincoski
2018-03-11 8:57 ` Yann E. MORIN
2018-03-11 5:15 ` [Buildroot] [PATCH v2 3/7] test_python_cryptography: " Ricardo Martincoski
2018-03-11 5:15 ` [Buildroot] [PATCH v2 4/7] scanpypi: " Ricardo Martincoski
2018-03-11 5:15 ` [Buildroot] [PATCH v2 5/7] support/dockerfile: install flake8 Ricardo Martincoski
2018-03-11 8:51 ` Yann E. MORIN
2018-03-12 1:19 ` Ricardo Martincoski
2018-03-11 5:15 ` [Buildroot] [PATCH v2 6/7] .gitlab-ci.yml: check flake8 Ricardo Martincoski
2018-03-11 8:54 ` Yann E. MORIN
2018-03-11 5:15 ` [Buildroot] [PATCH v2 7/7] .flake8: ignore utils/diffconfig Ricardo Martincoski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180213085134.0e2096dc@windsurf.lan \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.