* Patch "Input: tca8418_keypad - remove double read of key event register" has been added to the 4.4-stable tree
@ 2018-03-13 11:15 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2018-03-13 11:15 UTC (permalink / raw)
To: dmitry.torokhov, ben.hutchings, gregkh; +Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
Input: tca8418_keypad - remove double read of key event register
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
input-tca8418_keypad-remove-double-read-of-key-event-register.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 9dd46c02532a6bed6240101ecf4bbc407f8c6adf Mon Sep 17 00:00:00 2001
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: Mon, 13 Feb 2017 15:45:59 -0800
Subject: Input: tca8418_keypad - remove double read of key event register
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
commit 9dd46c02532a6bed6240101ecf4bbc407f8c6adf upstream.
There is no need to tread the same register twice in a row.
Fixes: ea4348c8462a ("Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-un ...")
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ben Hutchings <ben.hutchings@codethink.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/input/keyboard/tca8418_keypad.c | 2 --
1 file changed, 2 deletions(-)
--- a/drivers/input/keyboard/tca8418_keypad.c
+++ b/drivers/input/keyboard/tca8418_keypad.c
@@ -189,8 +189,6 @@ static void tca8418_read_keypad(struct t
input_event(input, EV_MSC, MSC_SCAN, code);
input_report_key(input, keymap[code], state);
- /* Read for next loop */
- error = tca8418_read_byte(keypad_data, REG_KEY_EVENT_A, ®);
} while (1);
input_sync(input);
Patches currently in stable-queue which might be from dmitry.torokhov@gmail.com are
queue-4.4/input-tca8418_keypad-remove-double-read-of-key-event-register.patch
queue-4.4/input-matrix_keypad-fix-race-when-disabling-interrupts.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-03-13 11:15 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-13 11:15 Patch "Input: tca8418_keypad - remove double read of key event register" has been added to the 4.4-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.