All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv()
@ 2018-03-15  6:20 Ganapathi Bhat
  2018-03-15 12:59 ` Kalle Valo
  2018-03-27  8:03 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Ganapathi Bhat @ 2018-03-15  6:20 UTC (permalink / raw)
  To: linux-wireless
  Cc: Brian Norris, Cathy Luo, Xinming Hu, Zhiyuan Yang, James Cao,
	Mangesh Malusare, Ganapathi Bhat

Fix the following sparse warning in mwifiex_cmd_append_11n_tlv:
drivers/net/wireless/marvell/mwifiex/11n.c:358:65: warning: invalid assignment: &=
drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    left side has type restricted __le16
drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    right side has type int
drivers/net/wireless/marvell/mwifiex/11n.c:360:65: warning: invalid assignment: &=
drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    left side has type restricted __le16
drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    right side has type int
drivers/net/wireless/marvell/mwifiex/11n.c:366:65: warning: invalid assignment: &=
drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    left side has type restricted __le16
drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    right side has type int
drivers/net/wireless/marvell/mwifiex/11n.c:368:65: warning: invalid assignment: &=
drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    left side has type restricted __le16
drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    right side has type int

This is a follow up to commit 77423fa73927
("mwifiex: fix incorrect ht capability problem")

Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>
---
 drivers/net/wireless/marvell/mwifiex/11n.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/marvell/mwifiex/11n.c b/drivers/net/wireless/marvell/mwifiex/11n.c
index feebfdc..5d75c97 100644
--- a/drivers/net/wireless/marvell/mwifiex/11n.c
+++ b/drivers/net/wireless/marvell/mwifiex/11n.c
@@ -356,17 +356,19 @@ int mwifiex_cmd_11n_cfg(struct mwifiex_private *priv,
 			case IEEE80211_HT_PARAM_CHA_SEC_ABOVE:
 				if (chan->flags & IEEE80211_CHAN_NO_HT40PLUS) {
 					ht_cap->ht_cap.cap_info &=
-					~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+					cpu_to_le16
+					(~IEEE80211_HT_CAP_SUP_WIDTH_20_40);
 					ht_cap->ht_cap.cap_info &=
-					~IEEE80211_HT_CAP_SGI_40;
+					cpu_to_le16(~IEEE80211_HT_CAP_SGI_40);
 				}
 				break;
 			case IEEE80211_HT_PARAM_CHA_SEC_BELOW:
 				if (chan->flags & IEEE80211_CHAN_NO_HT40MINUS) {
 					ht_cap->ht_cap.cap_info &=
-					~IEEE80211_HT_CAP_SUP_WIDTH_20_40;
+					cpu_to_le16
+					(~IEEE80211_HT_CAP_SUP_WIDTH_20_40);
 					ht_cap->ht_cap.cap_info &=
-					~IEEE80211_HT_CAP_SGI_40;
+					cpu_to_le16(~IEEE80211_HT_CAP_SGI_40);
 				}
 				break;
 			}
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread
* Re: [PATCH] mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv()
  2018-03-15  6:20 [PATCH] mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv() Ganapathi Bhat
@ 2018-03-15 12:59 ` Kalle Valo
  2018-03-27  8:03 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-03-15 12:59 UTC (permalink / raw)
  To: Ganapathi Bhat
  Cc: linux-wireless, Brian Norris, Cathy Luo, Xinming Hu,
	Zhiyuan Yang, James Cao, Mangesh Malusare

Ganapathi Bhat <gbhat@marvell.com> writes:

> Fix the following sparse warning in mwifiex_cmd_append_11n_tlv:
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    right side has type int
>
> This is a follow up to commit 77423fa73927
> ("mwifiex: fix incorrect ht capability problem")

I'll replace this sentence with:

Fixes: 77423fa73927 ("mwifiex: fix incorrect ht capability problem")

-- 
Kalle Valo

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv()
  2018-03-15  6:20 [PATCH] mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv() Ganapathi Bhat
  2018-03-15 12:59 ` Kalle Valo
@ 2018-03-27  8:03 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2018-03-27  8:03 UTC (permalink / raw)
  To: Ganapathi Bhat
  Cc: linux-wireless, Brian Norris, Cathy Luo, Xinming Hu,
	Zhiyuan Yang, James Cao, Mangesh Malusare, Ganapathi Bhat

Ganapathi Bhat <gbhat@marvell.com> wrote:

> Fix the following sparse warning in mwifiex_cmd_append_11n_tlv:
> 
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:358:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:360:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:366:65:    right side has type int
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65: warning: invalid assignment: &=
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    left side has type restricted __le16
> drivers/net/wireless/marvell/mwifiex/11n.c:368:65:    right side has type int
> 
> Fixes: 77423fa73927 ("mwifiex: fix incorrect ht capability problem")
> Signed-off-by: Ganapathi Bhat <gbhat@marvell.com>

Patch applied to wireless-drivers-next.git, thanks.

6c20495b7deb mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv()

-- 
https://patchwork.kernel.org/patch/10283921/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-27  8:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15  6:20 [PATCH] mwifiex: remove warnings in mwifiex_cmd_append_11n_tlv() Ganapathi Bhat
2018-03-15 12:59 ` Kalle Valo
2018-03-27  8:03 ` Kalle Valo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.