* [PATCH] mfd: dt-bindings: Add PMIC reset property
@ 2018-03-15 10:58 Daniel Schultz
2018-03-18 12:52 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Schultz @ 2018-03-15 10:58 UTC (permalink / raw)
To: robh+dt, mark.rutland; +Cc: heiko, w.egorov, devicetree, linux-kernel
Add documentation about a new rk808 devicetree property, which can
enable resets by the PMIC.
Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
---
Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
index 91b6522..fa1a30f 100644
--- a/Documentation/devicetree/bindings/mfd/rk808.txt
+++ b/Documentation/devicetree/bindings/mfd/rk808.txt
@@ -20,6 +20,8 @@ Optional properties:
default output clock name
- rockchip,system-power-controller: Telling whether or not this pmic is controlling
the system power.
+- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
+ the system reset.
Optional RK805 properties:
- vcc1-supply: The input supply for DCDC_REG1
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: dt-bindings: Add PMIC reset property
2018-03-15 10:58 [PATCH] mfd: dt-bindings: Add PMIC reset property Daniel Schultz
@ 2018-03-18 12:52 ` Rob Herring
2018-03-29 14:46 ` Daniel Schultz
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2018-03-18 12:52 UTC (permalink / raw)
To: Daniel Schultz; +Cc: mark.rutland, heiko, w.egorov, devicetree, linux-kernel
On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote:
> Add documentation about a new rk808 devicetree property, which can
> enable resets by the PMIC.
The subject needs to be more specific that this is for Rockchip PMIC.
>
> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
> ---
> Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
> index 91b6522..fa1a30f 100644
> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
> @@ -20,6 +20,8 @@ Optional properties:
> default output clock name
> - rockchip,system-power-controller: Telling whether or not this pmic is controlling
> the system power.
> +- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
> + the system reset.
Would you ever really have power and reset controlled by different
things? IOW, why do we need 2 properties?
Rob
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: dt-bindings: Add PMIC reset property
2018-03-18 12:52 ` Rob Herring
@ 2018-03-29 14:46 ` Daniel Schultz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Schultz @ 2018-03-29 14:46 UTC (permalink / raw)
To: Rob Herring; +Cc: mark.rutland, heiko, w.egorov, devicetree, linux-kernel
Hi Rob,
On 03/18/2018 01:52 PM, Rob Herring wrote:
> On Thu, Mar 15, 2018 at 11:58:50AM +0100, Daniel Schultz wrote:
>> Add documentation about a new rk808 devicetree property, which can
>> enable resets by the PMIC.
>
> The subject needs to be more specific that this is for Rockchip PMIC.
>
>>
>> Signed-off-by: Daniel Schultz <d.schultz@phytec.de>
>> ---
>> Documentation/devicetree/bindings/mfd/rk808.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/rk808.txt b/Documentation/devicetree/bindings/mfd/rk808.txt
>> index 91b6522..fa1a30f 100644
>> --- a/Documentation/devicetree/bindings/mfd/rk808.txt
>> +++ b/Documentation/devicetree/bindings/mfd/rk808.txt
>> @@ -20,6 +20,8 @@ Optional properties:
>> default output clock name
>> - rockchip,system-power-controller: Telling whether or not this pmic is controlling
>> the system power.
>> +- rockchip,system-reset-controller: Telling whether or not this pmic is controlling
>> + the system reset.
>
> Would you ever really have power and reset controlled by different
> things? IOW, why do we need 2 properties?
>
The existing property enables the shutdown function and since the
preferred way for resetting the system is the soft reset (control and
reset module), rockchip wishes to have an extra property.
--
Mit freundlichen Grüßen,
With best regards,
Daniel Schultz
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-03-29 14:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 10:58 [PATCH] mfd: dt-bindings: Add PMIC reset property Daniel Schultz
2018-03-18 12:52 ` Rob Herring
2018-03-29 14:46 ` Daniel Schultz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.