All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH 0/2] Fix boot in some am335x sk boards
@ 2018-03-15 15:41 Faiz Abbas
  2018-03-15 15:41 ` [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag Faiz Abbas
  2018-03-15 15:41 ` [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices Faiz Abbas
  0 siblings, 2 replies; 7+ messages in thread
From: Faiz Abbas @ 2018-03-15 15:41 UTC (permalink / raw)
  To: u-boot

am335x standard kit boards with rev >= 1.2A require
gpio support to enable DDR in SPL.
This was failing because gpio drivers were not getting
bound to the gpio devices in SPL.

These patches fix this issue.

Faiz Abbas (2):
  gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag
  configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate
    gpio_devices

 configs/am335x_evm_defconfig    | 1 +
 configs/am335x_hs_evm_defconfig | 1 +
 drivers/gpio/omap_gpio.c        | 1 +
 3 files changed, 3 insertions(+)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag
  2018-03-15 15:41 [U-Boot] [PATCH 0/2] Fix boot in some am335x sk boards Faiz Abbas
@ 2018-03-15 15:41 ` Faiz Abbas
  2018-03-15 17:58   ` Tom Rini
  2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini
  2018-03-15 15:41 ` [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices Faiz Abbas
  1 sibling, 2 replies; 7+ messages in thread
From: Faiz Abbas @ 2018-03-15 15:41 UTC (permalink / raw)
  To: u-boot

With DM enabled in SPL, DM_FLAG_PRE_RELOC is required for
the omap_gpio driver to be bound to the gpio devices.

Therefore, add DM_FLAG_PRE_RELOC flag to the omap_gpio driver.

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
 drivers/gpio/omap_gpio.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpio/omap_gpio.c b/drivers/gpio/omap_gpio.c
index 7243100..559f29b 100644
--- a/drivers/gpio/omap_gpio.c
+++ b/drivers/gpio/omap_gpio.c
@@ -345,6 +345,7 @@ U_BOOT_DRIVER(gpio_omap) = {
 	.bind	= omap_gpio_bind,
 	.probe	= omap_gpio_probe,
 	.priv_auto_alloc_size = sizeof(struct gpio_bank),
+	.flags = DM_FLAG_PRE_RELOC,
 };
 
 #endif /* CONFIG_DM_GPIO */
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices
  2018-03-15 15:41 [U-Boot] [PATCH 0/2] Fix boot in some am335x sk boards Faiz Abbas
  2018-03-15 15:41 ` [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag Faiz Abbas
@ 2018-03-15 15:41 ` Faiz Abbas
  2018-03-15 17:58   ` Tom Rini
  2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 2 replies; 7+ messages in thread
From: Faiz Abbas @ 2018-03-15 15:41 UTC (permalink / raw)
  To: u-boot

With gpio devices getting created in SPL, the size of the heap is
no longer sufficient. Therefore, increase SPL_SYS_MALLOC_F_LEN
to 0x1000.

Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
 configs/am335x_evm_defconfig    | 1 +
 configs/am335x_hs_evm_defconfig | 1 +
 2 files changed, 2 insertions(+)

diff --git a/configs/am335x_evm_defconfig b/configs/am335x_evm_defconfig
index 60120bf..d1c78fa 100644
--- a/configs/am335x_evm_defconfig
+++ b/configs/am335x_evm_defconfig
@@ -4,6 +4,7 @@ CONFIG_TI_COMMON_CMD_OPTIONS=y
 CONFIG_AM33XX=y
 CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
 CONFIG_DISTRO_DEFAULTS=y
+CONFIG_SPL_SYS_MALLOC_F_LEN=0x1000
 CONFIG_SPL_LOAD_FIT=y
 CONFIG_BOOTCOMMAND="if test ${boot_fit} -eq 1; then run update_to_fit; fi; run findfdt; run init_console; run envboot; run distro_bootcmd"
 CONFIG_SYS_CONSOLE_INFO_QUIET=y
diff --git a/configs/am335x_hs_evm_defconfig b/configs/am335x_hs_evm_defconfig
index c903cc7..a8ab3e6 100644
--- a/configs/am335x_hs_evm_defconfig
+++ b/configs/am335x_hs_evm_defconfig
@@ -9,6 +9,7 @@ CONFIG_ISW_ENTRY_ADDR=0x40300350
 # CONFIG_SPL_NAND_SUPPORT is not set
 CONFIG_DEFAULT_DEVICE_TREE="am335x-evm"
 CONFIG_DISTRO_DEFAULTS=y
+CONFIG_SPL_SYS_MALLOC_F_LEN=0x1000
 CONFIG_ANDROID_BOOT_IMAGE=y
 CONFIG_FIT_IMAGE_POST_PROCESS=y
 CONFIG_SPL_LOAD_FIT=y
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag
  2018-03-15 15:41 ` [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag Faiz Abbas
@ 2018-03-15 17:58   ` Tom Rini
  2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-03-15 17:58 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 15, 2018 at 09:11:34PM +0530, Faiz Abbas wrote:

> With DM enabled in SPL, DM_FLAG_PRE_RELOC is required for
> the omap_gpio driver to be bound to the gpio devices.
> 
> Therefore, add DM_FLAG_PRE_RELOC flag to the omap_gpio driver.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180315/058df7f6/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices
  2018-03-15 15:41 ` [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices Faiz Abbas
@ 2018-03-15 17:58   ` Tom Rini
  2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-03-15 17:58 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 15, 2018 at 09:11:35PM +0530, Faiz Abbas wrote:

> With gpio devices getting created in SPL, the size of the heap is
> no longer sufficient. Therefore, increase SPL_SYS_MALLOC_F_LEN
> to 0x1000.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>

Reviewed-by: Tom Rini <trini@konsulko.com>

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180315/1c1118cd/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [U-Boot, 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag
  2018-03-15 15:41 ` [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag Faiz Abbas
  2018-03-15 17:58   ` Tom Rini
@ 2018-03-22 20:35   ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-03-22 20:35 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 15, 2018 at 09:11:34PM +0530, Faiz Abbas wrote:

> With DM enabled in SPL, DM_FLAG_PRE_RELOC is required for
> the omap_gpio driver to be bound to the gpio devices.
> 
> Therefore, add DM_FLAG_PRE_RELOC flag to the omap_gpio driver.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180322/4886aef5/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [U-Boot] [U-Boot, 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices
  2018-03-15 15:41 ` [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices Faiz Abbas
  2018-03-15 17:58   ` Tom Rini
@ 2018-03-22 20:35   ` Tom Rini
  1 sibling, 0 replies; 7+ messages in thread
From: Tom Rini @ 2018-03-22 20:35 UTC (permalink / raw)
  To: u-boot

On Thu, Mar 15, 2018 at 09:11:35PM +0530, Faiz Abbas wrote:

> With gpio devices getting created in SPL, the size of the heap is
> no longer sufficient. Therefore, increase SPL_SYS_MALLOC_F_LEN
> to 0x1000.
> 
> Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> Reviewed-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180322/ec39f2f5/attachment.sig>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2018-03-22 20:35 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 15:41 [U-Boot] [PATCH 0/2] Fix boot in some am335x sk boards Faiz Abbas
2018-03-15 15:41 ` [U-Boot] [PATCH 1/2] gpio: omap_gpio: Add DM_FLAG_PRE_RELOC flag Faiz Abbas
2018-03-15 17:58   ` Tom Rini
2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini
2018-03-15 15:41 ` [U-Boot] [PATCH 2/2] configs: am335x_evm: Increase SPL_SYS_MALLOC_F_LEN to accomodate gpio_devices Faiz Abbas
2018-03-15 17:58   ` Tom Rini
2018-03-22 20:35   ` [U-Boot] [U-Boot, " Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.