* [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config
@ 2018-03-15 18:13 ` David Lechner
0 siblings, 0 replies; 4+ messages in thread
From: David Lechner @ 2018-03-15 18:13 UTC (permalink / raw)
To: linux-arm-kernel
Cc: David Lechner, Sekhar Nori, Kevin Hilman, Bartosz Golaszewski,
linux-kernel
Since commit 8253bb3f8255 ("regmap: potentially duplicate the name
string stored in regmap"), the name field of struct regmap_config
is copied in __regmap_init(), so we no longer need to worry about
keeping our own copy of the name.
Just use a string literal in the initialization of da8xx_cfgchip_config
instead of creating a separate variable for the name.
Signed-off-by: David Lechner <david@lechnology.com>
---
arch/arm/mach-davinci/devices-da8xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c
index 273b6c2..1fd3619 100644
--- a/arch/arm/mach-davinci/devices-da8xx.c
+++ b/arch/arm/mach-davinci/devices-da8xx.c
@@ -1095,11 +1095,8 @@ int __init da850_register_sata(unsigned long refclkpn)
static struct regmap *da8xx_cfgchip;
-/* regmap doesn't make a copy of this, so we need to keep the pointer around */
-static const char da8xx_cfgchip_name[] = "cfgchip";
-
static const struct regmap_config da8xx_cfgchip_config __initconst = {
- .name = da8xx_cfgchip_name,
+ .name = "cfgchip",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config
@ 2018-03-15 18:13 ` David Lechner
0 siblings, 0 replies; 4+ messages in thread
From: David Lechner @ 2018-03-15 18:13 UTC (permalink / raw)
To: linux-arm-kernel
Since commit 8253bb3f8255 ("regmap: potentially duplicate the name
string stored in regmap"), the name field of struct regmap_config
is copied in __regmap_init(), so we no longer need to worry about
keeping our own copy of the name.
Just use a string literal in the initialization of da8xx_cfgchip_config
instead of creating a separate variable for the name.
Signed-off-by: David Lechner <david@lechnology.com>
---
arch/arm/mach-davinci/devices-da8xx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/arch/arm/mach-davinci/devices-da8xx.c b/arch/arm/mach-davinci/devices-da8xx.c
index 273b6c2..1fd3619 100644
--- a/arch/arm/mach-davinci/devices-da8xx.c
+++ b/arch/arm/mach-davinci/devices-da8xx.c
@@ -1095,11 +1095,8 @@ int __init da850_register_sata(unsigned long refclkpn)
static struct regmap *da8xx_cfgchip;
-/* regmap doesn't make a copy of this, so we need to keep the pointer around */
-static const char da8xx_cfgchip_name[] = "cfgchip";
-
static const struct regmap_config da8xx_cfgchip_config __initconst = {
- .name = da8xx_cfgchip_name,
+ .name = "cfgchip",
.reg_bits = 32,
.val_bits = 32,
.reg_stride = 4,
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config
2018-03-15 18:13 ` David Lechner
@ 2018-03-16 10:33 ` Sekhar Nori
-1 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2018-03-16 10:33 UTC (permalink / raw)
To: David Lechner, linux-arm-kernel
Cc: Kevin Hilman, Bartosz Golaszewski, linux-kernel
On Thursday 15 March 2018 11:43 PM, David Lechner wrote:
> Since commit 8253bb3f8255 ("regmap: potentially duplicate the name
> string stored in regmap"), the name field of struct regmap_config
> is copied in __regmap_init(), so we no longer need to worry about
> keeping our own copy of the name.
>
> Just use a string literal in the initialization of da8xx_cfgchip_config
> instead of creating a separate variable for the name.
>
> Signed-off-by: David Lechner <david@lechnology.com>
Applied to v4.17/soc of my tree.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config
@ 2018-03-16 10:33 ` Sekhar Nori
0 siblings, 0 replies; 4+ messages in thread
From: Sekhar Nori @ 2018-03-16 10:33 UTC (permalink / raw)
To: linux-arm-kernel
On Thursday 15 March 2018 11:43 PM, David Lechner wrote:
> Since commit 8253bb3f8255 ("regmap: potentially duplicate the name
> string stored in regmap"), the name field of struct regmap_config
> is copied in __regmap_init(), so we no longer need to worry about
> keeping our own copy of the name.
>
> Just use a string literal in the initialization of da8xx_cfgchip_config
> instead of creating a separate variable for the name.
>
> Signed-off-by: David Lechner <david@lechnology.com>
Applied to v4.17/soc of my tree.
Thanks,
Sekhar
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-03-16 10:34 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-15 18:13 [PATCH] ARM: davinci: DA8XX: simplify CFGCHIP regmap_config David Lechner
2018-03-15 18:13 ` David Lechner
2018-03-16 10:33 ` Sekhar Nori
2018-03-16 10:33 ` Sekhar Nori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.