USB: misc: uss720: more vendor/product ID's

USB: misc: uss720: more vendor/product ID's

[Daniel Gimpelevich]

On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote:
> Put the device "type" or "name" as a comment, that makes more sense
> and
> follows what almost all other drivers do.

I strongly considered this, but I ultimately decided against it in
consideration of the limited space for comments on the right, the lack
of such device identification extant in this driver, and the presence of
most or all of the listed devices in the usb.ids file.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Greg KH]

On Tue, Mar 20, 2018 at 02:23:54AM -0700, Daniel Gimpelevich wrote:
> On Tue, 2018-03-20 at 10:21 +0100, Greg KH wrote:
> > On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote:
> > > On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote:
> > > > Put the device "type" or "name" as a comment, that makes more sense
> > > > and
> > > > follows what almost all other drivers do.
> > > 
> > > I strongly considered this, but I ultimately decided against it in
> > > consideration of the limited space for comments on the right, the lack
> > > of such device identification extant in this driver, and the presence of
> > > most or all of the listed devices in the usb.ids file.
> > 
> > There is no usb.ids file anymore :)
> 
> The "update-usbids" command still downloads
> http://www.linux-usb.org/usb.ids for me.

Yes, but udev builds it into the hardware id database now directly, and
I doubt any other tool relies on it anymore.  'lsusb' hasn't for quite
some time.

Anyway, pointless digression, can you please fix up the patch to at the
least, take out the people's names from the comments in the code and
resend it so that it can be applied.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Daniel Gimpelevich]

On Tue, 2018-03-20 at 10:21 +0100, Greg KH wrote:
> On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote:
> > On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote:
> > > Put the device "type" or "name" as a comment, that makes more sense
> > > and
> > > follows what almost all other drivers do.
> > 
> > I strongly considered this, but I ultimately decided against it in
> > consideration of the limited space for comments on the right, the lack
> > of such device identification extant in this driver, and the presence of
> > most or all of the listed devices in the usb.ids file.
> 
> There is no usb.ids file anymore :)

The "update-usbids" command still downloads
http://www.linux-usb.org/usb.ids for me.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Greg KH]

On Tue, Mar 20, 2018 at 02:13:48AM -0700, Daniel Gimpelevich wrote:
> On Tue, 2018-03-20 at 10:08 +0100, Greg KH wrote:
> > Put the device "type" or "name" as a comment, that makes more sense
> > and
> > follows what almost all other drivers do.
> 
> I strongly considered this, but I ultimately decided against it in
> consideration of the limited space for comments on the right, the lack
> of such device identification extant in this driver, and the presence of
> most or all of the listed devices in the usb.ids file.

There is no usb.ids file anymore :)
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Greg KH]

On Tue, Mar 20, 2018 at 02:03:46AM -0700, Daniel Gimpelevich wrote:
> On Tue, 2018-03-20 at 09:36 +0100, Greg KH wrote:
> > Who is "Rab" and why do you need to name who added what id to the
> > patch?
> > 
> I copied that part from the web page I referenced in the commit message.
> It's evidently a reference to the page's author. I tried to send an
> e-mail to the address at the bottom of the page, with no response. I
> also CC'ed from git send-email.
> > 
> > What is more useful is a description of the device types, not who
> > added
> > the new id, can you do that instead?
> 
> For the "Rab" devices, there is a wealth of such information on the
> aforementioned web page. I added the info for the ones I have into the
> commit message.
> 
> > It doesn't say that Fabio added this one below, are you sure?
> 
> It says that in the commit that added it:
> https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/uss720.c?id=ecc1624a2fff45780959efbcb73ace18fdb3c58d

Ok, but that isn't needed in the comments of the code.

Put the device "type" or "name" as a comment, that makes more sense and
follows what almost all other drivers do.

> > Always use scripts/get_maintainer.pl to figure out who to cc: on the
> > patches, otherwise the maintainer might miss it :(
> 
> Hmm, I simply looked in the MAINTAINERS file instead, which has no entry
> for this driver.

If there is no default, it falls back to the maintainer(s) of the
subsystem, which get_maintainer.pl knows how to handle.

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Daniel Gimpelevich]

On Tue, 2018-03-20 at 09:36 +0100, Greg KH wrote:
> Who is "Rab" and why do you need to name who added what id to the
> patch?
> 
I copied that part from the web page I referenced in the commit message.
It's evidently a reference to the page's author. I tried to send an
e-mail to the address at the bottom of the page, with no response. I
also CC'ed from git send-email.
> 
> What is more useful is a description of the device types, not who
> added
> the new id, can you do that instead?

For the "Rab" devices, there is a wealth of such information on the
aforementioned web page. I added the info for the ones I have into the
commit message.

> It doesn't say that Fabio added this one below, are you sure?

It says that in the commit that added it:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/commit/drivers/usb/misc/uss720.c?id=ecc1624a2fff45780959efbcb73ace18fdb3c58d

> Always use scripts/get_maintainer.pl to figure out who to cc: on the
> patches, otherwise the maintainer might miss it :(

Hmm, I simply looked in the MAINTAINERS file instead, which has no entry
for this driver.
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Greg KH]

On Wed, Mar 14, 2018 at 03:20:04PM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
> 
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
> 
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
> Cc: stable <stable@vger.kernel.org>
> ---
>  drivers/usb/misc/uss720.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
> index 263c97f..a208e4b 100644
> --- a/drivers/usb/misc/uss720.c
> +++ b/drivers/usb/misc/uss720.c
> @@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
>  /* table of cables that work through this driver */
>  static const struct usb_device_id uss720_table[] = {
>  	{ USB_DEVICE(0x047e, 0x1001) },
> +	{ USB_DEVICE(0x04b8, 0x0002) },			/* Daniel Gimpelevich */
> +	{ USB_DEVICE(0x04b8, 0x0003) },			/* Added by Rab */

Who is "Rab" and why do you need to name who added what id to the patch?

> +	{ USB_DEVICE(0x050d, 0x0002) },			/* Fabio Battaglia */

It doesn't say that Fabio added this one below, are you sure?

> +	{ USB_DEVICE(0x050d, 0x1202) },			/* Added by Rab */
>  	{ USB_DEVICE(0x0557, 0x2001) },
> +	{ USB_DEVICE(0x05ab, 0x0002) },                 /* Daniel Gimpelevich */
> +	{ USB_DEVICE(0x06c6, 0x0100) },			/* Added by Rab */
>  	{ USB_DEVICE(0x0729, 0x1284) },
>  	{ USB_DEVICE(0x1293, 0x0002) },
> -	{ USB_DEVICE(0x050d, 0x0002) },

What is more useful is a description of the device types, not who added
the new id, can you do that instead?

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Greg Kroah-Hartman]

On Wed, Mar 14, 2018 at 03:20:04PM -0700, Daniel Gimpelevich wrote:
> Reporting two more VID/PID pairs that work with this driver, having used
> an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
> guide now. The page listed additional working VID/PID pairs but did not
> include these two. None were upstreamed. Also taking this opportunity to
> sort the pairs numerically.
> 
> Of the two such cables now in my possession, one is white, bearing the
> In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
> "USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
> and the other is black, bearing the In-System Design ISD-101 label on one
> side, sold as an early Belkin F5U002 (05ab:0002).
> 
> Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>

Always use scripts/get_maintainer.pl to figure out who to cc: on the
patches, otherwise the maintainer might miss it :(

thanks,

greg k-h
---
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

USB: misc: uss720: more vendor/product ID's

[Daniel Gimpelevich]

Reporting two more VID/PID pairs that work with this driver, having used
an informational webpage <http://reboots.g-cipher.net/lcd/> as a buying
guide now. The page listed additional working VID/PID pairs but did not
include these two. None were upstreamed. Also taking this opportunity to
sort the pairs numerically.

Of the two such cables now in my possession, one is white, bearing the
In-System Design ISD-103 label on one side, sold as an Epson CAEUL0002
"USB to Parallel Smart Cable For Apple Macintosh Computers" (04b8:0002),
and the other is black, bearing the In-System Design ISD-101 label on one
side, sold as an early Belkin F5U002 (05ab:0002).

Signed-off-by: Daniel Gimpelevich <daniel@gimpelevich.san-francisco.ca.us>
---
 drivers/usb/misc/uss720.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/misc/uss720.c b/drivers/usb/misc/uss720.c
index 263c97f..a208e4b 100644
--- a/drivers/usb/misc/uss720.c
+++ b/drivers/usb/misc/uss720.c
@@ -769,10 +769,15 @@ static void uss720_disconnect(struct usb_interface *intf)
 /* table of cables that work through this driver */
 static const struct usb_device_id uss720_table[] = {
 	{ USB_DEVICE(0x047e, 0x1001) },
+	{ USB_DEVICE(0x04b8, 0x0002) },			/* Daniel Gimpelevich */
+	{ USB_DEVICE(0x04b8, 0x0003) },			/* Added by Rab */
+	{ USB_DEVICE(0x050d, 0x0002) },			/* Fabio Battaglia */
+	{ USB_DEVICE(0x050d, 0x1202) },			/* Added by Rab */
 	{ USB_DEVICE(0x0557, 0x2001) },
+	{ USB_DEVICE(0x05ab, 0x0002) },                 /* Daniel Gimpelevich */
+	{ USB_DEVICE(0x06c6, 0x0100) },			/* Added by Rab */
 	{ USB_DEVICE(0x0729, 0x1284) },
 	{ USB_DEVICE(0x1293, 0x0002) },
-	{ USB_DEVICE(0x050d, 0x0002) },
 	{ }						/* Terminating entry */
 };