All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] net/e1000: fix flow RSS queue index error
@ 2018-03-21  7:18 Wei Zhao
  2018-03-26  1:37 ` Lu, Wenzhuo
  0 siblings, 1 reply; 3+ messages in thread
From: Wei Zhao @ 2018-03-21  7:18 UTC (permalink / raw)
  To: dev; +Cc: wenzhuo.lu, Wei Zhao

Igb has a bug about queue index for rss rule flow
configuration when set redirection table.

Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Tested-by: Peng Yuan <yuan.peng@intel.com>
---
 drivers/net/e1000/igb_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c
index 2f37167..009f0ea 100644
--- a/drivers/net/e1000/igb_rxtx.c
+++ b/drivers/net/e1000/igb_rxtx.c
@@ -2794,9 +2794,9 @@ igb_config_rss_filter(struct rte_eth_dev *dev,
 		} reta;
 		uint8_t q_idx;
 
-		q_idx = conf->queue[j];
 		if (j == conf->num)
 			j = 0;
+		q_idx = conf->queue[j];
 		reta.bytes[i & 3] = (uint8_t)(q_idx << shift);
 		if ((i & 3) == 3)
 			E1000_WRITE_REG(hw, E1000_RETA(i >> 2), reta.dword);
-- 
2.7.5

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/e1000: fix flow RSS queue index error
  2018-03-21  7:18 [PATCH] net/e1000: fix flow RSS queue index error Wei Zhao
@ 2018-03-26  1:37 ` Lu, Wenzhuo
  2018-03-27 16:00   ` Zhang, Helin
  0 siblings, 1 reply; 3+ messages in thread
From: Lu, Wenzhuo @ 2018-03-26  1:37 UTC (permalink / raw)
  To: Zhao1, Wei, dev

Hi,

> -----Original Message-----
> From: Zhao1, Wei
> Sent: Wednesday, March 21, 2018 3:18 PM
> To: dev@dpdk.org
> Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: [PATCH] net/e1000: fix flow RSS queue index error
> 
> Igb has a bug about queue index for rss rule flow configuration when set
> redirection table.
> 
> Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> Tested-by: Peng Yuan <yuan.peng@intel.com>
Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net/e1000: fix flow RSS queue index error
  2018-03-26  1:37 ` Lu, Wenzhuo
@ 2018-03-27 16:00   ` Zhang, Helin
  0 siblings, 0 replies; 3+ messages in thread
From: Zhang, Helin @ 2018-03-27 16:00 UTC (permalink / raw)
  To: Lu, Wenzhuo, Zhao1, Wei, dev



> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo
> Sent: Monday, March 26, 2018 9:37 AM
> To: Zhao1, Wei; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix flow RSS queue index error
> 
> Hi,
> 
> > -----Original Message-----
> > From: Zhao1, Wei
> > Sent: Wednesday, March 21, 2018 3:18 PM
> > To: dev@dpdk.org
> > Cc: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Zhao1, Wei
> > <wei.zhao1@intel.com>
> > Subject: [PATCH] net/e1000: fix flow RSS queue index error
> >
> > Igb has a bug about queue index for rss rule flow configuration when
> > set redirection table.
> >
> > Fixes: 424ae915baf0 ("net/e1000: move RSS to flow API")
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Tested-by: Peng Yuan <yuan.peng@intel.com>
> Acked-by: Wenzhuo Lu <wenzhuo.lu@intel.com>
Applied to dpdk-next-net-intel, thanks!

/Helin

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-03-27 16:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-21  7:18 [PATCH] net/e1000: fix flow RSS queue index error Wei Zhao
2018-03-26  1:37 ` Lu, Wenzhuo
2018-03-27 16:00   ` Zhang, Helin

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.