* [Fuego] dbench update
@ 2018-03-23 7:21 Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 1/7] dbench: move asserts to pre_check Daniel Sangorrin
` (6 more replies)
0 siblings, 7 replies; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Hi Tim,
I noticed that dbench 3.04 was giving performance results that
looked too high compared to dbench 4.00, the latest version.
I have updated the whole test to use dbench 4.00 for that reason.
Dbench 4.0 has a somewhat tricky build dependency: libpopt-dev.
Since the emdebian toolchain is currently broken on Fuego I
wasn't able to test this on ARM, only on x86_64.
I have added some logic for the test to detect whether the
dbench binary is installed on the target or not and skip
the build in case it is. Probably, we need to do the same for all
tests so it would be nice to have a more generic interface
in the future.
[PATCH 1/7] dbench: move asserts to pre_check
[PATCH 2/7] dbench: update fuego_test for version 4.00
[PATCH 3/7] dbench: update parser including max_latency
[PATCH 4/7] dbench: add yaml file
[PATCH 5/7] dbench: remove testdir spec
[PATCH 6/7] dbench: increase test duration
[PATCH 7/7] dbench: add spec using synchronized writes
There is one more patch on my repository with the new tarball.
Thanks,
Daniel
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 1/7] dbench: move asserts to pre_check
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-26 23:11 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 2/7] dbench: update fuego_test for version 4.00 Daniel Sangorrin
` (5 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/fuego_test.sh | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/engine/tests/Benchmark.dbench/fuego_test.sh b/engine/tests/Benchmark.dbench/fuego_test.sh
index f7160f9..431b682 100755
--- a/engine/tests/Benchmark.dbench/fuego_test.sh
+++ b/engine/tests/Benchmark.dbench/fuego_test.sh
@@ -1,5 +1,12 @@
tarball=dbench-3.04.tar.gz
+function test_pre_check {
+ assert_define BENCHMARK_DBENCH_MOUNT_BLOCKDEV
+ assert_define BENCHMARK_DBENCH_MOUNT_POINT
+ assert_define BENCHMARK_DBENCH_TIMELIMIT
+ assert_define BENCHMARK_DBENCH_NPROCS
+}
+
function test_build {
patch -N -s -p1 < $TEST_HOME/dbench_startup.patch
./configure --host=$HOST --build=`uname -m`-linux-gnu CFLAGS="$CFLAGS";
@@ -11,11 +18,6 @@ function test_deploy {
}
function test_run {
- assert_define BENCHMARK_DBENCH_MOUNT_BLOCKDEV
- assert_define BENCHMARK_DBENCH_MOUNT_POINT
- assert_define BENCHMARK_DBENCH_TIMELIMIT
- assert_define BENCHMARK_DBENCH_NPROCS
-
hd_test_mount_prepare $BENCHMARK_DBENCH_MOUNT_BLOCKDEV $BENCHMARK_DBENCH_MOUNT_POINT
report "cd $BOARD_TESTDIR/fuego.$TESTDIR; cp client.txt $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR; pwd; ./dbench -t $BENCHMARK_DBENCH_TIMELIMIT -D $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -c $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt $BENCHMARK_DBENCH_NPROCS; rm $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt"
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 2/7] dbench: update fuego_test for version 4.00
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 1/7] dbench: move asserts to pre_check Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 3/7] dbench: update parser including max_latency Daniel Sangorrin
` (4 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
The script detects if dbench is installed on the target, and
otherwise tries to build it. The reason to use this approach
is that dbench has a somewhat tricky build/runtime dependency
on libpopt.
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/fuego_test.sh | 32 ++++++++++++++++++-----------
1 file changed, 20 insertions(+), 12 deletions(-)
diff --git a/engine/tests/Benchmark.dbench/fuego_test.sh b/engine/tests/Benchmark.dbench/fuego_test.sh
index 431b682..30c7cf2 100755
--- a/engine/tests/Benchmark.dbench/fuego_test.sh
+++ b/engine/tests/Benchmark.dbench/fuego_test.sh
@@ -1,30 +1,38 @@
-tarball=dbench-3.04.tar.gz
+# gitrepo=https://git.samba.org/sahlberg/dbench.git
+tarball=dbench-4.00.tar.gz
function test_pre_check {
assert_define BENCHMARK_DBENCH_MOUNT_BLOCKDEV
assert_define BENCHMARK_DBENCH_MOUNT_POINT
assert_define BENCHMARK_DBENCH_TIMELIMIT
assert_define BENCHMARK_DBENCH_NPROCS
+ is_on_target_path dbench PROGRAM_DBENCH
}
function test_build {
- patch -N -s -p1 < $TEST_HOME/dbench_startup.patch
- ./configure --host=$HOST --build=`uname -m`-linux-gnu CFLAGS="$CFLAGS";
- make
+ if [ -z "$PROGRAM_DBENCH" ]; then
+ echo "Building dbench, make sure you have libpopt-dev dependencies"
+ ./autogen.sh
+ ./configure --host=$HOST --build=`uname -m`-linux-gnu CFLAGS="$CFLAGS";
+ make
+ else
+ echo "Skipping build phase, dbench is already on the target"
+ fi
}
function test_deploy {
- put dbench client.txt $BOARD_TESTDIR/fuego.$TESTDIR/
+ if [ -z "$PROGRAM_DBENCH" ]; then
+ put dbench loadfiles/client.txt $BOARD_TESTDIR/fuego.$TESTDIR/
+ fi
}
function test_run {
hd_test_mount_prepare $BENCHMARK_DBENCH_MOUNT_BLOCKDEV $BENCHMARK_DBENCH_MOUNT_POINT
-
- report "cd $BOARD_TESTDIR/fuego.$TESTDIR; cp client.txt $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR; pwd; ./dbench -t $BENCHMARK_DBENCH_TIMELIMIT -D $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -c $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt $BENCHMARK_DBENCH_NPROCS; rm $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt"
-
- sleep 5
-
+ if [ -z "$PROGRAM_DBENCH" ]; then
+ #report "cd $BOARD_TESTDIR/fuego.$TESTDIR; cp client.txt $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR; pwd; ./dbench -t $BENCHMARK_DBENCH_TIMELIMIT -D $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -c $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt $BENCHMARK_DBENCH_NPROCS; rm $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt"
+ report "cd $BOARD_TESTDIR/fuego.$TESTDIR; ./dbench -c ./client.txt -D $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -t $BENCHMARK_DBENCH_TIMELIMIT $BENCHMARK_DBENCH_EXTRAPARAMS $BENCHMARK_DBENCH_NPROCS"
+ else
+ report "cd $BOARD_TESTDIR/fuego.$TESTDIR; dbench -D $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -t $BENCHMARK_DBENCH_TIMELIMIT $BENCHMARK_DBENCH_EXTRAPARAMS $BENCHMARK_DBENCH_NPROCS"
+ fi
hd_test_clean_umount $BENCHMARK_DBENCH_MOUNT_BLOCKDEV $BENCHMARK_DBENCH_MOUNT_POINT
}
-
-
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 3/7] dbench: update parser including max_latency
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 1/7] dbench: move asserts to pre_check Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 2/7] dbench: update fuego_test for version 4.00 Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 4/7] dbench: add yaml file Daniel Sangorrin
` (3 subsequent siblings)
6 siblings, 0 replies; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Dbench 4.00 has more detailed results including the disk latency.
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/parser.py | 7 +++++--
engine/tests/Benchmark.dbench/reference.json | 4 ++++
2 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/engine/tests/Benchmark.dbench/parser.py b/engine/tests/Benchmark.dbench/parser.py
index b664936..f0c32bd 100755
--- a/engine/tests/Benchmark.dbench/parser.py
+++ b/engine/tests/Benchmark.dbench/parser.py
@@ -8,10 +8,13 @@ import common as plib
measurements = {}
-regex_string = '^(Throughput)(.*)(MB/sec)(.*)(procs)$'
+regex_string = '^Throughput (\d+\.\d+) MB/sec .* max_latency=(\d+\.\d+) ms$'
matches = plib.parse_log(regex_string)
if matches:
- measurements['default.dbench'] = [{"name": "Throughput", "measure" : float(matches[0][1])}]
+ measurements['default.dbench'] = [
+ {"name": "Throughput", "measure" : float(matches[0][0])},
+ {"name": "Max_Latency", "measure" : float(matches[0][1])}
+ ]
sys.exit(plib.process(measurements))
diff --git a/engine/tests/Benchmark.dbench/reference.json b/engine/tests/Benchmark.dbench/reference.json
index f08c750..4a10c86 100644
--- a/engine/tests/Benchmark.dbench/reference.json
+++ b/engine/tests/Benchmark.dbench/reference.json
@@ -7,6 +7,10 @@
"name":"dbench",
"measurements":[
{
+ "name":"Max_Latency",
+ "unit":"ms"
+ },
+ {
"name":"Throughput",
"unit":"MB/s"
}
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 4/7] dbench: add yaml file
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
` (2 preceding siblings ...)
2018-03-23 7:21 ` [Fuego] [PATCH 3/7] dbench: update parser including max_latency Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-26 23:19 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 5/7] dbench: remove testdir spec Daniel Sangorrin
` (2 subsequent siblings)
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/test.yaml | 57 +++++++++++++++++++++++++++++++++
1 file changed, 57 insertions(+)
create mode 100644 engine/tests/Benchmark.dbench/test.yaml
diff --git a/engine/tests/Benchmark.dbench/test.yaml b/engine/tests/Benchmark.dbench/test.yaml
new file mode 100644
index 0000000..1b425ac
--- /dev/null
+++ b/engine/tests/Benchmark.dbench/test.yaml
@@ -0,0 +1,57 @@
+fuego_package_version: 1
+name: Benchmark.dbench
+description: |
+ Measure disk throughput for simulated netbench run.
+license: GPL-3.0
+author: Andrew Tridgell, Ronnie Sahlberg
+maintainer: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
+version: 4.00
+fuego_release: 1
+type: Benchmark
+tags: ['disk', 'storage', 'performance']
+tarball_src: https://www.samba.org/ftp/tridge/dbench/dbench-4.0.tar.gz
+gitrepo: https://git.samba.org/sahlberg/dbench.git
+params:
+ - MOUNT_BLOCKDEV:
+ description: Storage device to be tested.
+ example: /dev/sdb1
+ optional: no
+ - MOUNT_POINT:
+ description: Mount point for the storage device
+ example: /mnt/
+ optional: no
+ - TIMELIMIT:
+ description: Test duration in seconds including warmup time.
+ example: 30
+ optional: no
+ - NPROCS:
+ description: Number of parallel threads.
+ example: 2
+ optional: no
+ - EXTRAPARAMS:
+ description: |
+ Additional parameters such as
+ -T, --tcp-options=STRING TCP socket options
+ -R, --target-rate=DOUBLE target throughput (MB/sec)
+ -s, --sync use O_SYNC
+ -S, --sync-dir sync directory changes
+ -F, --fsync fsync on write
+ -x, --xattr use xattrs
+ --no-resolve disable name resolution simulation
+ --clients-per-process=INT number of clients per process
+ --one-byte-write-fix try to fix 1 byte writes
+ --stat-check check for pointless calls with stat
+ --fake-io fake up read/write calls
+ --skip-cleanup skip cleanup operations
+ --per-client-results show results per client
+ example: -s -S -F
+ optional: yes
+data_files:
+ - chart_config.json
+ - criteria.json
+ - dbench-4.00.tar.gz
+ - fuego_test.sh
+ - parser.py
+ - reference.json
+ - spec.json
+ - test.yaml
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 5/7] dbench: remove testdir spec
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
` (3 preceding siblings ...)
2018-03-23 7:21 ` [Fuego] [PATCH 4/7] dbench: add yaml file Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-26 23:20 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 6/7] dbench: increase test duration Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes Daniel Sangorrin
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
This is already covered by the default spec
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/spec.json | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/engine/tests/Benchmark.dbench/spec.json b/engine/tests/Benchmark.dbench/spec.json
index 61dbfda..bf7d60d 100644
--- a/engine/tests/Benchmark.dbench/spec.json
+++ b/engine/tests/Benchmark.dbench/spec.json
@@ -1,6 +1,12 @@
{
"testName": "Benchmark.dbench",
"specs": {
+ "default": {
+ "MOUNT_BLOCKDEV":"ROOT",
+ "MOUNT_POINT":"$BOARD_TESTDIR/work",
+ "TIMELIMIT":"10",
+ "NPROCS":"2"
+ },
"sata": {
"MOUNT_BLOCKDEV":"$SATA_DEV",
"MOUNT_POINT":"$SATA_MP",
@@ -18,18 +24,6 @@
"MOUNT_POINT":"$USB_MP",
"TIMELIMIT":"10",
"NPROCS":"2"
- },
- "default": {
- "MOUNT_BLOCKDEV":"ROOT",
- "MOUNT_POINT":"/a",
- "TIMELIMIT":"10",
- "NPROCS":"2"
- },
- "testdir": {
- "MOUNT_BLOCKDEV":"ROOT",
- "MOUNT_POINT":"$BOARD_TESTDIR/work",
- "TIMELIMIT":"10",
- "NPROCS":"2"
}
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 6/7] dbench: increase test duration
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
` (4 preceding siblings ...)
2018-03-23 7:21 ` [Fuego] [PATCH 5/7] dbench: remove testdir spec Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-26 23:21 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes Daniel Sangorrin
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Add a bit more duration so that the test has more warmup time.
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/spec.json | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/engine/tests/Benchmark.dbench/spec.json b/engine/tests/Benchmark.dbench/spec.json
index bf7d60d..5c37d6a 100644
--- a/engine/tests/Benchmark.dbench/spec.json
+++ b/engine/tests/Benchmark.dbench/spec.json
@@ -4,25 +4,25 @@
"default": {
"MOUNT_BLOCKDEV":"ROOT",
"MOUNT_POINT":"$BOARD_TESTDIR/work",
- "TIMELIMIT":"10",
+ "TIMELIMIT":"30",
"NPROCS":"2"
},
"sata": {
"MOUNT_BLOCKDEV":"$SATA_DEV",
"MOUNT_POINT":"$SATA_MP",
- "TIMELIMIT":"10",
+ "TIMELIMIT":"30",
"NPROCS":"2"
},
"mmc": {
"MOUNT_BLOCKDEV":"$MMC_DEV",
"MOUNT_POINT":"$MMC_MP",
- "TIMELIMIT":"10",
+ "TIMELIMIT":"30",
"NPROCS":"2"
},
"usb": {
"MOUNT_BLOCKDEV":"$USB_DEV",
"MOUNT_POINT":"$USB_MP",
- "TIMELIMIT":"10",
+ "TIMELIMIT":"30",
"NPROCS":"2"
}
}
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
` (5 preceding siblings ...)
2018-03-23 7:21 ` [Fuego] [PATCH 6/7] dbench: increase test duration Daniel Sangorrin
@ 2018-03-23 7:21 ` Daniel Sangorrin
2018-03-26 23:22 ` Tim.Bird
6 siblings, 1 reply; 13+ messages in thread
From: Daniel Sangorrin @ 2018-03-23 7:21 UTC (permalink / raw)
To: fuego
Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
engine/tests/Benchmark.dbench/spec.json | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/engine/tests/Benchmark.dbench/spec.json b/engine/tests/Benchmark.dbench/spec.json
index 5c37d6a..c855f36 100644
--- a/engine/tests/Benchmark.dbench/spec.json
+++ b/engine/tests/Benchmark.dbench/spec.json
@@ -7,6 +7,13 @@
"TIMELIMIT":"30",
"NPROCS":"2"
},
+ "sync": {
+ "MOUNT_BLOCKDEV":"ROOT",
+ "MOUNT_POINT":"$BOARD_TESTDIR/work",
+ "TIMELIMIT":"30",
+ "NPROCS":"2",
+ "EXTRAPARAMS":"-s -S -F"
+ },
"sata": {
"MOUNT_BLOCKDEV":"$SATA_DEV",
"MOUNT_POINT":"$SATA_MP",
--
2.7.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 1/7] dbench: move asserts to pre_check
2018-03-23 7:21 ` [Fuego] [PATCH 1/7] dbench: move asserts to pre_check Daniel Sangorrin
@ 2018-03-26 23:11 ` Tim.Bird
0 siblings, 0 replies; 13+ messages in thread
From: Tim.Bird @ 2018-03-26 23:11 UTC (permalink / raw)
To: daniel.sangorrin, fuego
Applied - Thanks.
-- Tim
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 23, 2018 12:21 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 1/7] dbench: move asserts to pre_check
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
> engine/tests/Benchmark.dbench/fuego_test.sh | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
>
> diff --git a/engine/tests/Benchmark.dbench/fuego_test.sh
> b/engine/tests/Benchmark.dbench/fuego_test.sh
> index f7160f9..431b682 100755
> --- a/engine/tests/Benchmark.dbench/fuego_test.sh
> +++ b/engine/tests/Benchmark.dbench/fuego_test.sh
> @@ -1,5 +1,12 @@
> tarball=dbench-3.04.tar.gz
>
> +function test_pre_check {
> + assert_define BENCHMARK_DBENCH_MOUNT_BLOCKDEV
> + assert_define BENCHMARK_DBENCH_MOUNT_POINT
> + assert_define BENCHMARK_DBENCH_TIMELIMIT
> + assert_define BENCHMARK_DBENCH_NPROCS
> +}
> +
> function test_build {
> patch -N -s -p1 < $TEST_HOME/dbench_startup.patch
> ./configure --host=$HOST --build=`uname -m`-linux-gnu
> CFLAGS="$CFLAGS";
> @@ -11,11 +18,6 @@ function test_deploy {
> }
>
> function test_run {
> - assert_define BENCHMARK_DBENCH_MOUNT_BLOCKDEV
> - assert_define BENCHMARK_DBENCH_MOUNT_POINT
> - assert_define BENCHMARK_DBENCH_TIMELIMIT
> - assert_define BENCHMARK_DBENCH_NPROCS
> -
> hd_test_mount_prepare $BENCHMARK_DBENCH_MOUNT_BLOCKDEV
> $BENCHMARK_DBENCH_MOUNT_POINT
>
> report "cd $BOARD_TESTDIR/fuego.$TESTDIR; cp client.txt
> $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR; pwd; ./dbench -t
> $BENCHMARK_DBENCH_TIMELIMIT -D
> $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR -c
> $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt
> $BENCHMARK_DBENCH_NPROCS; rm
> $BENCHMARK_DBENCH_MOUNT_POINT/fuego.$TESTDIR/client.txt"
> --
> 2.7.4
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 4/7] dbench: add yaml file
2018-03-23 7:21 ` [Fuego] [PATCH 4/7] dbench: add yaml file Daniel Sangorrin
@ 2018-03-26 23:19 ` Tim.Bird
0 siblings, 0 replies; 13+ messages in thread
From: Tim.Bird @ 2018-03-26 23:19 UTC (permalink / raw)
To: daniel.sangorrin, fuego
Very thorough. I like the params description - very handy.
Applied.
-- Tim
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 23, 2018 12:21 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 4/7] dbench: add yaml file
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
> engine/tests/Benchmark.dbench/test.yaml | 57
> +++++++++++++++++++++++++++++++++
> 1 file changed, 57 insertions(+)
> create mode 100644 engine/tests/Benchmark.dbench/test.yaml
>
> diff --git a/engine/tests/Benchmark.dbench/test.yaml
> b/engine/tests/Benchmark.dbench/test.yaml
> new file mode 100644
> index 0000000..1b425ac
> --- /dev/null
> +++ b/engine/tests/Benchmark.dbench/test.yaml
> @@ -0,0 +1,57 @@
> +fuego_package_version: 1
> +name: Benchmark.dbench
> +description: |
> + Measure disk throughput for simulated netbench run.
> +license: GPL-3.0
> +author: Andrew Tridgell, Ronnie Sahlberg
> +maintainer: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> +version: 4.00
> +fuego_release: 1
> +type: Benchmark
> +tags: ['disk', 'storage', 'performance']
> +tarball_src: https://www.samba.org/ftp/tridge/dbench/dbench-4.0.tar.gz
> +gitrepo: https://git.samba.org/sahlberg/dbench.git
> +params:
> + - MOUNT_BLOCKDEV:
> + description: Storage device to be tested.
> + example: /dev/sdb1
> + optional: no
> + - MOUNT_POINT:
> + description: Mount point for the storage device
> + example: /mnt/
> + optional: no
> + - TIMELIMIT:
> + description: Test duration in seconds including warmup time.
> + example: 30
> + optional: no
> + - NPROCS:
> + description: Number of parallel threads.
> + example: 2
> + optional: no
> + - EXTRAPARAMS:
> + description: |
> + Additional parameters such as
> + -T, --tcp-options=STRING TCP socket options
> + -R, --target-rate=DOUBLE target throughput (MB/sec)
> + -s, --sync use O_SYNC
> + -S, --sync-dir sync directory changes
> + -F, --fsync fsync on write
> + -x, --xattr use xattrs
> + --no-resolve disable name resolution simulation
> + --clients-per-process=INT number of clients per process
> + --one-byte-write-fix try to fix 1 byte writes
> + --stat-check check for pointless calls with stat
> + --fake-io fake up read/write calls
> + --skip-cleanup skip cleanup operations
> + --per-client-results show results per client
> + example: -s -S -F
> + optional: yes
> +data_files:
> + - chart_config.json
> + - criteria.json
> + - dbench-4.00.tar.gz
> + - fuego_test.sh
> + - parser.py
> + - reference.json
> + - spec.json
> + - test.yaml
> --
> 2.7.4
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 5/7] dbench: remove testdir spec
2018-03-23 7:21 ` [Fuego] [PATCH 5/7] dbench: remove testdir spec Daniel Sangorrin
@ 2018-03-26 23:20 ` Tim.Bird
0 siblings, 0 replies; 13+ messages in thread
From: Tim.Bird @ 2018-03-26 23:20 UTC (permalink / raw)
To: daniel.sangorrin, fuego
Nice cleanup. Thanks.
Applied.
-- Tim
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 23, 2018 12:21 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 5/7] dbench: remove testdir spec
>
> This is already covered by the default spec
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
> engine/tests/Benchmark.dbench/spec.json | 18 ++++++------------
> 1 file changed, 6 insertions(+), 12 deletions(-)
>
> diff --git a/engine/tests/Benchmark.dbench/spec.json
> b/engine/tests/Benchmark.dbench/spec.json
> index 61dbfda..bf7d60d 100644
> --- a/engine/tests/Benchmark.dbench/spec.json
> +++ b/engine/tests/Benchmark.dbench/spec.json
> @@ -1,6 +1,12 @@
> {
> "testName": "Benchmark.dbench",
> "specs": {
> + "default": {
> + "MOUNT_BLOCKDEV":"ROOT",
> + "MOUNT_POINT":"$BOARD_TESTDIR/work",
> + "TIMELIMIT":"10",
> + "NPROCS":"2"
> + },
> "sata": {
> "MOUNT_BLOCKDEV":"$SATA_DEV",
> "MOUNT_POINT":"$SATA_MP",
> @@ -18,18 +24,6 @@
> "MOUNT_POINT":"$USB_MP",
> "TIMELIMIT":"10",
> "NPROCS":"2"
> - },
> - "default": {
> - "MOUNT_BLOCKDEV":"ROOT",
> - "MOUNT_POINT":"/a",
> - "TIMELIMIT":"10",
> - "NPROCS":"2"
> - },
> - "testdir": {
> - "MOUNT_BLOCKDEV":"ROOT",
> - "MOUNT_POINT":"$BOARD_TESTDIR/work",
> - "TIMELIMIT":"10",
> - "NPROCS":"2"
> }
> }
> }
> --
> 2.7.4
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 6/7] dbench: increase test duration
2018-03-23 7:21 ` [Fuego] [PATCH 6/7] dbench: increase test duration Daniel Sangorrin
@ 2018-03-26 23:21 ` Tim.Bird
0 siblings, 0 replies; 13+ messages in thread
From: Tim.Bird @ 2018-03-26 23:21 UTC (permalink / raw)
To: daniel.sangorrin, fuego
I'll take your word that this is useful. :-)
Thanks. Applied.
-- Tim
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 23, 2018 12:21 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 6/7] dbench: increase test duration
>
> Add a bit more duration so that the test has more warmup time.
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
> engine/tests/Benchmark.dbench/spec.json | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/engine/tests/Benchmark.dbench/spec.json
> b/engine/tests/Benchmark.dbench/spec.json
> index bf7d60d..5c37d6a 100644
> --- a/engine/tests/Benchmark.dbench/spec.json
> +++ b/engine/tests/Benchmark.dbench/spec.json
> @@ -4,25 +4,25 @@
> "default": {
> "MOUNT_BLOCKDEV":"ROOT",
> "MOUNT_POINT":"$BOARD_TESTDIR/work",
> - "TIMELIMIT":"10",
> + "TIMELIMIT":"30",
> "NPROCS":"2"
> },
> "sata": {
> "MOUNT_BLOCKDEV":"$SATA_DEV",
> "MOUNT_POINT":"$SATA_MP",
> - "TIMELIMIT":"10",
> + "TIMELIMIT":"30",
> "NPROCS":"2"
> },
> "mmc": {
> "MOUNT_BLOCKDEV":"$MMC_DEV",
> "MOUNT_POINT":"$MMC_MP",
> - "TIMELIMIT":"10",
> + "TIMELIMIT":"30",
> "NPROCS":"2"
> },
> "usb": {
> "MOUNT_BLOCKDEV":"$USB_DEV",
> "MOUNT_POINT":"$USB_MP",
> - "TIMELIMIT":"10",
> + "TIMELIMIT":"30",
> "NPROCS":"2"
> }
> }
> --
> 2.7.4
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes
2018-03-23 7:21 ` [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes Daniel Sangorrin
@ 2018-03-26 23:22 ` Tim.Bird
0 siblings, 0 replies; 13+ messages in thread
From: Tim.Bird @ 2018-03-26 23:22 UTC (permalink / raw)
To: daniel.sangorrin, fuego
Looks like a nice variation on the basic test.
Thanks. Applied.
-- Tim
> -----Original Message-----
> From: fuego-bounces@lists.linuxfoundation.org [mailto:fuego-
> bounces@lists.linuxfoundation.org] On Behalf Of Daniel Sangorrin
> Sent: Friday, March 23, 2018 12:22 AM
> To: fuego@lists.linuxfoundation.org
> Subject: [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes
>
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
> engine/tests/Benchmark.dbench/spec.json | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/engine/tests/Benchmark.dbench/spec.json
> b/engine/tests/Benchmark.dbench/spec.json
> index 5c37d6a..c855f36 100644
> --- a/engine/tests/Benchmark.dbench/spec.json
> +++ b/engine/tests/Benchmark.dbench/spec.json
> @@ -7,6 +7,13 @@
> "TIMELIMIT":"30",
> "NPROCS":"2"
> },
> + "sync": {
> + "MOUNT_BLOCKDEV":"ROOT",
> + "MOUNT_POINT":"$BOARD_TESTDIR/work",
> + "TIMELIMIT":"30",
> + "NPROCS":"2",
> + "EXTRAPARAMS":"-s -S -F"
> + },
> "sata": {
> "MOUNT_BLOCKDEV":"$SATA_DEV",
> "MOUNT_POINT":"$SATA_MP",
> --
> 2.7.4
>
>
> _______________________________________________
> Fuego mailing list
> Fuego@lists.linuxfoundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/fuego
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2018-03-26 23:22 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 7:21 [Fuego] dbench update Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 1/7] dbench: move asserts to pre_check Daniel Sangorrin
2018-03-26 23:11 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 2/7] dbench: update fuego_test for version 4.00 Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 3/7] dbench: update parser including max_latency Daniel Sangorrin
2018-03-23 7:21 ` [Fuego] [PATCH 4/7] dbench: add yaml file Daniel Sangorrin
2018-03-26 23:19 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 5/7] dbench: remove testdir spec Daniel Sangorrin
2018-03-26 23:20 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 6/7] dbench: increase test duration Daniel Sangorrin
2018-03-26 23:21 ` Tim.Bird
2018-03-23 7:21 ` [Fuego] [PATCH 7/7] dbench: add spec using synchronized writes Daniel Sangorrin
2018-03-26 23:22 ` Tim.Bird
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.