All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: jeffrey.t.kirsher@intel.com
Cc: sulrich@codeaurora.org, netdev@vger.kernel.org,
	timur@codeaurora.org, linux-kernel@vger.kernel.org,
	Sinan Kaya <okaya@codeaurora.org>,
	intel-wired-lan@lists.osuosl.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:52:56 -0400	[thread overview]
Message-ID: <1521831180-25014-4-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel(). writel() already has a barrier
on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index fa07876..df2283b 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -252,7 +252,7 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring,
 		 * such as IA-64).
 		*/
 		wmb();
-		writel(i, adapter->hw.hw_addr + rx_ring->tail);
+		writel_relaxed(i, adapter->hw.hw_addr + rx_ring->tail);
 	}
 }
 
@@ -2298,7 +2298,7 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter,
 
 	tx_ring->buffer_info[first].next_to_watch = tx_desc;
 	tx_ring->next_to_use = i;
-	writel(i, adapter->hw.hw_addr + tx_ring->tail);
+	writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail);
 	/* we need this if more than one processor can write to our tail
 	 * at a time, it synchronizes IO on IA64/Altix systems
 	 */
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: jeffrey.t.kirsher@intel.com
Cc: netdev@vger.kernel.org, timur@codeaurora.org,
	sulrich@codeaurora.org, linux-arm-msm@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Sinan Kaya <okaya@codeaurora.org>,
	intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org
Subject: [PATCH v7 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:52:56 -0400	[thread overview]
Message-ID: <1521831180-25014-4-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel(). writel() already has a barrier
on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index fa07876..df2283b 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -252,7 +252,7 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring,
 		 * such as IA-64).
 		*/
 		wmb();
-		writel(i, adapter->hw.hw_addr + rx_ring->tail);
+		writel_relaxed(i, adapter->hw.hw_addr + rx_ring->tail);
 	}
 }
 
@@ -2298,7 +2298,7 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter,
 
 	tx_ring->buffer_info[first].next_to_watch = tx_desc;
 	tx_ring->next_to_use = i;
-	writel(i, adapter->hw.hw_addr + tx_ring->tail);
+	writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail);
 	/* we need this if more than one processor can write to our tail
 	 * at a time, it synchronizes IO on IA64/Altix systems
 	 */
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v7 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:52:56 -0400	[thread overview]
Message-ID: <1521831180-25014-4-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel(). writel() already has a barrier
on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index fa07876..df2283b 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -252,7 +252,7 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring,
 		 * such as IA-64).
 		*/
 		wmb();
-		writel(i, adapter->hw.hw_addr + rx_ring->tail);
+		writel_relaxed(i, adapter->hw.hw_addr + rx_ring->tail);
 	}
 }
 
@@ -2298,7 +2298,7 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter,
 
 	tx_ring->buffer_info[first].next_to_watch = tx_desc;
 	tx_ring->next_to_use = i;
-	writel(i, adapter->hw.hw_addr + tx_ring->tail);
+	writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail);
 	/* we need this if more than one processor can write to our tail
 	 * at a time, it synchronizes IO on IA64/Altix systems
 	 */
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Sinan Kaya <okaya@codeaurora.org>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v7 3/7] igbvf: eliminate duplicate barriers on weakly-ordered archs
Date: Fri, 23 Mar 2018 14:52:56 -0400	[thread overview]
Message-ID: <1521831180-25014-4-git-send-email-okaya@codeaurora.org> (raw)
In-Reply-To: <1521831180-25014-1-git-send-email-okaya@codeaurora.org>

Code includes wmb() followed by writel(). writel() already has a barrier
on some architectures like arm64.

This ends up CPU observing two barriers back to back before executing the
register write.

Since code already has an explicit barrier call, changing writel() to
writel_relaxed().

Signed-off-by: Sinan Kaya <okaya@codeaurora.org>
---
 drivers/net/ethernet/intel/igbvf/netdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/intel/igbvf/netdev.c b/drivers/net/ethernet/intel/igbvf/netdev.c
index fa07876..df2283b 100644
--- a/drivers/net/ethernet/intel/igbvf/netdev.c
+++ b/drivers/net/ethernet/intel/igbvf/netdev.c
@@ -252,7 +252,7 @@ static void igbvf_alloc_rx_buffers(struct igbvf_ring *rx_ring,
 		 * such as IA-64).
 		*/
 		wmb();
-		writel(i, adapter->hw.hw_addr + rx_ring->tail);
+		writel_relaxed(i, adapter->hw.hw_addr + rx_ring->tail);
 	}
 }
 
@@ -2298,7 +2298,7 @@ static inline void igbvf_tx_queue_adv(struct igbvf_adapter *adapter,
 
 	tx_ring->buffer_info[first].next_to_watch = tx_desc;
 	tx_ring->next_to_use = i;
-	writel(i, adapter->hw.hw_addr + tx_ring->tail);
+	writel_relaxed(i, adapter->hw.hw_addr + tx_ring->tail);
 	/* we need this if more than one processor can write to our tail
 	 * at a time, it synchronizes IO on IA64/Altix systems
 	 */
-- 
2.7.4


  parent reply	other threads:[~2018-03-23 18:52 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-23 18:52 [PATCH v7 0/7] netdev: intel: Eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 18:52 ` Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 1/7] i40e/i40evf: " Sinan Kaya
2018-03-23 18:52   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 2/7] ixgbe: eliminate " Sinan Kaya
2018-03-23 18:52   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52 ` Sinan Kaya [this message]
2018-03-23 18:52   ` [Intel-wired-lan] [PATCH v7 3/7] igbvf: " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 4/7] igb: " Sinan Kaya
2018-03-23 18:52   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 5/7] fm10k: Eliminate " Sinan Kaya
2018-03-23 18:52   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:52 ` [PATCH v7 6/7] ixgbevf: keep writel() closer to wmb() Sinan Kaya
2018-03-23 18:52   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:52   ` Sinan Kaya
2018-03-23 18:53 ` [PATCH v7 7/7] ixgbevf: eliminate duplicate barriers on weakly-ordered archs Sinan Kaya
2018-03-23 18:53   ` [Intel-wired-lan] " Sinan Kaya
2018-03-23 18:53   ` Sinan Kaya
2018-03-23 21:53 ` [PATCH v7 0/7] netdev: intel: Eliminate " Alexander Duyck
2018-03-23 21:53   ` [Intel-wired-lan] " Alexander Duyck
2018-03-23 21:53   ` Alexander Duyck
2018-03-23 23:58   ` Jeff Kirsher
2018-03-23 23:58     ` [Intel-wired-lan] " Jeff Kirsher
2018-03-23 23:58     ` Jeff Kirsher
2018-03-24  2:34     ` okaya
2018-03-24  2:34       ` [Intel-wired-lan] " okaya
2018-03-24  2:34       ` okaya at codeaurora.org
2018-03-27 12:42       ` Sinan Kaya
2018-03-27 12:42         ` [Intel-wired-lan] " Sinan Kaya
2018-03-27 12:42         ` Sinan Kaya
2018-03-27 14:04         ` Lino Sanfilippo
2018-03-27 14:04           ` [Intel-wired-lan] " Lino Sanfilippo
2018-03-27 14:04           ` Lino Sanfilippo
2018-03-27 14:23           ` Sinan Kaya
2018-03-27 14:23             ` [Intel-wired-lan] " Sinan Kaya
2018-03-27 14:23             ` Sinan Kaya
2018-03-27 14:33             ` Aw: " Lino Sanfilippo
2018-03-27 14:33               ` [Intel-wired-lan] " Lino Sanfilippo
2018-03-27 14:33               ` Aw: " Lino Sanfilippo
2018-03-27 14:38             ` Alexander Duyck
2018-03-27 14:38               ` [Intel-wired-lan] " Alexander Duyck
2018-03-27 14:38               ` Alexander Duyck
2018-03-27 14:48               ` Sinan Kaya
2018-03-27 14:48                 ` [Intel-wired-lan] " Sinan Kaya
2018-03-27 14:48                 ` Sinan Kaya
2018-03-27 16:54         ` Jeff Kirsher
2018-03-27 16:54           ` [Intel-wired-lan] " Jeff Kirsher
2018-03-27 16:54           ` Jeff Kirsher
2018-03-27 17:33           ` Sinan Kaya
2018-03-27 17:33             ` [Intel-wired-lan] " Sinan Kaya
2018-03-27 17:33             ` Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521831180-25014-4-git-send-email-okaya@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=sulrich@codeaurora.org \
    --cc=timur@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.