[PATCH v3 1/5] staging: vt6655: Delete unused enum CARD_PKT_TYPE

[PATCH v3 1/5] staging: vt6655: Delete unused enum CARD_PKT_TYPE

[Nishka Dasgupta]

Delete unused enum CARD_PKT_TYPE.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v3:
 - Deleted the enum.

 drivers/staging/vt6655/card.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index be5254a..07d9fa0 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -39,13 +39,6 @@
 #define CB_MAX_CHANNEL_5G       42
 #define CB_MAX_CHANNEL          (CB_MAX_CHANNEL_24G + CB_MAX_CHANNEL_5G)
 
-enum CARD_PKT_TYPE {
-	PKT_TYPE_802_11_BCN,
-	PKT_TYPE_802_11_MNG,
-	PKT_TYPE_802_11_DATA,
-	PKT_TYPE_802_11_ALL
-};
-
 typedef enum _CARD_STATUS_TYPE {
 	CARD_STATUS_MEDIA_CONNECT,
 	CARD_STATUS_MEDIA_DISCONNECT,
-- 
2.7.4

[PATCH v3 2/5] staging: vt6655: Delete unused typedef enum _CARD_STATUS_TYPE

[Nishka Dasgupta]

Delete unused typedef enum _CARD_STATUS_TYPE.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v3:
 - delete the typedef.

 drivers/staging/vt6655/card.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
index 07d9fa0..5884fd5 100644
--- a/drivers/staging/vt6655/card.h
+++ b/drivers/staging/vt6655/card.h
@@ -39,12 +39,6 @@
 #define CB_MAX_CHANNEL_5G       42
 #define CB_MAX_CHANNEL          (CB_MAX_CHANNEL_24G + CB_MAX_CHANNEL_5G)
 
-typedef enum _CARD_STATUS_TYPE {
-	CARD_STATUS_MEDIA_CONNECT,
-	CARD_STATUS_MEDIA_DISCONNECT,
-	CARD_STATUS_PMKID
-} CARD_STATUS_TYPE, *PCARD_STATUS_TYPE;
-
 struct vnt_private;
 
 void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
-- 
2.7.4

[PATCH v3 3/5] staging: vt6655: Delete unused typedef struct _version

[Nishka Dasgupta]

Delete unused typedef struct _version.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v3:
 - Delete the typedef.

 drivers/staging/vt6655/device_cfg.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index 73f904b..b81f9dd 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -16,13 +16,6 @@
 
 #include <linux/types.h>
 
-typedef
-struct _version {
-	unsigned char   major;
-	unsigned char   minor;
-	unsigned char   build;
-} version_t, *pversion_t;
-
 #define VID_TABLE_SIZE      64
 #define MCAST_TABLE_SIZE    64
 #define MCAM_SIZE           32
-- 
2.7.4

[PATCH v3 4/5] staging: vt6655: Delete unused typedef enum _chip_type

[Nishka Dasgupta]

Delete unused typedef enum _chip_type.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v3:
 - Delete the typedef.

 drivers/staging/vt6655/device_cfg.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
index b81f9dd..6b41c74 100644
--- a/drivers/staging/vt6655/device_cfg.h
+++ b/drivers/staging/vt6655/device_cfg.h
@@ -45,8 +45,4 @@
 
 #define PKT_BUF_SZ          2390
 
-typedef enum  _chip_type {
-	VT3253 = 1
-} CHIP_TYPE, *PCHIP_TYPE;
-
 #endif
-- 
2.7.4

[PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Nishka Dasgupta]

Remove else after return statement. Issue found with checkpatch.

Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
---
Changes in v3:
 - None.

 drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
 1 file changed, 18 insertions(+), 19 deletions(-)

diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
index 9c4a532..89adee4 100644
--- a/drivers/staging/vt6655/rxtx.c
+++ b/drivers/staging/vt6655/rxtx.c
@@ -568,28 +568,27 @@ s_uFillDataHead(
 										wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
 			buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
 			return buf->duration;
-		} else {
-			struct vnt_tx_datahead_ab *buf = pTxDataHead;
-			/* Get SignalField, ServiceField & Length */
-			vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
-					  byPktType, &buf->ab);
-
-			if (is_pspoll) {
-				__le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
+		}
+		struct vnt_tx_datahead_ab *buf = pTxDataHead;
+		/* Get SignalField, ServiceField & Length */
+		vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
+				  byPktType, &buf->ab);
 
-				buf->duration = dur;
-			} else {
-				/* Get Duration and TimeStampOff */
-				buf->duration =
-					cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, cbFrameLength, byPktType,
-									    wCurrentRate, bNeedAck, uFragIdx,
-									    cbLastFragmentSize, uMACfragNum,
-									    byFBOption));
-			}
+		if (is_pspoll) {
+			__le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
 
-			buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
-			return buf->duration;
+			buf->duration = dur;
+		} else {
+			/* Get Duration and TimeStampOff */
+			buf->duration =
+				cpu_to_le16((u16)s_uGetDataDuration(pDevice, DATADUR_A, cbFrameLength, byPktType,
+								    wCurrentRate, bNeedAck, uFragIdx,
+								    cbLastFragmentSize, uMACfragNum,
+								    byFBOption));
 		}
+
+		buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
+		return buf->duration;
 	} else {
 		struct vnt_tx_datahead_ab *buf = pTxDataHead;
 		/* Get SignalField, ServiceField & Length */
-- 
2.7.4

Re: [Outreachy kernel] [PATCH v3 4/5] staging: vt6655: Delete unused typedef enum _chip_type

[Julia Lawall]

On Sat, 24 Mar 2018, Nishka Dasgupta wrote:

> Delete unused typedef enum _chip_type.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
> Changes in v3:
>  - Delete the typedef.
>
>  drivers/staging/vt6655/device_cfg.h | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
> index b81f9dd..6b41c74 100644
> --- a/drivers/staging/vt6655/device_cfg.h
> +++ b/drivers/staging/vt6655/device_cfg.h
> @@ -45,8 +45,4 @@
>
>  #define PKT_BUF_SZ          2390
>
> -typedef enum  _chip_type {
> -	VT3253 = 1
> -} CHIP_TYPE, *PCHIP_TYPE;
> -
>  #endif
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1521892758-27981-4-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 3/5] staging: vt6655: Delete unused typedef struct _version

[Julia Lawall]

On Sat, 24 Mar 2018, Nishka Dasgupta wrote:

> Delete unused typedef struct _version.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
> Changes in v3:
>  - Delete the typedef.
>
>  drivers/staging/vt6655/device_cfg.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/vt6655/device_cfg.h b/drivers/staging/vt6655/device_cfg.h
> index 73f904b..b81f9dd 100644
> --- a/drivers/staging/vt6655/device_cfg.h
> +++ b/drivers/staging/vt6655/device_cfg.h
> @@ -16,13 +16,6 @@
>
>  #include <linux/types.h>
>
> -typedef
> -struct _version {
> -	unsigned char   major;
> -	unsigned char   minor;
> -	unsigned char   build;
> -} version_t, *pversion_t;
> -
>  #define VID_TABLE_SIZE      64
>  #define MCAST_TABLE_SIZE    64
>  #define MCAM_SIZE           32
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1521892758-27981-3-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 2/5] staging: vt6655: Delete unused typedef enum _CARD_STATUS_TYPE

[Julia Lawall]

On Sat, 24 Mar 2018, Nishka Dasgupta wrote:

> Delete unused typedef enum _CARD_STATUS_TYPE.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>

> ---
> Changes in v3:
>  - delete the typedef.
>
>  drivers/staging/vt6655/card.h | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
> index 07d9fa0..5884fd5 100644
> --- a/drivers/staging/vt6655/card.h
> +++ b/drivers/staging/vt6655/card.h
> @@ -39,12 +39,6 @@
>  #define CB_MAX_CHANNEL_5G       42
>  #define CB_MAX_CHANNEL          (CB_MAX_CHANNEL_24G + CB_MAX_CHANNEL_5G)
>
> -typedef enum _CARD_STATUS_TYPE {
> -	CARD_STATUS_MEDIA_CONNECT,
> -	CARD_STATUS_MEDIA_DISCONNECT,
> -	CARD_STATUS_PMKID
> -} CARD_STATUS_TYPE, *PCARD_STATUS_TYPE;
> -
>  struct vnt_private;
>
>  void CARDvSetRSPINF(struct vnt_private *priv, u8 bb_type);
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1521892758-27981-2-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] [PATCH v3 1/5] staging: vt6655: Delete unused enum CARD_PKT_TYPE

[Julia Lawall]

On Sat, 24 Mar 2018, Nishka Dasgupta wrote:

> Delete unused enum CARD_PKT_TYPE.
>
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>

Acked-by: Julia Lawall <julia.lawall@lip6.fr>


> ---
> Changes in v3:
>  - Deleted the enum.
>
>  drivers/staging/vt6655/card.h | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/drivers/staging/vt6655/card.h b/drivers/staging/vt6655/card.h
> index be5254a..07d9fa0 100644
> --- a/drivers/staging/vt6655/card.h
> +++ b/drivers/staging/vt6655/card.h
> @@ -39,13 +39,6 @@
>  #define CB_MAX_CHANNEL_5G       42
>  #define CB_MAX_CHANNEL          (CB_MAX_CHANNEL_24G + CB_MAX_CHANNEL_5G)
>
> -enum CARD_PKT_TYPE {
> -	PKT_TYPE_802_11_BCN,
> -	PKT_TYPE_802_11_MNG,
> -	PKT_TYPE_802_11_DATA,
> -	PKT_TYPE_802_11_ALL
> -};
> -
>  typedef enum _CARD_STATUS_TYPE {
>  	CARD_STATUS_MEDIA_CONNECT,
>  	CARD_STATUS_MEDIA_DISCONNECT,
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1521892758-27981-1-git-send-email-nishka.dasgupta_ug18%40ashoka.edu.in.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Greg KH]

On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
> Remove else after return statement. Issue found with checkpatch.
> 
> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> ---
> Changes in v3:
>  - None.
> 
>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
>  1 file changed, 18 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> index 9c4a532..89adee4 100644
> --- a/drivers/staging/vt6655/rxtx.c
> +++ b/drivers/staging/vt6655/rxtx.c
> @@ -568,28 +568,27 @@ s_uFillDataHead(
>  										wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
>  			buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
>  			return buf->duration;
> -		} else {
> -			struct vnt_tx_datahead_ab *buf = pTxDataHead;
> -			/* Get SignalField, ServiceField & Length */
> -			vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
> -					  byPktType, &buf->ab);
> -
> -			if (is_pspoll) {
> -				__le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
> +		}
> +		struct vnt_tx_datahead_ab *buf = pTxDataHead;

NEVER add a build warning with a patch.  That's a huge sign you did not
do it correctly :(

Because of that, I can not take this change, sorry.  Please fix it up
and resend.

thanks,

greg k-h

Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Nishka Dasgupta]

On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
>> Remove else after return statement. Issue found with checkpatch.
>>
>> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
>> ---
>> Changes in v3:
>>  - None.
>>
>>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
>>  1 file changed, 18 insertions(+), 19 deletions(-)
>>
>> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
>> index 9c4a532..89adee4 100644
>> --- a/drivers/staging/vt6655/rxtx.c
>> +++ b/drivers/staging/vt6655/rxtx.c
>> @@ -568,28 +568,27 @@ s_uFillDataHead(
>>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
>>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
>>                       return buf->duration;
>> -             } else {
>> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
>> -                     /* Get SignalField, ServiceField & Length */
>> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
>> -                                       byPktType, &buf->ab);
>> -
>> -                     if (is_pspoll) {
>> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
>> +             }
>> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
>
> NEVER add a build warning with a patch.  That's a huge sign you did not
> do it correctly :(
>
> Because of that, I can not take this change, sorry.  Please fix it up
> and resend.
>
Which build warning is in this patch? (I apologise for adding it, and
will fix it when I can locate the warning.)

Also, should I resend the entire patch series (when I fix this) as
suggested on the website? Considering that the rest of the patchset
has been added to staging-testing?

Thanking you,
Nishka Dasgupta

> thanks,
>
> greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Julia Lawall]

On Wed, 28 Mar 2018, Nishka Dasgupta wrote:

> On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
> >> Remove else after return statement. Issue found with checkpatch.
> >>
> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> >> ---
> >> Changes in v3:
> >>  - None.
> >>
> >>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
> >>  1 file changed, 18 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> >> index 9c4a532..89adee4 100644
> >> --- a/drivers/staging/vt6655/rxtx.c
> >> +++ b/drivers/staging/vt6655/rxtx.c
> >> @@ -568,28 +568,27 @@ s_uFillDataHead(
> >>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
> >>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
> >>                       return buf->duration;
> >> -             } else {
> >> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >> -                     /* Get SignalField, ServiceField & Length */
> >> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
> >> -                                       byPktType, &buf->ab);
> >> -
> >> -                     if (is_pspoll) {
> >> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
> >> +             }
> >> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >
> > NEVER add a build warning with a patch.  That's a huge sign you did not
> > do it correctly :(
> >
> > Because of that, I can not take this change, sorry.  Please fix it up
> > and resend.
> >
> Which build warning is in this patch? (I apologise for adding it, and
> will fix it when I can locate the warning.)

In the Linux kernel, variables have to be declared at the top of a { }.

julia

>
> Also, should I resend the entire patch series (when I fix this) as
> suggested on the website? Considering that the rest of the patchset
> has been added to staging-testing?
>
> Thanking you,
> Nishka Dasgupta
>
> > thanks,
> >
> > greg k-h
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/CAC4%2B%2BKDDm5v%2BeSZynrWC2CpgWD-_CaN2xRE%2B-h0x3iyB99WPVQ%40mail.gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>

Re: [Outreachy kernel] Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Greg KH]

On Wed, Mar 28, 2018 at 06:23:46PM +0530, Nishka Dasgupta wrote:
> On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
> >> Remove else after return statement. Issue found with checkpatch.
> >>
> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> >> ---
> >> Changes in v3:
> >>  - None.
> >>
> >>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
> >>  1 file changed, 18 insertions(+), 19 deletions(-)
> >>
> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> >> index 9c4a532..89adee4 100644
> >> --- a/drivers/staging/vt6655/rxtx.c
> >> +++ b/drivers/staging/vt6655/rxtx.c
> >> @@ -568,28 +568,27 @@ s_uFillDataHead(
> >>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
> >>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
> >>                       return buf->duration;
> >> -             } else {
> >> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >> -                     /* Get SignalField, ServiceField & Length */
> >> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
> >> -                                       byPktType, &buf->ab);
> >> -
> >> -                     if (is_pspoll) {
> >> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
> >> +             }
> >> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >
> > NEVER add a build warning with a patch.  That's a huge sign you did not
> > do it correctly :(
> >
> > Because of that, I can not take this change, sorry.  Please fix it up
> > and resend.
> >
> Which build warning is in this patch? (I apologise for adding it, and
> will fix it when I can locate the warning.)

The one you get when you build the driver with this patch applied.  It
should be very obvious as there was not a build warning without this
patch :)

> Also, should I resend the entire patch series (when I fix this) as
> suggested on the website? Considering that the rest of the patchset
> has been added to staging-testing?

If your other patches have already been accepted, no need to resend
them.

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Nishka Dasgupta]

On Wed, Mar 28, 2018 at 9:38 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Mar 28, 2018 at 06:23:46PM +0530, Nishka Dasgupta wrote:
>> On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
>> >> Remove else after return statement. Issue found with checkpatch.
>> >>
>> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
>> >> ---
>> >> Changes in v3:
>> >>  - None.
>> >>
>> >>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
>> >>  1 file changed, 18 insertions(+), 19 deletions(-)
>> >>
>> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
>> >> index 9c4a532..89adee4 100644
>> >> --- a/drivers/staging/vt6655/rxtx.c
>> >> +++ b/drivers/staging/vt6655/rxtx.c
>> >> @@ -568,28 +568,27 @@ s_uFillDataHead(
>> >>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
>> >>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
>> >>                       return buf->duration;
>> >> -             } else {
>> >> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
>> >> -                     /* Get SignalField, ServiceField & Length */
>> >> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
>> >> -                                       byPktType, &buf->ab);
>> >> -
>> >> -                     if (is_pspoll) {
>> >> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
>> >> +             }
>> >> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
>> >
>> > NEVER add a build warning with a patch.  That's a huge sign you did not
>> > do it correctly :(
>> >
>> > Because of that, I can not take this change, sorry.  Please fix it up
>> > and resend.
>> >
>> Which build warning is in this patch? (I apologise for adding it, and
>> will fix it when I can locate the warning.)
>
> The one you get when you build the driver with this patch applied.  It
> should be very obvious as there was not a build warning without this
> patch :)

I have resent the patch as v4 (since I had 3 versions of the entire
patchset already).
This time, the build warnings were the usual 80-character limit ones
(that were already there); I left those in. Is that okay?

Thanking you,
Nishka Dasgupta

>> Also, should I resend the entire patch series (when I fix this) as
>> suggested on the website? Considering that the rest of the patchset
>> has been added to staging-testing?
>
> If your other patches have already been accepted, no need to resend
> them.
>
> thanks,
>
> greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Greg KH]

On Wed, Mar 28, 2018 at 11:00:24PM +0530, Nishka Dasgupta wrote:
> On Wed, Mar 28, 2018 at 9:38 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Wed, Mar 28, 2018 at 06:23:46PM +0530, Nishka Dasgupta wrote:
> >> On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >> > On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
> >> >> Remove else after return statement. Issue found with checkpatch.
> >> >>
> >> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
> >> >> ---
> >> >> Changes in v3:
> >> >>  - None.
> >> >>
> >> >>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
> >> >>  1 file changed, 18 insertions(+), 19 deletions(-)
> >> >>
> >> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
> >> >> index 9c4a532..89adee4 100644
> >> >> --- a/drivers/staging/vt6655/rxtx.c
> >> >> +++ b/drivers/staging/vt6655/rxtx.c
> >> >> @@ -568,28 +568,27 @@ s_uFillDataHead(
> >> >>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
> >> >>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
> >> >>                       return buf->duration;
> >> >> -             } else {
> >> >> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >> >> -                     /* Get SignalField, ServiceField & Length */
> >> >> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
> >> >> -                                       byPktType, &buf->ab);
> >> >> -
> >> >> -                     if (is_pspoll) {
> >> >> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
> >> >> +             }
> >> >> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
> >> >
> >> > NEVER add a build warning with a patch.  That's a huge sign you did not
> >> > do it correctly :(
> >> >
> >> > Because of that, I can not take this change, sorry.  Please fix it up
> >> > and resend.
> >> >
> >> Which build warning is in this patch? (I apologise for adding it, and
> >> will fix it when I can locate the warning.)
> >
> > The one you get when you build the driver with this patch applied.  It
> > should be very obvious as there was not a build warning without this
> > patch :)
> 
> I have resent the patch as v4 (since I had 3 versions of the entire
> patchset already).
> This time, the build warnings were the usual 80-character limit ones
> (that were already there); I left those in. Is that okay?

The compiler (gcc) does not emit 80-character warnings, only checkpatch
does.  Are you _sure_ you are actually building the kernel changes you
are making?

thanks,

greg k-h

Re: [Outreachy kernel] Re: [PATCH v3 5/5] staging: vt6655: Remove else after return statement

[Nishka Dasgupta]

On Wed, Mar 28, 2018 at 11:34 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Wed, Mar 28, 2018 at 11:00:24PM +0530, Nishka Dasgupta wrote:
>> On Wed, Mar 28, 2018 at 9:38 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> > On Wed, Mar 28, 2018 at 06:23:46PM +0530, Nishka Dasgupta wrote:
>> >> On Wed, Mar 28, 2018 at 5:27 PM, Greg KH <gregkh@linuxfoundation.org> wrote:
>> >> > On Sat, Mar 24, 2018 at 11:59:18AM +0000, Nishka Dasgupta wrote:
>> >> >> Remove else after return statement. Issue found with checkpatch.
>> >> >>
>> >> >> Signed-off-by: Nishka Dasgupta <nishka.dasgupta_ug18@ashoka.edu.in>
>> >> >> ---
>> >> >> Changes in v3:
>> >> >>  - None.
>> >> >>
>> >> >>  drivers/staging/vt6655/rxtx.c | 37 ++++++++++++++++++-------------------
>> >> >>  1 file changed, 18 insertions(+), 19 deletions(-)
>> >> >>
>> >> >> diff --git a/drivers/staging/vt6655/rxtx.c b/drivers/staging/vt6655/rxtx.c
>> >> >> index 9c4a532..89adee4 100644
>> >> >> --- a/drivers/staging/vt6655/rxtx.c
>> >> >> +++ b/drivers/staging/vt6655/rxtx.c
>> >> >> @@ -568,28 +568,27 @@ s_uFillDataHead(
>> >> >>                                                                               wCurrentRate, bNeedAck, uFragIdx, cbLastFragmentSize, uMACfragNum, byFBOption));
>> >> >>                       buf->time_stamp_off = vnt_time_stamp_off(pDevice, wCurrentRate);
>> >> >>                       return buf->duration;
>> >> >> -             } else {
>> >> >> -                     struct vnt_tx_datahead_ab *buf = pTxDataHead;
>> >> >> -                     /* Get SignalField, ServiceField & Length */
>> >> >> -                     vnt_get_phy_field(pDevice, cbFrameLength, wCurrentRate,
>> >> >> -                                       byPktType, &buf->ab);
>> >> >> -
>> >> >> -                     if (is_pspoll) {
>> >> >> -                             __le16 dur = cpu_to_le16(pDevice->current_aid | BIT(14) | BIT(15));
>> >> >> +             }
>> >> >> +             struct vnt_tx_datahead_ab *buf = pTxDataHead;
>> >> >
>> >> > NEVER add a build warning with a patch.  That's a huge sign you did not
>> >> > do it correctly :(
>> >> >
>> >> > Because of that, I can not take this change, sorry.  Please fix it up
>> >> > and resend.
>> >> >
>> >> Which build warning is in this patch? (I apologise for adding it, and
>> >> will fix it when I can locate the warning.)
>> >
>> > The one you get when you build the driver with this patch applied.  It
>> > should be very obvious as there was not a build warning without this
>> > patch :)
>>
>> I have resent the patch as v4 (since I had 3 versions of the entire
>> patchset already).
>> This time, the build warnings were the usual 80-character limit ones
>> (that were already there); I left those in. Is that okay?
>
> The compiler (gcc) does not emit 80-character warnings, only checkpatch
> does.  Are you _sure_ you are actually building the kernel changes you
> are making?

I apologise; I thought you were referring to checkpatch warnings,
because it is compiling fine at my end. I compiled the latest version
3 different times and ran checkpatch before submitting; there appear
to be no problems here anymore.

Thanking you,
Nishka Dasgupta

> thanks,
>
> greg k-h