* [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
@ 2018-03-28 12:51 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-03-28 12:51 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: Wei Yongjun, netdev, kernel-janitors
The devm_kfree function allocates memory that is released when a
driver detaches. Also the driver core clears the driver data to NULL
after device release. So remove the unnecessary pci_set_drvdata()
and devm_kfree().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index a31b4ad..8c55965 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
hnae3_unregister_ae_dev(ae_dev);
-
- devm_kfree(&pdev->dev, ae_dev);
-
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver hns3_driver = {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
@ 2018-03-28 12:51 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-03-28 12:51 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: Wei Yongjun, netdev, kernel-janitors
The devm_kfree function allocates memory that is released when a
driver detaches. Also the driver core clears the driver data to NULL
after device release. So remove the unnecessary pci_set_drvdata()
and devm_kfree().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index a31b4ad..8c55965 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
hnae3_unregister_ae_dev(ae_dev);
-
- devm_kfree(&pdev->dev, ae_dev);
-
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver hns3_driver = {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
2018-03-28 12:51 ` Wei Yongjun
@ 2018-03-29 18:35 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-03-29 18:35 UTC (permalink / raw)
To: weiyongjun1; +Cc: yisen.zhuang, salil.mehta, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 28 Mar 2018 12:51:01 +0000
> The devm_kfree function allocates memory that is released when a
devm_kfree doesn't allocate memory, it frees it.
Your commit log message is confusing at best. I know what you're
trying to say, but a lot of the logic is reversed or hard to
understand.
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
@ 2018-03-29 18:35 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2018-03-29 18:35 UTC (permalink / raw)
To: weiyongjun1; +Cc: yisen.zhuang, salil.mehta, netdev, kernel-janitors
From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Wed, 28 Mar 2018 12:51:01 +0000
> The devm_kfree function allocates memory that is released when a
devm_kfree doesn't allocate memory, it frees it.
Your commit log message is confusing at best. I know what you're
trying to say, but a lot of the logic is reversed or hard to
understand.
Thank you.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH net-next V2] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
2018-03-28 12:51 ` Wei Yongjun
@ 2018-03-30 2:24 ` Wei Yongjun
-1 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-03-30 2:24 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: Wei Yongjun, netdev, kernel-janitors
There is no need for explicit calls of devm_kfree(), as the allocated
memory will be freed during driver's detach.
The driver core clears the driver data to NULL after device_release.
Thus, it is not needed to manually clear the device driver data to NULL.
So remove the unnecessary pci_set_drvdata() and devm_kfree().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: change commit log
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index a31b4ad..8c55965 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
hnae3_unregister_ae_dev(ae_dev);
-
- devm_kfree(&pdev->dev, ae_dev);
-
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver hns3_driver = {
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net-next V2] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree()
@ 2018-03-30 2:24 ` Wei Yongjun
0 siblings, 0 replies; 6+ messages in thread
From: Wei Yongjun @ 2018-03-30 2:24 UTC (permalink / raw)
To: Yisen Zhuang, Salil Mehta; +Cc: Wei Yongjun, netdev, kernel-janitors
There is no need for explicit calls of devm_kfree(), as the allocated
memory will be freed during driver's detach.
The driver core clears the driver data to NULL after device_release.
Thus, it is not needed to manually clear the device driver data to NULL.
So remove the unnecessary pci_set_drvdata() and devm_kfree().
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
v1 -> v2: change commit log
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index a31b4ad..8c55965 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -1614,10 +1614,6 @@ static void hns3_remove(struct pci_dev *pdev)
struct hnae3_ae_dev *ae_dev = pci_get_drvdata(pdev);
hnae3_unregister_ae_dev(ae_dev);
-
- devm_kfree(&pdev->dev, ae_dev);
-
- pci_set_drvdata(pdev, NULL);
}
static struct pci_driver hns3_driver = {
^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-03-30 2:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-28 12:51 [PATCH net-next] net: hns3: remove unnecessary pci_set_drvdata() and devm_kfree() Wei Yongjun
2018-03-28 12:51 ` Wei Yongjun
2018-03-29 18:35 ` David Miller
2018-03-29 18:35 ` David Miller
2018-03-30 2:24 ` [PATCH net-next V2] " Wei Yongjun
2018-03-30 2:24 ` Wei Yongjun
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.