All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tracing: Uninitialized variable in create_tracing_map_fields()
Date: Wed, 28 Mar 2018 09:04:40 -0500	[thread overview]
Message-ID: <1522245880.520.1.camel@tzanussi-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <20180328114815.GC29050@mwanda>

Hi Dan,

On Wed, 2018-03-28 at 14:48 +0300, Dan Carpenter wrote:
> Smatch complains that idx can be used uninitialized when we check if
> (idx < 0).  It has to be the first iteration through the loop and the
> HIST_FIELD_FL_STACKTRACE bit has to be clear and the HIST_FIELD_FL_VAR
> bit has to be set to reach the bug.
> 
> Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 4f027642ceef..6aceee287d07 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -4411,7 +4411,7 @@ static int create_tracing_map_fields(struct hist_trigger_data *hist_data)
>  	struct tracing_map *map = hist_data->map;
>  	struct ftrace_event_field *field;
>  	struct hist_field *hist_field;
> -	int i, idx;
> +	int i, idx = 0;
>  
>  	for_each_hist_field(i, hist_data) {
>  		hist_field = hist_data->fields[i];

Yes, this should definitely be initialized to 0, thanks for the patch!

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>

WARNING: multiple messages have this Message-ID (diff)
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
	Ingo Molnar <mingo@redhat.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] tracing: Uninitialized variable in create_tracing_map_fields()
Date: Wed, 28 Mar 2018 14:04:40 +0000	[thread overview]
Message-ID: <1522245880.520.1.camel@tzanussi-mobl.amr.corp.intel.com> (raw)
In-Reply-To: <20180328114815.GC29050@mwanda>

Hi Dan,

On Wed, 2018-03-28 at 14:48 +0300, Dan Carpenter wrote:
> Smatch complains that idx can be used uninitialized when we check if
> (idx < 0).  It has to be the first iteration through the loop and the
> HIST_FIELD_FL_STACKTRACE bit has to be clear and the HIST_FIELD_FL_VAR
> bit has to be set to reach the bug.
> 
> Fixes: 30350d65ac56 ("tracing: Add variable support to hist triggers")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/kernel/trace/trace_events_hist.c b/kernel/trace/trace_events_hist.c
> index 4f027642ceef..6aceee287d07 100644
> --- a/kernel/trace/trace_events_hist.c
> +++ b/kernel/trace/trace_events_hist.c
> @@ -4411,7 +4411,7 @@ static int create_tracing_map_fields(struct hist_trigger_data *hist_data)
>  	struct tracing_map *map = hist_data->map;
>  	struct ftrace_event_field *field;
>  	struct hist_field *hist_field;
> -	int i, idx;
> +	int i, idx = 0;
>  
>  	for_each_hist_field(i, hist_data) {
>  		hist_field = hist_data->fields[i];

Yes, this should definitely be initialized to 0, thanks for the patch!

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>



  reply	other threads:[~2018-03-28 14:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 11:48 [PATCH] tracing: Uninitialized variable in create_tracing_map_fields() Dan Carpenter
2018-03-28 11:48 ` Dan Carpenter
2018-03-28 14:04 ` Tom Zanussi [this message]
2018-03-28 14:04   ` Tom Zanussi
2018-04-02 15:52   ` Steven Rostedt
2018-04-02 15:52     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522245880.520.1.camel@tzanussi-mobl.amr.corp.intel.com \
    --to=tom.zanussi@linux.intel.com \
    --cc=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.