All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Jun <jun.li@nxp.com>
To: robh+dt@kernel.org, gregkh@linuxfoundation.org,
	heikki.krogerus@linux.intel.com, linux@roeck-us.net
Cc: devel@driverdev.osuosl.org, devicetree@vger.kernel.org,
	peter.chen@nxp.com, linux-usb@vger.kernel.org,
	a.hajda@samsung.com, linux-imx@nxp.com, jun.li@nxp.com,
	shufan_lee@richtek.com
Subject: [PATCH v4 09/13] typec: tcpm: add starting value for drp toggling
Date: Thu, 29 Mar 2018 00:06:14 +0800	[thread overview]
Message-ID: <1522253178-32414-10-git-send-email-jun.li@nxp.com> (raw)
In-Reply-To: <1522253178-32414-1-git-send-email-jun.li@nxp.com>

As DRP port autonomously toggles the Rp/Rd need a start value to
begin with, so add one parameter for it in tcpm_start_drp_toggling.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Li Jun <jun.li@nxp.com>
---
 drivers/usb/typec/tcpm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 1744041b..218c230 100644
--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -1964,15 +1964,15 @@ static int tcpm_set_charge(struct tcpm_port *port, bool charge)
 	return 0;
 }
 
-static bool tcpm_start_drp_toggling(struct tcpm_port *port)
+static bool tcpm_start_drp_toggling(struct tcpm_port *port,
+				    enum typec_cc_status cc)
 {
 	int ret;
 
 	if (port->tcpc->start_drp_toggling &&
 	    port->port_type == TYPEC_PORT_DRP) {
 		tcpm_log_force(port, "Start DRP toggling");
-		ret = port->tcpc->start_drp_toggling(port->tcpc,
-						     tcpm_rp_cc(port));
+		ret = port->tcpc->start_drp_toggling(port->tcpc, cc);
 		if (!ret)
 			return true;
 	}
@@ -2282,7 +2282,7 @@ static void run_state_machine(struct tcpm_port *port)
 		if (!port->non_pd_role_swap)
 			tcpm_swap_complete(port, -ENOTCONN);
 		tcpm_src_detach(port);
-		if (tcpm_start_drp_toggling(port)) {
+		if (tcpm_start_drp_toggling(port, tcpm_rp_cc(port))) {
 			tcpm_set_state(port, DRP_TOGGLING, 0);
 			break;
 		}
@@ -2454,7 +2454,7 @@ static void run_state_machine(struct tcpm_port *port)
 		if (!port->non_pd_role_swap)
 			tcpm_swap_complete(port, -ENOTCONN);
 		tcpm_snk_detach(port);
-		if (tcpm_start_drp_toggling(port)) {
+		if (tcpm_start_drp_toggling(port, TYPEC_CC_RD)) {
 			tcpm_set_state(port, DRP_TOGGLING, 0);
 			break;
 		}
-- 
2.7.4

WARNING: multiple messages have this Message-ID (diff)
From: Jun Li <jun.li@nxp.com>
To: robh+dt@kernel.org, gregkh@linuxfoundation.org,
	heikki.krogerus@linux.intel.com, linux@roeck-us.net
Cc: a.hajda@samsung.com, shufan_lee@richtek.com, peter.chen@nxp.com,
	devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-imx@nxp.com, jun.li@nxp.com, devel@driverdev.osuosl.org
Subject: [v4,09/13] typec: tcpm: add starting value for drp toggling
Date: Thu, 29 Mar 2018 00:06:14 +0800	[thread overview]
Message-ID: <1522253178-32414-10-git-send-email-jun.li@nxp.com> (raw)

As DRP port autonomously toggles the Rp/Rd need a start value to
begin with, so add one parameter for it in tcpm_start_drp_toggling.

Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Li Jun <jun.li@nxp.com>
---
 drivers/usb/typec/tcpm.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
index 1744041b..218c230 100644
--- a/drivers/usb/typec/tcpm.c
+++ b/drivers/usb/typec/tcpm.c
@@ -1964,15 +1964,15 @@ static int tcpm_set_charge(struct tcpm_port *port, bool charge)
 	return 0;
 }
 
-static bool tcpm_start_drp_toggling(struct tcpm_port *port)
+static bool tcpm_start_drp_toggling(struct tcpm_port *port,
+				    enum typec_cc_status cc)
 {
 	int ret;
 
 	if (port->tcpc->start_drp_toggling &&
 	    port->port_type == TYPEC_PORT_DRP) {
 		tcpm_log_force(port, "Start DRP toggling");
-		ret = port->tcpc->start_drp_toggling(port->tcpc,
-						     tcpm_rp_cc(port));
+		ret = port->tcpc->start_drp_toggling(port->tcpc, cc);
 		if (!ret)
 			return true;
 	}
@@ -2282,7 +2282,7 @@ static void run_state_machine(struct tcpm_port *port)
 		if (!port->non_pd_role_swap)
 			tcpm_swap_complete(port, -ENOTCONN);
 		tcpm_src_detach(port);
-		if (tcpm_start_drp_toggling(port)) {
+		if (tcpm_start_drp_toggling(port, tcpm_rp_cc(port))) {
 			tcpm_set_state(port, DRP_TOGGLING, 0);
 			break;
 		}
@@ -2454,7 +2454,7 @@ static void run_state_machine(struct tcpm_port *port)
 		if (!port->non_pd_role_swap)
 			tcpm_swap_complete(port, -ENOTCONN);
 		tcpm_snk_detach(port);
-		if (tcpm_start_drp_toggling(port)) {
+		if (tcpm_start_drp_toggling(port, TYPEC_CC_RD)) {
 			tcpm_set_state(port, DRP_TOGGLING, 0);
 			break;
 		}

  parent reply	other threads:[~2018-03-28 16:06 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 16:06 [PATCH v4 00/13] staging: typec: tcpci: move out of staging Li Jun
2018-03-28 16:06 ` [PATCH v4 01/13] dt-bindings: connector: add properties for typec Li Jun
2018-03-28 16:06   ` [v4,01/13] " Jun Li
2018-03-29 19:54   ` [PATCH v4 01/13] " Mats Karrman
2018-03-29 19:54     ` [v4,01/13] " Mats Karrman
2018-03-31  3:34     ` [PATCH v4 01/13] " Jun Li
2018-03-31  3:34       ` [v4,01/13] " Jun Li
2018-04-03  8:29   ` [PATCH v4 01/13] " Andrzej Hajda
2018-04-03  8:29     ` [v4,01/13] " Andrzej Hajda
2018-04-13 11:51     ` [PATCH v4 01/13] " Jun Li
2018-04-13 11:51       ` [v4,01/13] " Jun Li
2018-04-30 11:23   ` [PATCH v4 01/13] " Heikki Krogerus
2018-04-30 11:23     ` [v4,01/13] " Heikki Krogerus
2018-05-01  7:57     ` [PATCH v4 01/13] " Jun Li
2018-05-01  7:57       ` [v4,01/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 02/13] dt-bindings: usb: add documentation for typec port controller(TCPCI) Li Jun
2018-03-28 16:06   ` [v4,02/13] " Jun Li
2018-04-09 20:04   ` [PATCH v4 02/13] " Rob Herring
2018-04-09 20:04     ` [v4,02/13] " Rob Herring
2018-04-16 11:54     ` [PATCH v4 02/13] " Jun Li
2018-04-16 11:54       ` [v4,02/13] " Jun Li
2018-04-16 14:28       ` [PATCH v4 02/13] " Rob Herring
2018-04-16 14:28         ` [v4,02/13] " Rob Herring
2018-04-19 14:47         ` [PATCH v4 02/13] " Jun Li
2018-04-19 14:47           ` [v4,02/13] " Jun Li
2018-04-30  7:41   ` [PATCH v4 02/13] " Mats Karrman
2018-04-30  7:41     ` [v4,02/13] " Mats Karrman
2018-05-01  7:54     ` [PATCH v4 02/13] " Jun Li
2018-05-01  7:54       ` [v4,02/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 03/13] staging: typec: tcpci: add compatible string for nxp ptn5110 Li Jun
2018-03-28 16:06   ` [v4,03/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 04/13] usb: typec: add fwnode to tcpc Li Jun
2018-03-28 16:06   ` [v4,04/13] " Jun Li
2018-03-29 12:57   ` [PATCH v4 04/13] " Heikki Krogerus
2018-03-29 12:57     ` [v4,04/13] " Heikki Krogerus
2018-03-31  3:17     ` [PATCH v4 04/13] " Jun Li
2018-03-31  3:17       ` [v4,04/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 05/13] usb: typec: add API to get typec basic port power and data config Li Jun
2018-03-28 16:06   ` [v4,05/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 06/13] usb: typec: tcpm: support get typec and pd config from device properties Li Jun
2018-03-28 16:06   ` [v4,06/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 07/13] staging: typec: tcpci: register port before request irq Li Jun
2018-03-28 16:06   ` [v4,07/13] " Jun Li
2018-03-29 10:52   ` [PATCH v4 07/13] " Dan Carpenter
2018-03-29 10:52     ` [v4,07/13] " Dan Carpenter
2018-03-31  3:09     ` [PATCH v4 07/13] " Jun Li
2018-03-31  3:09       ` [v4,07/13] " Jun Li
2018-03-31  8:01       ` [PATCH v4 07/13] " Dan Carpenter
2018-03-31  8:01         ` [v4,07/13] " Dan Carpenter
2018-03-28 16:06 ` [PATCH v4 08/13] staging: typec: tcpci: enable vbus detection Li Jun
2018-03-28 16:06   ` [v4,08/13] " Jun Li
2018-03-28 16:06 ` Li Jun [this message]
2018-03-28 16:06   ` [v4,09/13] typec: tcpm: add starting value for drp toggling Jun Li
2018-03-28 16:06 ` [PATCH v4 10/13] usb: typec: tcpm: set cc for drp toggling attach Li Jun
2018-03-28 16:06   ` [v4,10/13] " Jun Li
2018-03-29 21:18   ` [PATCH v4 10/13] " Mats Karrman
2018-03-29 21:18     ` [v4,10/13] " Mats Karrman
2018-03-31  3:37     ` [PATCH v4 10/13] " Jun Li
2018-03-31  3:37       ` [v4,10/13] " Jun Li
2018-03-29 22:49   ` [PATCH v4 10/13] " Guenter Roeck
2018-03-29 22:49     ` [v4,10/13] " Guenter Roeck
2018-03-31  4:38     ` [PATCH v4 10/13] " Jun Li
2018-03-31  4:38       ` [v4,10/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 11/13] staging: typec: tcpci: keep the not connecting cc line open Li Jun
2018-03-28 16:06   ` [v4,11/13] " Jun Li
2018-03-30 15:15   ` [PATCH v4 11/13] " Guenter Roeck
2018-03-30 15:15     ` [v4,11/13] " Guenter Roeck
2018-03-31  4:49     ` [PATCH v4 11/13] " Jun Li
2018-03-31  4:49       ` [v4,11/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 12/13] staging: typec: tcpci: Only touch target bit when enable vconn Li Jun
2018-03-28 16:06   ` [v4,12/13] " Jun Li
2018-03-28 16:06 ` [PATCH v4 13/13] staging: typec: tcpci: move tcpci driver out of staging Li Jun
2018-03-28 16:06   ` [v4,13/13] " Jun Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522253178-32414-10-git-send-email-jun.li@nxp.com \
    --to=jun.li@nxp.com \
    --cc=a.hajda@samsung.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=peter.chen@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shufan_lee@richtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.