All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yang <yang.a.shi@intel.com>
To: intel-gfx@lists.freedesktop.org
Cc: Yang Shi <yang.a.shi@intel.com>, Bo He <bo.he@intel.com>
Subject: [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it
Date: Thu, 29 Mar 2018 15:12:13 +0800	[thread overview]
Message-ID: <1522307533-31629-1-git-send-email-yang.a.shi@intel.com> (raw)

From: Yang Shi <yang.a.shi@intel.com>

snd_hdac driver would use the component interface from i915 driver.
if i915 driver do the audio component intialization too late, snd_hdac
driver will meet ipanic.

Signed-off-by: Bo He <bo.he@intel.com>
Signed-off-by: Yang Shi <yang.a.shi@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c      | 2 --
 drivers/gpu/drm/i915/intel_display.c | 2 ++
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 2f5209d..9d25d7e 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -1243,8 +1243,6 @@ static void i915_driver_register(struct drm_i915_private *dev_priv)
 	if (IS_GEN5(dev_priv))
 		intel_gpu_ips_init(dev_priv);
 
-	intel_audio_init(dev_priv);
-
 	/*
 	 * Some ports require correctly set-up hpd registers for detection to
 	 * work properly (leading to ghost connected connector status), e.g. VGA
diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
index f288bcc..a471c88 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -14468,6 +14468,8 @@ int intel_modeset_init(struct drm_device *dev)
 
 	dev->mode_config.funcs = &intel_mode_funcs;
 
+	intel_audio_init(dev_priv);
+
 	init_llist_head(&dev_priv->atomic_helper.free_list);
 	INIT_WORK(&dev_priv->atomic_helper.free_work,
 		  intel_atomic_helper_free_state_worker);
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

             reply	other threads:[~2018-03-29  7:04 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29  7:12 Yang [this message]
2018-03-29  8:07 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] drm/i915: move audio component intialization before audio driver use it Patchwork
2018-03-29  8:25 ` ✓ Fi.CI.BAT: success " Patchwork
2018-03-29 11:39 ` ✓ Fi.CI.IGT: " Patchwork
2018-03-29 11:55 ` [PATCH 1/1] " Chris Wilson
2018-03-29 13:15   ` Jani Nikula
2018-04-10  7:23     ` Shi, Yang A
2018-04-10  7:56       ` Jani Nikula
2018-04-10  8:21         ` Shi, Yang A
2018-04-10 10:57           ` Jani Nikula
2018-04-10 13:58             ` Jani Nikula
2018-04-11  1:37               ` Lucas De Marchi
     [not found]                 ` <E3ED5BF57CCD1C40876FA2D3385ED5D37B6183A4@SHSMSX101.ccr.corp.intel.com>
2018-04-11 12:25                   ` Jani Nikula
2018-04-12  3:32                     ` Shi, Yang A
2018-04-12  8:06                       ` Jani Nikula
2018-04-12  8:22                         ` Shi, Yang A
2018-04-11  2:07             ` Shi, Yang A
2018-04-11  9:48               ` Jani Nikula
2018-04-10  7:14   ` Shi, Yang A
2018-04-27  7:59 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1522307533-31629-1-git-send-email-yang.a.shi@intel.com \
    --to=yang.a.shi@intel.com \
    --cc=bo.he@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.