Re: [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

From: "Shi, Yang A" <yang.a.shi@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	"De Marchi, Lucas" <lucas.demarchi@intel.com>
Cc: "intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>, "He, Bo" <bo.he@intel.com>
Subject: Re: [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it
Date: Thu, 12 Apr 2018 03:32:29 +0000	[thread overview]
Message-ID: <E3ED5BF57CCD1C40876FA2D3385ED5D37B618770@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <87o9iqgcbm.fsf@intel.com>

>-----Original Message-----
>From: Jani Nikula [mailto:jani.nikula@linux.intel.com]
>Sent: Wednesday, April 11, 2018 8:25 PM
>To: Shi, Yang A <yang.a.shi@intel.com>; De Marchi, Lucas
><lucas.demarchi@intel.com>
>Cc: Chris Wilson <chris@chris-wilson.co.uk>; intel-gfx@lists.freedesktop.org; He, Bo
><bo.he@intel.com>; Deak, Imre <imre.deak@intel.com>
>Subject: RE: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization
>before audio driver use it
>
>On Wed, 11 Apr 2018, "Shi, Yang A" <yang.a.shi@intel.com> wrote:
>> This issue is not related to request_module. When issue happened,
>> request_module get i915 Correctly and return 0 successfully.  It just
>> be caused by acomp->ops is null in function snd_hdac_i915_init after
>> it called Component_master_add_with_match.
>>
>> If intel_audio_init can be called before it check
>> acomp->ops. Everything will goes well.  But intel_audio_init is called
>> too late because i915 driver go to usleep.
>
>Please add drm.debug=14 module parameter, enable dev_dbg for your driver, and send
>us the dmesg.
>
>BR,
>Jani.
Dmesg is as following:
i915 driver load at about 0.214362.
snd_soc_skl driver is loaded at about 0.853961.
it meet error here.
Then i915 continue to do driver load.

[    0.214362] [drm:i915_driver_load] No PCH found.
[    0.214377] [drm:intel_power_domains_init] Allowed DC state mask 09
...
[    0.217374] [drm:i915_driver_load] ppgtt mode: 3
[    0.217377] [drm:i915_driver_load] use GPU semaphores? no
[    0.217381] [drm:i915_driver_load] preemption enabled? no
[    0.217409] [drm] Memory usable by graphics device = 4078M
[    0.217414] [drm:i915_ggtt_probe_hw] GMADR size = 256M
[    0.217418] [drm:i915_ggtt_probe_hw] GTT stolen size = 64M
[    0.217453] [drm:i915_gem_init_stolen] Memory reserved for graphics device: 65536K, usable: 64512K
[    0.217467] [drm:sanitize_rc6_option] BIOS enabled RC states: HW_CTRL off HW_RC6 off SW_TARGET_STATE 4
[    0.217496] [drm:intel_opregion_setup] graphic opregion physical addr: 0x7aedd000
[    0.217533] [drm:intel_opregion_setup] ASLE supported
[    0.217541] [drm:intel_opregion_setup] Found valid VBT in ACPI OpRegion (RVDA)
[    0.217630] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013).
[    0.217633] [drm] Driver supports precise vblank timestamp query.
...
[    0.853961] snd_soc_skl 0000:00:0e.0: enabling device (0000 -> 0002)
[    0.859009] snd_soc_skl 0000:00:0e.0: failed to add i915 component master (-19)
[    0.888176] init: Starting service 'earlyaudioalsa'...
[    0.888471] init: write_file: Unable to open '/sys/kernel/debug/snd_soc_skl/nhlt/control': No such file or directory
[    0.902024] trusty trusty: trusty version: 14:57:13 Feb  7 2018
[    0.902043] trusty trusty: selected api version: 2 (requested 3)
[    0.904308] trusty-irq trusty-irq: irq from lk = 49
[    0.910886] trusty-virtio trusty-virtio: initializing
[    0.911177] trusty_ipc virtio0: vring0: va(pa)  ffff88007487a000(0) qsz 32 notifyid 1
[    0.911185] trusty_ipc virtio0: vring1: va(pa)  ffff880074894000(0) qsz 32 notifyid 2
[    0.911415] trusty-virtio trusty-virtio: initializing done
[    0.911695] trusty_ipc virtio0: is online
[    0.916608] trusty-wall trusty-wall: smwall: initialized 4096 bytes
[    0.919025] trusty-timer trusty-timer: initialized
[    0.929655] rpmb_sim rpmb_sim: registered RPMB capacity = 131072 of 512 blocks
[    0.930057] init: Service 'earlyaudioalsa' (pid 1925) exited with status 1
[    0.930405] init: Starting service 'logd'...
[    0.941825] [drm:intel_dp_aux_ch] dp_aux_ch timeout status 0x7d4003ff
[    0.950299] [drm:intel_dp_aux_ch] dp_aux_ch timeout status 0x7d4003ff
[    0.952397] logd.auditd: start
[    0.952416] logd.klogd: 910077775
[    0.958767] [drm:intel_dp_aux_ch] dp_aux_ch timeout status 0x7d4003ff
[    0.967223] [drm:intel_dp_aux_ch] dp_aux_ch timeout status 0x7d4003ff

BR.
Yang.

Yang Shi, Intel Open Source Technology Center

>
>--
>Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx