[PATCH] drm/amd/dc: Disentangle dc.h include from amdgpu.h

[PATCH] drm/amd/dc: Disentangle dc.h include from amdgpu.h

[Rex Zhu]

Use forward declaration in amdgpu_dm.h for struct dc instand
of include dc.h to make header files more standalone

Change-Id: I733a7e8499949aa9411e943230f9f50da6a8b8a2
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h       | 2 +-
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
index c6d5785..b5cf468 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
@@ -28,7 +28,6 @@
 
 #include <drm/drmP.h>
 #include <drm/drm_atomic.h>
-#include "dc.h"
 
 /*
  * This file contains the definition for amdgpu_display_manager
@@ -53,6 +52,7 @@
 struct amdgpu_device;
 struct drm_device;
 struct amdgpu_dm_irq_handler_data;
+struct dc;
 
 struct amdgpu_dm_prev_state {
 	struct drm_framebuffer *fb;
diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
index f6cb502..ef5fad8 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
@@ -25,6 +25,7 @@
 
 #include "amdgpu_mode.h"
 #include "amdgpu_dm.h"
+#include "dc.h"
 #include "modules/color/color_gamma.h"
 
 #define MAX_DRM_LUT_VALUE 0xFFFF
-- 
1.9.1

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amd/dc: Disentangle dc.h include from amdgpu.h

[Harry Wentland]

On 2018-03-29 03:44 AM, Rex Zhu wrote:
> Use forward declaration in amdgpu_dm.h for struct dc instand
> of include dc.h to make header files more standalone
> 
> Change-Id: I733a7e8499949aa9411e943230f9f50da6a8b8a2
> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Please drop the Change-Id before merging this.

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h       | 2 +-
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> index c6d5785..b5cf468 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h
> @@ -28,7 +28,6 @@
>  
>  #include <drm/drmP.h>
>  #include <drm/drm_atomic.h>
> -#include "dc.h"
>  
>  /*
>   * This file contains the definition for amdgpu_display_manager
> @@ -53,6 +52,7 @@
>  struct amdgpu_device;
>  struct drm_device;
>  struct amdgpu_dm_irq_handler_data;
> +struct dc;
>  
>  struct amdgpu_dm_prev_state {
>  	struct drm_framebuffer *fb;
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> index f6cb502..ef5fad8 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_color.c
> @@ -25,6 +25,7 @@
>  
>  #include "amdgpu_mode.h"
>  #include "amdgpu_dm.h"
> +#include "dc.h"
>  #include "modules/color/color_gamma.h"
>  
>  #define MAX_DRM_LUT_VALUE 0xFFFF
> 
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx