* [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
@ 2018-03-30 15:16 Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
` (6 more replies)
0 siblings, 7 replies; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-03-30 15:16 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: mreitz, kwolf, jsnow, eblake, stefanha, vsementsov, den
Blacklist these formats, as they don't support image creation, as they
say:
> ./qemu-img create -f bochs x 1m
qemu-img: x: Format driver 'bochs' does not support image creation
> ./qemu-img create -f cloop x 1m
qemu-img: x: Format driver 'cloop' does not support image creation
Vladimir Sementsov-Ogievskiy (3):
iotests.py: improve verify_image_format helper
iotests.py: support unsupported_fmts in main()
iotests: blacklist bochs and cloop for 205 and 208
tests/qemu-iotests/205 | 2 +-
tests/qemu-iotests/208 | 2 ++
tests/qemu-iotests/iotests.py | 11 ++++++-----
3 files changed, 9 insertions(+), 6 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
@ 2018-03-30 15:16 ` Vladimir Sementsov-Ogievskiy
2018-04-03 13:54 ` Kevin Wolf
2018-03-30 15:16 ` [Qemu-devel] [PATCH 2/3] iotests.py: support unsupported_fmts in main() Vladimir Sementsov-Ogievskiy
` (5 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-03-30 15:16 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: mreitz, kwolf, jsnow, eblake, stefanha, vsementsov, den
Add an assert (we don't want set both arguments) and remove
duplication.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index b5d7945..83c454d 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -532,9 +532,9 @@ def notrun(reason):
sys.exit(0)
def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
- if supported_fmts and (imgfmt not in supported_fmts):
- notrun('not suitable for this image format: %s' % imgfmt)
- if unsupported_fmts and (imgfmt in unsupported_fmts):
+ assert not (supported_fmts and unsupported_fmts)
+ not_sup = supported_fmts and (imgfmt not in supported_fmts)
+ if not_sup or (imgfmt in unsupported_fmts):
notrun('not suitable for this image format: %s' % imgfmt)
def verify_platform(supported_oses=['linux']):
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH 2/3] iotests.py: support unsupported_fmts in main()
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
@ 2018-03-30 15:16 ` Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
` (4 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-03-30 15:16 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: mreitz, kwolf, jsnow, eblake, stefanha, vsementsov, den
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/iotests.py | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
index 83c454d..89fe446 100644
--- a/tests/qemu-iotests/iotests.py
+++ b/tests/qemu-iotests/iotests.py
@@ -553,7 +553,8 @@ def verify_quorum():
if not supports_quorum():
notrun('quorum support missing')
-def main(supported_fmts=[], supported_oses=['linux'], supported_cache_modes=[]):
+def main(supported_fmts=[], supported_oses=['linux'], supported_cache_modes=[],
+ unsupported_fmts=[]):
'''Run tests'''
global debug
@@ -568,7 +569,7 @@ def main(supported_fmts=[], supported_oses=['linux'], supported_cache_modes=[]):
debug = '-d' in sys.argv
verbosity = 1
- verify_image_format(supported_fmts)
+ verify_image_format(supported_fmts, unsupported_fmts)
verify_platform(supported_oses)
verify_cache_mode(supported_cache_modes)
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 2/3] iotests.py: support unsupported_fmts in main() Vladimir Sementsov-Ogievskiy
@ 2018-03-30 15:16 ` Vladimir Sementsov-Ogievskiy
2018-04-03 13:36 ` Kevin Wolf
2018-03-30 15:17 ` [Qemu-devel] [PATCH for 2.12 0/3] " Vladimir Sementsov-Ogievskiy
` (3 subsequent siblings)
6 siblings, 1 reply; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-03-30 15:16 UTC (permalink / raw)
To: qemu-devel, qemu-block
Cc: mreitz, kwolf, jsnow, eblake, stefanha, vsementsov, den
Blacklist these formats, as they don't support image creation, as they
say:
> ./qemu-img create -f bochs x 1m
qemu-img: x: Format driver 'bochs' does not support image creation
> ./qemu-img create -f cloop x 1m
qemu-img: x: Format driver 'cloop' does not support image creation
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
tests/qemu-iotests/205 | 2 +-
tests/qemu-iotests/208 | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/205 b/tests/qemu-iotests/205
index e7b2eae..c41b929 100755
--- a/tests/qemu-iotests/205
+++ b/tests/qemu-iotests/205
@@ -153,4 +153,4 @@ class TestNbdServerRemove(iotests.QMPTestCase):
if __name__ == '__main__':
- iotests.main()
+ iotests.main(unsupported_fmts=['bochs', 'cloop'])
diff --git a/tests/qemu-iotests/208 b/tests/qemu-iotests/208
index 18f59ad..3bbfc9d 100755
--- a/tests/qemu-iotests/208
+++ b/tests/qemu-iotests/208
@@ -22,6 +22,8 @@
import iotests
+iotests.verify_image_format(unsupported_fmts=['bochs', 'cloop'])
+
with iotests.FilePath('disk.img') as disk_img_path, \
iotests.FilePath('disk-snapshot.img') as disk_snapshot_img_path, \
iotests.FilePath('nbd.sock') as nbd_sock_path, \
--
2.7.4
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH for 2.12 0/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
` (2 preceding siblings ...)
2018-03-30 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
@ 2018-03-30 15:17 ` Vladimir Sementsov-Ogievskiy
2018-03-31 8:29 ` [Qemu-devel] [PATCH " no-reply
` (2 subsequent siblings)
6 siblings, 0 replies; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-03-30 15:17 UTC (permalink / raw)
To: qemu-devel, qemu-block; +Cc: mreitz, kwolf, jsnow, eblake, stefanha, den
for 2.12
30.03.2018 18:16, Vladimir Sementsov-Ogievskiy wrote:
> Blacklist these formats, as they don't support image creation, as they
> say:
> > ./qemu-img create -f bochs x 1m
> qemu-img: x: Format driver 'bochs' does not support image creation
>
> > ./qemu-img create -f cloop x 1m
> qemu-img: x: Format driver 'cloop' does not support image creation
>
> Vladimir Sementsov-Ogievskiy (3):
> iotests.py: improve verify_image_format helper
> iotests.py: support unsupported_fmts in main()
> iotests: blacklist bochs and cloop for 205 and 208
>
> tests/qemu-iotests/205 | 2 +-
> tests/qemu-iotests/208 | 2 ++
> tests/qemu-iotests/iotests.py | 11 ++++++-----
> 3 files changed, 9 insertions(+), 6 deletions(-)
>
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
` (3 preceding siblings ...)
2018-03-30 15:17 ` [Qemu-devel] [PATCH for 2.12 0/3] " Vladimir Sementsov-Ogievskiy
@ 2018-03-31 8:29 ` no-reply
2018-03-31 8:58 ` no-reply
2018-04-04 10:05 ` Kevin Wolf
6 siblings, 0 replies; 14+ messages in thread
From: no-reply @ 2018-03-31 8:29 UTC (permalink / raw)
To: vsementsov
Cc: famz, qemu-devel, qemu-block, kwolf, jsnow, mreitz, stefanha, den
Hi,
This series failed docker-mingw@fedora build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1522422996-14235-1-git-send-email-vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-mingw@fedora
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7cf4f1b622 iotests: blacklist bochs and cloop for 205 and 208
d354810c5f iotests.py: support unsupported_fmts in main()
a0d5e80967 iotests.py: improve verify_image_format helper
=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-pu0wsk7f/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
BUILD fedora
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-pu0wsk7f/src'
GEN /var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064/qemu.tar
Cloning into '/var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064/qemu.tar.vroot'...
done.
Checking out files: 21% (1293/6066)
Checking out files: 22% (1335/6066)
Checking out files: 23% (1396/6066)
Checking out files: 24% (1456/6066)
Checking out files: 25% (1517/6066)
Checking out files: 26% (1578/6066)
Checking out files: 27% (1638/6066)
Checking out files: 28% (1699/6066)
Checking out files: 29% (1760/6066)
Checking out files: 30% (1820/6066)
Checking out files: 31% (1881/6066)
Checking out files: 32% (1942/6066)
Checking out files: 33% (2002/6066)
Checking out files: 34% (2063/6066)
Checking out files: 35% (2124/6066)
Checking out files: 36% (2184/6066)
Checking out files: 37% (2245/6066)
Checking out files: 38% (2306/6066)
Checking out files: 39% (2366/6066)
Checking out files: 40% (2427/6066)
Checking out files: 41% (2488/6066)
Checking out files: 42% (2548/6066)
Checking out files: 43% (2609/6066)
Checking out files: 44% (2670/6066)
Checking out files: 45% (2730/6066)
Checking out files: 46% (2791/6066)
Checking out files: 47% (2852/6066)
Checking out files: 48% (2912/6066)
Checking out files: 49% (2973/6066)
Checking out files: 50% (3033/6066)
Checking out files: 51% (3094/6066)
Checking out files: 52% (3155/6066)
Checking out files: 53% (3215/6066)
Checking out files: 53% (3230/6066)
Checking out files: 54% (3276/6066)
Checking out files: 55% (3337/6066)
Checking out files: 56% (3397/6066)
Checking out files: 57% (3458/6066)
Checking out files: 58% (3519/6066)
Checking out files: 59% (3579/6066)
Checking out files: 60% (3640/6066)
Checking out files: 61% (3701/6066)
Checking out files: 62% (3761/6066)
Checking out files: 63% (3822/6066)
Checking out files: 64% (3883/6066)
Checking out files: 65% (3943/6066)
Checking out files: 66% (4004/6066)
Checking out files: 67% (4065/6066)
Checking out files: 68% (4125/6066)
Checking out files: 69% (4186/6066)
Checking out files: 70% (4247/6066)
Checking out files: 71% (4307/6066)
Checking out files: 72% (4368/6066)
Checking out files: 72% (4422/6066)
Checking out files: 73% (4429/6066)
Checking out files: 74% (4489/6066)
Checking out files: 75% (4550/6066)
Checking out files: 76% (4611/6066)
Checking out files: 77% (4671/6066)
Checking out files: 78% (4732/6066)
Checking out files: 79% (4793/6066)
Checking out files: 80% (4853/6066)
Checking out files: 81% (4914/6066)
Checking out files: 82% (4975/6066)
Checking out files: 83% (5035/6066)
Checking out files: 84% (5096/6066)
Checking out files: 85% (5157/6066)
Checking out files: 86% (5217/6066)
Checking out files: 87% (5278/6066)
Checking out files: 88% (5339/6066)
Checking out files: 89% (5399/6066)
Checking out files: 90% (5460/6066)
Checking out files: 91% (5521/6066)
Checking out files: 92% (5581/6066)
Checking out files: 93% (5642/6066)
Checking out files: 94% (5703/6066)
Checking out files: 95% (5763/6066)
Checking out files: 96% (5824/6066)
Checking out files: 97% (5885/6066)
Checking out files: 98% (5945/6066)
Checking out files: 98% (5972/6066)
Checking out files: 99% (6006/6066)
Checking out files: 100% (6066/6066)
Checking out files: 100% (6066/6066), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into '/var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
tar: /var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064/qemu.tar: Wrote only 2048 of 10240 bytes
tar: Error is not recoverable: exiting now
failed to create tar file
COPY RUNNER
RUN test-mingw in qemu:fedora
tar: Unexpected EOF in archive
tar: rmtlseek not stopped at a record boundary
tar: Error is not recoverable: exiting now
/var/tmp/qemu/run: line 32: prep_fail: command not found
Packages installed:
PyYAML-3.12-5.fc27.x86_64
SDL-devel-1.2.15-29.fc27.x86_64
bc-1.07.1-3.fc27.x86_64
bison-3.0.4-8.fc27.x86_64
bzip2-1.0.6-24.fc27.x86_64
ccache-3.3.6-1.fc27.x86_64
clang-5.0.1-3.fc27.x86_64
findutils-4.6.0-16.fc27.x86_64
flex-2.6.1-5.fc27.x86_64
gcc-7.3.1-5.fc27.x86_64
gcc-c++-7.3.1-5.fc27.x86_64
gettext-0.19.8.1-12.fc27.x86_64
git-2.14.3-3.fc27.x86_64
glib2-devel-2.54.3-2.fc27.x86_64
hostname-3.18-4.fc27.x86_64
libaio-devel-0.3.110-9.fc27.x86_64
libasan-7.3.1-5.fc27.x86_64
libfdt-devel-1.4.6-1.fc27.x86_64
libubsan-7.3.1-5.fc27.x86_64
llvm-5.0.1-3.fc27.x86_64
make-4.2.1-4.fc27.x86_64
mingw32-SDL-1.2.15-9.fc27.noarch
mingw32-bzip2-1.0.6-9.fc27.noarch
mingw32-curl-7.54.1-2.fc27.noarch
mingw32-glib2-2.54.1-1.fc27.noarch
mingw32-gmp-6.1.2-2.fc27.noarch
mingw32-gnutls-3.5.13-2.fc27.noarch
mingw32-gtk2-2.24.31-4.fc27.noarch
mingw32-gtk3-3.22.16-1.fc27.noarch
mingw32-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw32-libpng-1.6.29-2.fc27.noarch
mingw32-libssh2-1.8.0-3.fc27.noarch
mingw32-libtasn1-4.13-1.fc27.noarch
mingw32-nettle-3.3-3.fc27.noarch
mingw32-pixman-0.34.0-3.fc27.noarch
mingw32-pkg-config-0.28-9.fc27.x86_64
mingw64-SDL-1.2.15-9.fc27.noarch
mingw64-bzip2-1.0.6-9.fc27.noarch
mingw64-curl-7.54.1-2.fc27.noarch
mingw64-glib2-2.54.1-1.fc27.noarch
mingw64-gmp-6.1.2-2.fc27.noarch
mingw64-gnutls-3.5.13-2.fc27.noarch
mingw64-gtk2-2.24.31-4.fc27.noarch
mingw64-gtk3-3.22.16-1.fc27.noarch
mingw64-libjpeg-turbo-1.5.1-3.fc27.noarch
mingw64-libpng-1.6.29-2.fc27.noarch
mingw64-libssh2-1.8.0-3.fc27.noarch
mingw64-libtasn1-4.13-1.fc27.noarch
mingw64-nettle-3.3-3.fc27.noarch
mingw64-pixman-0.34.0-3.fc27.noarch
mingw64-pkg-config-0.28-9.fc27.x86_64
nettle-devel-3.4-1.fc27.x86_64
perl-5.26.1-403.fc27.x86_64
pixman-devel-0.34.0-4.fc27.x86_64
python3-3.6.2-13.fc27.x86_64
sparse-0.5.1-2.fc27.x86_64
tar-1.29-7.fc27.x86_64
which-2.21-4.fc27.x86_64
zlib-devel-1.2.11-4.fc27.x86_64
Environment variables:
TARGET_LIST=
PACKAGES=ccache gettext git tar PyYAML sparse flex bison python3 bzip2 hostname glib2-devel pixman-devel zlib-devel SDL-devel libfdt-devel gcc gcc-c++ llvm clang make perl which bc findutils libaio-devel nettle-devel libasan libubsan mingw32-pixman mingw32-glib2 mingw32-gmp mingw32-SDL mingw32-pkg-config mingw32-gtk2 mingw32-gtk3 mingw32-gnutls mingw32-nettle mingw32-libtasn1 mingw32-libjpeg-turbo mingw32-libpng mingw32-curl mingw32-libssh2 mingw32-bzip2 mingw64-pixman mingw64-glib2 mingw64-gmp mingw64-SDL mingw64-pkg-config mingw64-gtk2 mingw64-gtk3 mingw64-gnutls mingw64-nettle mingw64-libtasn1 mingw64-libjpeg-turbo mingw64-libpng mingw64-curl mingw64-libssh2 mingw64-bzip2
J=8
V=
HOSTNAME=375d8731d17c
DEBUG=
SHOW_ENV=1
PWD=/
HOME=/root
CCACHE_DIR=/var/tmp/ccache
DISTTAG=f27container
QEMU_CONFIGURE_OPTS=--python=/usr/bin/python3
FGC=f27
TEST_DIR=/tmp/qemu-test
SHLVL=1
FEATURES=mingw clang pyyaml asan dtc
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
MAKEFLAGS= -j8
EXTRA_CONFIGURE_OPTS=
_=/usr/bin/env
/var/tmp/qemu/run: line 52: cd: /tmp/qemu-test/src/tests/docker: No such file or directory
/var/tmp/qemu/run: line 57: /test-mingw: No such file or directory
Traceback (most recent call last):
File "./tests/docker/docker.py", line 407, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 404, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 261, in run
return Docker().run(argv, args.keep, quiet=args.quiet)
File "./tests/docker/docker.py", line 229, in run
quiet=quiet)
File "./tests/docker/docker.py", line 147, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=ab3d2ec634bd11e896fe52540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-pu0wsk7f/src/docker-src.2018-03-31-04.29.21.3064:/var/tmp/qemu:z,ro', 'qemu:fedora', '/var/tmp/qemu/run', 'test-mingw']' returned non-zero exit status 127
make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1
make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-pu0wsk7f/src'
make: *** [tests/docker/Makefile.include:163: docker-run-test-mingw@fedora] Error 2
real 0m37.885s
user 0m8.983s
sys 0m6.942s
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
` (4 preceding siblings ...)
2018-03-31 8:29 ` [Qemu-devel] [PATCH " no-reply
@ 2018-03-31 8:58 ` no-reply
2018-04-04 10:05 ` Kevin Wolf
6 siblings, 0 replies; 14+ messages in thread
From: no-reply @ 2018-03-31 8:58 UTC (permalink / raw)
To: vsementsov
Cc: famz, qemu-devel, qemu-block, kwolf, jsnow, mreitz, stefanha, den
Hi,
This series failed docker-quick@centos6 build test. Please find the testing commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
Type: series
Message-id: 1522422996-14235-1-git-send-email-vsementsov@virtuozzo.com
Subject: [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
=== TEST SCRIPT BEGIN ===
#!/bin/bash
set -e
git submodule update --init dtc
# Let docker tests dump environment info
export SHOW_ENV=1
export J=8
time make docker-test-quick@centos6
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
7cf4f1b622 iotests: blacklist bochs and cloop for 205 and 208
d354810c5f iotests.py: support unsupported_fmts in main()
a0d5e80967 iotests.py: improve verify_image_format helper
=== OUTPUT BEGIN ===
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-hk2d24i3/src/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
BUILD centos6
make[1]: Entering directory '/var/tmp/patchew-tester-tmp-hk2d24i3/src'
GEN /var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950/qemu.tar
Cloning into '/var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950/qemu.tar.vroot'...
done.
Checking out files: 15% (936/6066)
Checking out files: 16% (971/6066)
Checking out files: 17% (1032/6066)
Checking out files: 18% (1092/6066)
Checking out files: 19% (1153/6066)
Checking out files: 20% (1214/6066)
Checking out files: 21% (1274/6066)
Checking out files: 22% (1335/6066)
Checking out files: 23% (1396/6066)
Checking out files: 24% (1456/6066)
Checking out files: 25% (1517/6066)
Checking out files: 26% (1578/6066)
Checking out files: 27% (1638/6066)
Checking out files: 28% (1699/6066)
Checking out files: 29% (1760/6066)
Checking out files: 30% (1820/6066)
Checking out files: 31% (1881/6066)
Checking out files: 32% (1942/6066)
Checking out files: 33% (2002/6066)
Checking out files: 34% (2063/6066)
Checking out files: 35% (2124/6066)
Checking out files: 36% (2184/6066)
Checking out files: 37% (2245/6066)
Checking out files: 38% (2306/6066)
Checking out files: 39% (2366/6066)
Checking out files: 40% (2427/6066)
Checking out files: 41% (2488/6066)
Checking out files: 42% (2548/6066)
Checking out files: 43% (2609/6066)
Checking out files: 44% (2670/6066)
Checking out files: 45% (2730/6066)
Checking out files: 45% (2752/6066)
Checking out files: 46% (2791/6066)
Checking out files: 47% (2852/6066)
Checking out files: 48% (2912/6066)
Checking out files: 49% (2973/6066)
Checking out files: 50% (3033/6066)
Checking out files: 51% (3094/6066)
Checking out files: 52% (3155/6066)
Checking out files: 53% (3215/6066)
Checking out files: 54% (3276/6066)
Checking out files: 55% (3337/6066)
Checking out files: 56% (3397/6066)
Checking out files: 57% (3458/6066)
Checking out files: 58% (3519/6066)
Checking out files: 59% (3579/6066)
Checking out files: 60% (3640/6066)
Checking out files: 60% (3686/6066)
Checking out files: 61% (3701/6066)
Checking out files: 62% (3761/6066)
Checking out files: 63% (3822/6066)
Checking out files: 63% (3873/6066)
Checking out files: 64% (3883/6066)
Checking out files: 65% (3943/6066)
Checking out files: 66% (4004/6066)
Checking out files: 67% (4065/6066)
Checking out files: 68% (4125/6066)
Checking out files: 69% (4186/6066)
Checking out files: 70% (4247/6066)
Checking out files: 71% (4307/6066)
Checking out files: 72% (4368/6066)
Checking out files: 73% (4429/6066)
Checking out files: 74% (4489/6066)
Checking out files: 75% (4550/6066)
Checking out files: 76% (4611/6066)
Checking out files: 77% (4671/6066)
Checking out files: 78% (4732/6066)
Checking out files: 79% (4793/6066)
Checking out files: 80% (4853/6066)
Checking out files: 81% (4914/6066)
Checking out files: 82% (4975/6066)
Checking out files: 83% (5035/6066)
Checking out files: 84% (5096/6066)
Checking out files: 85% (5157/6066)
Checking out files: 86% (5217/6066)
Checking out files: 87% (5278/6066)
Checking out files: 88% (5339/6066)
Checking out files: 89% (5399/6066)
Checking out files: 90% (5460/6066)
Checking out files: 91% (5521/6066)
Checking out files: 92% (5581/6066)
Checking out files: 93% (5642/6066)
Checking out files: 94% (5703/6066)
Checking out files: 94% (5747/6066)
Checking out files: 95% (5763/6066)
Checking out files: 96% (5824/6066)
Checking out files: 97% (5885/6066)
Checking out files: 98% (5945/6066)
Checking out files: 99% (6006/6066)
Checking out files: 100% (6066/6066)
Checking out files: 100% (6066/6066), done.
Your branch is up-to-date with 'origin/test'.
Submodule 'dtc' (git://git.qemu-project.org/dtc.git) registered for path 'dtc'
Cloning into '/var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950/qemu.tar.vroot/dtc'...
Submodule path 'dtc': checked out 'e54388015af1fb4bf04d0bca99caba1074d9cc42'
Submodule 'ui/keycodemapdb' (git://git.qemu.org/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into '/var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950/qemu.tar.vroot/ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
tar: /var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950/qemu.tar: Wrote only 2048 of 10240 bytes
tar: Error is not recoverable: exiting now
failed to create tar file
COPY RUNNER
RUN test-quick in qemu:centos6
tar: Unexpected EOF in archive
tar: Unexpected EOF in archive
tar: Error is not recoverable: exiting now
/var/tmp/qemu/run: line 32: prep_fail: command not found
Packages installed:
SDL-devel-1.2.14-7.el6_7.1.x86_64
bison-2.4.1-5.el6.x86_64
bzip2-devel-1.0.5-7.el6_0.x86_64
ccache-3.1.6-2.el6.x86_64
csnappy-devel-0-6.20150729gitd7bc683.el6.x86_64
flex-2.5.35-9.el6.x86_64
gcc-4.4.7-18.el6.x86_64
gettext-0.17-18.el6.x86_64
git-1.7.1-9.el6_9.x86_64
glib2-devel-2.28.8-9.el6.x86_64
libepoxy-devel-1.2-3.el6.x86_64
libfdt-devel-1.4.0-1.el6.x86_64
librdmacm-devel-1.0.21-0.el6.x86_64
lzo-devel-2.03-3.1.el6_5.1.x86_64
make-3.81-23.el6.x86_64
mesa-libEGL-devel-11.0.7-4.el6.x86_64
mesa-libgbm-devel-11.0.7-4.el6.x86_64
package g++ is not installed
pixman-devel-0.32.8-1.el6.x86_64
spice-glib-devel-0.26-8.el6.x86_64
spice-server-devel-0.12.4-16.el6.x86_64
tar-1.23-15.el6_8.x86_64
vte-devel-0.25.1-9.el6.x86_64
xen-devel-4.6.6-2.el6.x86_64
zlib-devel-1.2.3-29.el6.x86_64
Environment variables:
PACKAGES=bison bzip2-devel ccache csnappy-devel flex g++ gcc gettext git glib2-devel libepoxy-devel libfdt-devel librdmacm-devel lzo-devel make mesa-libEGL-devel mesa-libgbm-devel pixman-devel SDL-devel spice-glib-devel spice-server-devel tar vte-devel xen-devel zlib-devel
HOSTNAME=a76079573691
MAKEFLAGS= -j8
J=8
CCACHE_DIR=/var/tmp/ccache
EXTRA_CONFIGURE_OPTS=
V=
SHOW_ENV=1
PATH=/usr/lib/ccache:/usr/lib64/ccache:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin
PWD=/
TARGET_LIST=
SHLVL=1
HOME=/root
TEST_DIR=/tmp/qemu-test
FEATURES= dtc
DEBUG=
_=/usr/bin/env
/var/tmp/qemu/run: line 52: cd: /tmp/qemu-test/src/tests/docker: No such file or directory
/var/tmp/qemu/run: line 57: /test-quick: No such file or directory
/var/tmp/qemu/run: line 57: exec: /test-quick: cannot execute: No such file or directory
Traceback (most recent call last):
File "./tests/docker/docker.py", line 407, in <module>
sys.exit(main())
File "./tests/docker/docker.py", line 404, in main
return args.cmdobj.run(args, argv)
File "./tests/docker/docker.py", line 261, in run
return Docker().run(argv, args.keep, quiet=args.quiet)
File "./tests/docker/docker.py", line 229, in run
quiet=quiet)
File "./tests/docker/docker.py", line 147, in _do_check
return subprocess.check_call(self._command + cmd, **kwargs)
File "/usr/lib64/python2.7/subprocess.py", line 186, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['docker', 'run', '--label', 'com.qemu.instance.uuid=a192f4a634c111e8bcc552540069c830', '-u', '0', '--security-opt', 'seccomp=unconfined', '--rm', '--net=none', '-e', 'TARGET_LIST=', '-e', 'EXTRA_CONFIGURE_OPTS=', '-e', 'V=', '-e', 'J=8', '-e', 'DEBUG=', '-e', 'SHOW_ENV=1', '-e', 'CCACHE_DIR=/var/tmp/ccache', '-v', '/root/.cache/qemu-docker-ccache:/var/tmp/ccache:z', '-v', '/var/tmp/patchew-tester-tmp-hk2d24i3/src/docker-src.2018-03-31-04.57.44.29950:/var/tmp/qemu:z,ro', 'qemu:centos6', '/var/tmp/qemu/run', 'test-quick']' returned non-zero exit status 126
make[1]: *** [tests/docker/Makefile.include:129: docker-run] Error 1
make[1]: Leaving directory '/var/tmp/patchew-tester-tmp-hk2d24i3/src'
make: *** [tests/docker/Makefile.include:163: docker-run-test-quick@centos6] Error 2
real 0m34.382s
user 0m9.113s
sys 0m6.408s
=== OUTPUT END ===
Test command exited with code: 2
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
@ 2018-04-03 13:36 ` Kevin Wolf
2018-04-09 11:30 ` Vladimir Sementsov-Ogievskiy
0 siblings, 1 reply; 14+ messages in thread
From: Kevin Wolf @ 2018-04-03 13:36 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Blacklist these formats, as they don't support image creation, as they
> say:
> > ./qemu-img create -f bochs x 1m
> qemu-img: x: Format driver 'bochs' does not support image creation
>
> > ./qemu-img create -f cloop x 1m
> qemu-img: x: Format driver 'cloop' does not support image creation
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
We can take this for now, but I think I would actually prefer a solution
like in the bash tests, where the $IMGFMT_GENERIC environment variable
is checked for "_supported_fmt generic".
I suppose in Python test cases, we can assume that generic is meant when
neither supported_fmts nor unsupported_fmts are given (or both are empty
lists).
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
@ 2018-04-03 13:54 ` Kevin Wolf
2018-04-04 8:48 ` Vladimir Sementsov-Ogievskiy
0 siblings, 1 reply; 14+ messages in thread
From: Kevin Wolf @ 2018-04-03 13:54 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Add an assert (we don't want set both arguments) and remove
> duplication.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> ---
> tests/qemu-iotests/iotests.py | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> index b5d7945..83c454d 100644
> --- a/tests/qemu-iotests/iotests.py
> +++ b/tests/qemu-iotests/iotests.py
> @@ -532,9 +532,9 @@ def notrun(reason):
> sys.exit(0)
>
> def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
> - if supported_fmts and (imgfmt not in supported_fmts):
> - notrun('not suitable for this image format: %s' % imgfmt)
> - if unsupported_fmts and (imgfmt in unsupported_fmts):
> + assert not (supported_fmts and unsupported_fmts)
> + not_sup = supported_fmts and (imgfmt not in supported_fmts)
> + if not_sup or (imgfmt in unsupported_fmts):
> notrun('not suitable for this image format: %s' % imgfmt)
Before the change, we accepted None for both parameters. Now None is
still accepted for supported_fmts, but not for unsupported_fmts any
more.
I don't think we actually make use of None for either, so I don't really
mind whether we allow it or not, but we should be consistent between
both parameters.
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper
2018-04-03 13:54 ` Kevin Wolf
@ 2018-04-04 8:48 ` Vladimir Sementsov-Ogievskiy
2018-04-04 9:50 ` Kevin Wolf
0 siblings, 1 reply; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-04-04 8:48 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
03.04.2018 16:54, Kevin Wolf wrote:
> Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Add an assert (we don't want set both arguments) and remove
>> duplication.
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
>> ---
>> tests/qemu-iotests/iotests.py | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
>> index b5d7945..83c454d 100644
>> --- a/tests/qemu-iotests/iotests.py
>> +++ b/tests/qemu-iotests/iotests.py
>> @@ -532,9 +532,9 @@ def notrun(reason):
>> sys.exit(0)
>>
>> def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
>> - if supported_fmts and (imgfmt not in supported_fmts):
>> - notrun('not suitable for this image format: %s' % imgfmt)
>> - if unsupported_fmts and (imgfmt in unsupported_fmts):
>> + assert not (supported_fmts and unsupported_fmts)
>> + not_sup = supported_fmts and (imgfmt not in supported_fmts)
>> + if not_sup or (imgfmt in unsupported_fmts):
>> notrun('not suitable for this image format: %s' % imgfmt)
> Before the change, we accepted None for both parameters. Now None is
> still accepted for supported_fmts, but not for unsupported_fmts any
> more.
>
> I don't think we actually make use of None for either, so I don't really
> mind whether we allow it or not, but we should be consistent between
> both parameters.
>
> Kevin
I think, we should not care about it. The function takes lists. So, you can
1. pass a parameter, which must be list
2. do not pass it, it will become [] by default.
So if someone pass None directly, its a bug. Like if someone will pass
int or float..
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper
2018-04-04 8:48 ` Vladimir Sementsov-Ogievskiy
@ 2018-04-04 9:50 ` Kevin Wolf
0 siblings, 0 replies; 14+ messages in thread
From: Kevin Wolf @ 2018-04-04 9:50 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
Am 04.04.2018 um 10:48 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 03.04.2018 16:54, Kevin Wolf wrote:
> > Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > Add an assert (we don't want set both arguments) and remove
> > > duplication.
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > > ---
> > > tests/qemu-iotests/iotests.py | 6 +++---
> > > 1 file changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py
> > > index b5d7945..83c454d 100644
> > > --- a/tests/qemu-iotests/iotests.py
> > > +++ b/tests/qemu-iotests/iotests.py
> > > @@ -532,9 +532,9 @@ def notrun(reason):
> > > sys.exit(0)
> > > def verify_image_format(supported_fmts=[], unsupported_fmts=[]):
> > > - if supported_fmts and (imgfmt not in supported_fmts):
> > > - notrun('not suitable for this image format: %s' % imgfmt)
> > > - if unsupported_fmts and (imgfmt in unsupported_fmts):
> > > + assert not (supported_fmts and unsupported_fmts)
> > > + not_sup = supported_fmts and (imgfmt not in supported_fmts)
> > > + if not_sup or (imgfmt in unsupported_fmts):
> > > notrun('not suitable for this image format: %s' % imgfmt)
> > Before the change, we accepted None for both parameters. Now None is
> > still accepted for supported_fmts, but not for unsupported_fmts any
> > more.
> >
> > I don't think we actually make use of None for either, so I don't really
> > mind whether we allow it or not, but we should be consistent between
> > both parameters.
> >
> > Kevin
>
> I think, we should not care about it. The function takes lists. So, you can
> 1. pass a parameter, which must be list
> 2. do not pass it, it will become [] by default.
>
> So if someone pass None directly, its a bug. Like if someone will pass int
> or float..
Yeah, brain fart. Somehow I thought you could just check 'imgfmt not in
supported_fmts' without checking 'supported_fmt' first, but obviously
that would make the default that nothing is accepted. Your version is
fine.
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
` (5 preceding siblings ...)
2018-03-31 8:58 ` no-reply
@ 2018-04-04 10:05 ` Kevin Wolf
6 siblings, 0 replies; 14+ messages in thread
From: Kevin Wolf @ 2018-04-04 10:05 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> Blacklist these formats, as they don't support image creation, as they
> say:
> > ./qemu-img create -f bochs x 1m
> qemu-img: x: Format driver 'bochs' does not support image creation
>
> > ./qemu-img create -f cloop x 1m
> qemu-img: x: Format driver 'cloop' does not support image creation
Thanks, applied to the block branch. (But if you feel like implementing
the IMGFMT_GENERIC thing on top, I wouldn't mind. :-))
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208
2018-04-03 13:36 ` Kevin Wolf
@ 2018-04-09 11:30 ` Vladimir Sementsov-Ogievskiy
2018-04-09 13:29 ` Kevin Wolf
0 siblings, 1 reply; 14+ messages in thread
From: Vladimir Sementsov-Ogievskiy @ 2018-04-09 11:30 UTC (permalink / raw)
To: Kevin Wolf; +Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
03.04.2018 16:36, Kevin Wolf wrote:
> Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
>> Blacklist these formats, as they don't support image creation, as they
>> say:
>> > ./qemu-img create -f bochs x 1m
>> qemu-img: x: Format driver 'bochs' does not support image creation
>>
>> > ./qemu-img create -f cloop x 1m
>> qemu-img: x: Format driver 'cloop' does not support image creation
>>
>> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> We can take this for now, but I think I would actually prefer a solution
> like in the bash tests, where the $IMGFMT_GENERIC environment variable
> is checked for "_supported_fmt generic".
>
> I suppose in Python test cases, we can assume that generic is meant when
> neither supported_fmts nor unsupported_fmts are given (or both are empty
> lists).
>
> Kevin
it may be ok for verify_image_format, as we can call it or not call (to
support all formats).
but iotests main function always call verify_image_format, so, this will
skip bochs and cloop for all
iotests which call maind() without format restriction.
So, I think it is safer to directly mimic bash tests behavior - allow
'generic' as a member of supported_fmts.
--
Best regards,
Vladimir
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208
2018-04-09 11:30 ` Vladimir Sementsov-Ogievskiy
@ 2018-04-09 13:29 ` Kevin Wolf
0 siblings, 0 replies; 14+ messages in thread
From: Kevin Wolf @ 2018-04-09 13:29 UTC (permalink / raw)
To: Vladimir Sementsov-Ogievskiy
Cc: qemu-devel, qemu-block, mreitz, jsnow, eblake, stefanha, den
Am 09.04.2018 um 13:30 hat Vladimir Sementsov-Ogievskiy geschrieben:
> 03.04.2018 16:36, Kevin Wolf wrote:
> > Am 30.03.2018 um 17:16 hat Vladimir Sementsov-Ogievskiy geschrieben:
> > > Blacklist these formats, as they don't support image creation, as they
> > > say:
> > > > ./qemu-img create -f bochs x 1m
> > > qemu-img: x: Format driver 'bochs' does not support image creation
> > >
> > > > ./qemu-img create -f cloop x 1m
> > > qemu-img: x: Format driver 'cloop' does not support image creation
> > >
> > > Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
> > We can take this for now, but I think I would actually prefer a solution
> > like in the bash tests, where the $IMGFMT_GENERIC environment variable
> > is checked for "_supported_fmt generic".
> >
> > I suppose in Python test cases, we can assume that generic is meant when
> > neither supported_fmts nor unsupported_fmts are given (or both are empty
> > lists).
> >
> > Kevin
>
> it may be ok for verify_image_format, as we can call it or not call (to
> support all formats).
>
> but iotests main function always call verify_image_format, so, this
> will skip bochs and cloop for all iotests which call maind() without
> format restriction.
Yes, but that's what we want. Read-only formats can only be tested with
test cases made specifically for the respective format, because they
need to use a binary image from sample_images/.
I don't think there is a case where we really want to run the test for
all possible formats. Can you think of one?
> So, I think it is safer to directly mimic bash tests behavior - allow
> 'generic' as a member of supported_fmts.
That works, too, but I think it's not quite as nice.
Kevin
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-04-09 13:29 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-30 15:16 [Qemu-devel] [PATCH 0/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 1/3] iotests.py: improve verify_image_format helper Vladimir Sementsov-Ogievskiy
2018-04-03 13:54 ` Kevin Wolf
2018-04-04 8:48 ` Vladimir Sementsov-Ogievskiy
2018-04-04 9:50 ` Kevin Wolf
2018-03-30 15:16 ` [Qemu-devel] [PATCH 2/3] iotests.py: support unsupported_fmts in main() Vladimir Sementsov-Ogievskiy
2018-03-30 15:16 ` [Qemu-devel] [PATCH 3/3] iotests: blacklist bochs and cloop for 205 and 208 Vladimir Sementsov-Ogievskiy
2018-04-03 13:36 ` Kevin Wolf
2018-04-09 11:30 ` Vladimir Sementsov-Ogievskiy
2018-04-09 13:29 ` Kevin Wolf
2018-03-30 15:17 ` [Qemu-devel] [PATCH for 2.12 0/3] " Vladimir Sementsov-Ogievskiy
2018-03-31 8:29 ` [Qemu-devel] [PATCH " no-reply
2018-03-31 8:58 ` no-reply
2018-04-04 10:05 ` Kevin Wolf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.