All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Shreyansh Jain <shreyansh.jain@nxp.com>
Cc: Olivier MATZ <olivier.matz@6wind.com>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	john miller <john.miller@atomicrules.com>,
	dev@dpdk.org
Subject: Re: error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y
Date: Thu, 13 Apr 2017 08:53:37 +0200	[thread overview]
Message-ID: <15226233.lg7mjYJUEo@xps13> (raw)
In-Reply-To: <f8b70424-7369-c272-1d8f-f90ecb5809f0@nxp.com>

2017-04-13 12:11, Shreyansh Jain:
> On Thursday 13 April 2017 01:25 AM, Olivier MATZ wrote:
> > Hi,
> >
> > On Wed, 12 Apr 2017 14:31:56 +0200
> > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> >
> >> 2017-04-12 11:31, Richardson, Bruce:
> >>>
> 
> [...]
> 
> >>
> >> I think the default mempool could be linked.
> >> I don't know how easy it is to transform
> >> 	CONFIG_RTE_MBUF_DEFAULT_MEMPOOL_OPS="ring_mp_mc"
> >> into
> >> 	-lrte_mempool_ring
> >>
> >> Anyone for a patch?
> >
> > This is the default mempool for the mbufs, selected when using the
> > function rte_pktmbuf_pool_create().
> >
> > For non-mbuf mempools, the default is to use the ring handler (see
> > in rte_mempool_create()).
> >
> > So if we want option 2-, it looks that moving this line in rte.app.mk
> > above, outside the if (shared build), would do the job:
> >
> > _LDLIBS-$(CONFIG_RTE_DRIVER_MEMPOOL_RING)   += -lrte_mempool_ring
> >
> > I think both 2- and 3- are acceptable. People using the shared library
> > mode should already provide all the .so in a known location, so that
> > they are loaded by default. This is needed for the PMDs for instance.
> >
> 
> I can send the patch;
> before that, should this fact, that ring is included by default, is to 
> be documented somewhere?

Yes good idea.
Instead of "included", you could say "linked" without the need for -d option.

But actually, the mempool drivers are not documented.
We should totally update this section:
	http://dpdk.org/doc/guides/prog_guide/mempool_lib.html#mempool-handlers
So it should be another patch.

  reply	other threads:[~2017-04-13  6:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-11 18:02 error in testpmd when CONFIG_RTE_BUILD_SHARED_LIB=y john miller
2017-04-11 19:28 ` Thomas Monjalon
2017-04-12  4:52   ` Shreyansh Jain
2017-04-12 10:05     ` Bruce Richardson
2017-04-12 10:25       ` Thomas Monjalon
2017-04-12 11:40         ` Neil Horman
2017-04-12 10:26       ` Shreyansh Jain
2017-04-12 10:32         ` Ananyev, Konstantin
2017-04-12 10:33         ` Shreyansh Jain
2017-04-12 10:38           ` Bruce Richardson
2017-04-12 10:42             ` Bruce Richardson
2017-04-12 11:02               ` Van Haaren, Harry
2017-04-12 11:02               ` Shreyansh Jain
2017-04-12 11:31                 ` Richardson, Bruce
2017-04-12 12:31                   ` Thomas Monjalon
2017-04-12 19:55                     ` Olivier MATZ
2017-04-13  6:41                       ` Shreyansh Jain
2017-04-13  6:53                         ` Thomas Monjalon [this message]
2017-04-12 14:43                 ` Ananyev, Konstantin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15226233.lg7mjYJUEo@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.miller@atomicrules.com \
    --cc=olivier.matz@6wind.com \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.