* Patch "ACPI, PCI, irq: remove redundant check for null string pointer" has been added to the 4.4-stable tree
@ 2018-04-03 12:53 gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2018-04-03 12:53 UTC (permalink / raw)
To: colin.king, gregkh, natechancellor, rafael.j.wysocki
Cc: stable, stable-commits
This is a note to let you know that I've just added the patch titled
ACPI, PCI, irq: remove redundant check for null string pointer
to the 4.4-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary
The filename of the patch is:
acpi-pci-irq-remove-redundant-check-for-null-string-pointer.patch
and it can be found in the queue-4.4 subdirectory.
If you, or anyone else, feels it should not be added to the stable tree,
please let <stable@vger.kernel.org> know about it.
>From 45288978859119c019eff93f0cb838a0de100bcc Mon Sep 17 00:00:00 2001
From: Colin Ian King <colin.king@canonical.com>
Date: Tue, 5 Jan 2016 10:57:11 +0000
Subject: ACPI, PCI, irq: remove redundant check for null string pointer
From: Colin Ian King <colin.king@canonical.com>
commit 45288978859119c019eff93f0cb838a0de100bcc upstream.
source is decleared as a 4 byte char array in struct acpi_pci_routing_table
so !prt->source is a redundant null string pointer check. Detected with
smatch:
drivers/acpi/pci_irq.c:134 do_prt_fixups() warn: this array is probably
non-NULL. 'prt->source'
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Cc: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/acpi/pci_irq.c | 3 ---
1 file changed, 3 deletions(-)
--- a/drivers/acpi/pci_irq.c
+++ b/drivers/acpi/pci_irq.c
@@ -131,9 +131,6 @@ static void do_prt_fixups(struct acpi_pr
quirk = &prt_quirks[i];
/* All current quirks involve link devices, not GSIs */
- if (!prt->source)
- continue;
-
if (dmi_check_system(quirk->system) &&
entry->id.segment == quirk->segment &&
entry->id.bus == quirk->bus &&
Patches currently in stable-queue which might be from colin.king@canonical.com are
queue-4.4/acpi-pci-irq-remove-redundant-check-for-null-string-pointer.patch
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2018-04-03 12:53 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-03 12:53 Patch "ACPI, PCI, irq: remove redundant check for null string pointer" has been added to the 4.4-stable tree gregkh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.