* [PATCH] drm/i915: Store preemption capability in engine->flags
@ 2018-03-31 10:42 Chris Wilson
2018-03-31 11:15 ` ✓ Fi.CI.BAT: success for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Chris Wilson @ 2018-03-31 10:42 UTC (permalink / raw)
To: intel-gfx
Let's avoid having to delve down the pointer chain to see if the i915
device has support for preemption and store that on the engine, which
made the decision in the first place!
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tomasz Lis <tomasz.lis@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Michał Winiarski <michal.winiarski@intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/intel_lrc.c | 7 +++++--
drivers/gpu/drm/i915/intel_ringbuffer.h | 13 +++++++++++--
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
index f60b61bf8b3b..48073987214f 100644
--- a/drivers/gpu/drm/i915/intel_lrc.c
+++ b/drivers/gpu/drm/i915/intel_lrc.c
@@ -183,7 +183,8 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,
const struct i915_request *last,
int prio)
{
- return engine->i915->preempt_context && prio > max(rq_prio(last), 0);
+ return (intel_engine_has_preemption(engine) &&
+ prio > max(rq_prio(last), 0));
}
/**
@@ -2089,11 +2090,13 @@ static void execlists_set_default_submission(struct intel_engine_cs *engine)
engine->unpark = NULL;
engine->flags |= I915_ENGINE_SUPPORTS_STATS;
+ if (engine->i915->preempt_context)
+ engine->flags |= I915_ENGINE_HAS_PREEMPTION;
engine->i915->caps.scheduler =
I915_SCHEDULER_CAP_ENABLED |
I915_SCHEDULER_CAP_PRIORITY;
- if (engine->i915->preempt_context)
+ if (intel_engine_has_preemption(engine))
engine->i915->caps.scheduler |= I915_SCHEDULER_CAP_PREEMPTION;
}
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
index a02c7b3b9d55..1079254e6b89 100644
--- a/drivers/gpu/drm/i915/intel_ringbuffer.h
+++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
@@ -562,6 +562,7 @@ struct intel_engine_cs {
#define I915_ENGINE_NEEDS_CMD_PARSER BIT(0)
#define I915_ENGINE_SUPPORTS_STATS BIT(1)
+#define I915_ENGINE_HAS_PREEMPTION BIT(2)
unsigned int flags;
/*
@@ -621,16 +622,24 @@ struct intel_engine_cs {
} stats;
};
-static inline bool intel_engine_needs_cmd_parser(struct intel_engine_cs *engine)
+static inline bool
+intel_engine_needs_cmd_parser(const struct intel_engine_cs *engine)
{
return engine->flags & I915_ENGINE_NEEDS_CMD_PARSER;
}
-static inline bool intel_engine_supports_stats(struct intel_engine_cs *engine)
+static inline bool
+intel_engine_supports_stats(const struct intel_engine_cs *engine)
{
return engine->flags & I915_ENGINE_SUPPORTS_STATS;
}
+static inline bool
+intel_engine_has_preemption(const struct intel_engine_cs *engine)
+{
+ return engine->flags & I915_ENGINE_HAS_PREEMPTION;
+}
+
static inline void
execlists_set_active(struct intel_engine_execlists *execlists,
unsigned int bit)
--
2.16.3
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Store preemption capability in engine->flags
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
@ 2018-03-31 11:15 ` Patchwork
2018-03-31 11:58 ` ✓ Fi.CI.IGT: " Patchwork
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-03-31 11:15 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Store preemption capability in engine->flags
URL : https://patchwork.freedesktop.org/series/40982/
State : success
== Summary ==
Series 40982v1 drm/i915: Store preemption capability in engine->flags
https://patchwork.freedesktop.org/api/1.0/series/40982/revisions/1/mbox/
---- Known issues:
Test gem_mmap_gtt:
Subgroup basic-small-bo-tiledx:
fail -> PASS (fi-gdg-551) fdo#102575
Test kms_flip:
Subgroup basic-flip-vs-wf_vblank:
pass -> FAIL (fi-cfl-s3) fdo#100368
fdo#102575 https://bugs.freedesktop.org/show_bug.cgi?id=102575
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:434s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:440s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:379s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:536s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:296s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:512s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:518s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:516s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:508s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:410s
fi-cfl-s3 total:285 pass:258 dwarn:0 dfail:0 fail:1 skip:26 time:557s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:513s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:584s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:422s
fi-gdg-551 total:285 pass:177 dwarn:0 dfail:0 fail:0 skip:108 time:318s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:538s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:406s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:420s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:472s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:432s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:471s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:464s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:508s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:665s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:444s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:532s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:503s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:523s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:427s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:445s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:555s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:401s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:541s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:483s
c46052cde6a50c5459e00791ffc4d5aa1ec58a9e drm-tip: 2018y-03m-30d-18h-56m-26s UTC integration manifest
f22f558cca4d drm/i915: Store preemption capability in engine->flags
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8555/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Store preemption capability in engine->flags
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
2018-03-31 11:15 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-03-31 11:58 ` Patchwork
2018-04-02 16:15 ` [PATCH] " Daniele Ceraolo Spurio
` (3 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-03-31 11:58 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Store preemption capability in engine->flags
URL : https://patchwork.freedesktop.org/series/40982/
State : success
== Summary ==
---- Possible new issues:
Test kms_cursor_crc:
Subgroup cursor-64x64-suspend:
dmesg-warn -> PASS (shard-snb)
---- Known issues:
Test gem_softpin:
Subgroup noreloc-s3:
incomplete -> PASS (shard-hsw) fdo#103540
Test kms_flip:
Subgroup 2x-plain-flip-ts-check-interruptible:
pass -> FAIL (shard-hsw) fdo#100368
Subgroup flip-vs-expired-vblank:
pass -> FAIL (shard-hsw) fdo#102887 +1
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-shrfb-msflip-blt:
dmesg-fail -> PASS (shard-apl) fdo#104727
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#104727 https://bugs.freedesktop.org/show_bug.cgi?id=104727
shard-apl total:3495 pass:1831 dwarn:1 dfail:0 fail:7 skip:1655 time:12870s
shard-hsw total:3495 pass:1780 dwarn:1 dfail:0 fail:4 skip:1709 time:11701s
shard-snb total:3495 pass:1374 dwarn:1 dfail:0 fail:3 skip:2117 time:6982s
Blacklisted hosts:
shard-kbl total:3495 pass:1958 dwarn:1 dfail:0 fail:8 skip:1528 time:9227s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8555/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915: Store preemption capability in engine->flags
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
2018-03-31 11:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-31 11:58 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-02 16:15 ` Daniele Ceraolo Spurio
2018-04-03 19:22 ` ✓ Fi.CI.BAT: success for drm/i915: Store preemption capability in engine->flags (rev2) Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Daniele Ceraolo Spurio @ 2018-04-02 16:15 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 31/03/18 03:42, Chris Wilson wrote:
> Let's avoid having to delve down the pointer chain to see if the i915
> device has support for preemption and store that on the engine, which
> made the decision in the first place!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomasz Lis <tomasz.lis@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/intel_lrc.c | 7 +++++--
> drivers/gpu/drm/i915/intel_ringbuffer.h | 13 +++++++++++--
> 2 files changed, 16 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c
> index f60b61bf8b3b..48073987214f 100644
> --- a/drivers/gpu/drm/i915/intel_lrc.c
> +++ b/drivers/gpu/drm/i915/intel_lrc.c
> @@ -183,7 +183,8 @@ static inline bool need_preempt(const struct intel_engine_cs *engine,
> const struct i915_request *last,
> int prio)
> {
> - return engine->i915->preempt_context && prio > max(rq_prio(last), 0);
> + return (intel_engine_has_preemption(engine) &&
> + prio > max(rq_prio(last), 0));
This is re-coded in guc_dequeue so we could either use
intel_engine_has_preemption() over there as well or move
need_preempt() to a common header and call it from there. Apart from
this the patch LGTM.
Daniele
> }
>
> /**
> @@ -2089,11 +2090,13 @@ static void execlists_set_default_submission(struct intel_engine_cs *engine)
> engine->unpark = NULL;
>
> engine->flags |= I915_ENGINE_SUPPORTS_STATS;
> + if (engine->i915->preempt_context)
> + engine->flags |= I915_ENGINE_HAS_PREEMPTION;
>
> engine->i915->caps.scheduler =
> I915_SCHEDULER_CAP_ENABLED |
> I915_SCHEDULER_CAP_PRIORITY;
> - if (engine->i915->preempt_context)
> + if (intel_engine_has_preemption(engine))
> engine->i915->caps.scheduler |= I915_SCHEDULER_CAP_PREEMPTION;
> }
>
> diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h b/drivers/gpu/drm/i915/intel_ringbuffer.h
> index a02c7b3b9d55..1079254e6b89 100644
> --- a/drivers/gpu/drm/i915/intel_ringbuffer.h
> +++ b/drivers/gpu/drm/i915/intel_ringbuffer.h
> @@ -562,6 +562,7 @@ struct intel_engine_cs {
>
> #define I915_ENGINE_NEEDS_CMD_PARSER BIT(0)
> #define I915_ENGINE_SUPPORTS_STATS BIT(1)
> +#define I915_ENGINE_HAS_PREEMPTION BIT(2)
> unsigned int flags;
>
> /*
> @@ -621,16 +622,24 @@ struct intel_engine_cs {
> } stats;
> };
>
> -static inline bool intel_engine_needs_cmd_parser(struct intel_engine_cs *engine)
> +static inline bool
> +intel_engine_needs_cmd_parser(const struct intel_engine_cs *engine)
> {
> return engine->flags & I915_ENGINE_NEEDS_CMD_PARSER;
> }
>
> -static inline bool intel_engine_supports_stats(struct intel_engine_cs *engine)
> +static inline bool
> +intel_engine_supports_stats(const struct intel_engine_cs *engine)
> {
> return engine->flags & I915_ENGINE_SUPPORTS_STATS;
> }
>
> +static inline bool
> +intel_engine_has_preemption(const struct intel_engine_cs *engine)
> +{
> + return engine->flags & I915_ENGINE_HAS_PREEMPTION;
> +}
> +
> static inline void
> execlists_set_active(struct intel_engine_execlists *execlists,
> unsigned int bit)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Store preemption capability in engine->flags (rev2)
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
` (2 preceding siblings ...)
2018-04-02 16:15 ` [PATCH] " Daniele Ceraolo Spurio
@ 2018-04-03 19:22 ` Patchwork
2018-04-03 20:22 ` ✓ Fi.CI.IGT: " Patchwork
[not found] ` <20180403183537.5522-1-chris@chris-wilson.co.uk>
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-04-03 19:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Store preemption capability in engine->flags (rev2)
URL : https://patchwork.freedesktop.org/series/40982/
State : success
== Summary ==
Series 40982v2 drm/i915: Store preemption capability in engine->flags
https://patchwork.freedesktop.org/api/1.0/series/40982/revisions/2/mbox/
---- Known issues:
Test gem_exec_suspend:
Subgroup basic-s4-devices:
pass -> DMESG-WARN (fi-cfl-s3) fdo#104056
Test kms_pipe_crc_basic:
Subgroup hang-read-crc-pipe-c:
fail -> PASS (fi-skl-6700k2) fdo#103191
fdo#104056 https://bugs.freedesktop.org/show_bug.cgi?id=104056
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fi-bdw-5557u total:285 pass:264 dwarn:0 dfail:0 fail:0 skip:21 time:430s
fi-bdw-gvtdvm total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:439s
fi-blb-e6850 total:285 pass:220 dwarn:1 dfail:0 fail:0 skip:64 time:380s
fi-bsw-n3050 total:285 pass:239 dwarn:0 dfail:0 fail:0 skip:46 time:541s
fi-bwr-2160 total:285 pass:180 dwarn:0 dfail:0 fail:0 skip:105 time:297s
fi-bxt-dsi total:285 pass:255 dwarn:0 dfail:0 fail:0 skip:30 time:513s
fi-bxt-j4205 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:510s
fi-byt-j1900 total:285 pass:250 dwarn:0 dfail:0 fail:0 skip:35 time:521s
fi-byt-n2820 total:285 pass:246 dwarn:0 dfail:0 fail:0 skip:39 time:507s
fi-cfl-8700k total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:408s
fi-cfl-s3 total:285 pass:258 dwarn:1 dfail:0 fail:0 skip:26 time:558s
fi-cfl-u total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:512s
fi-cnl-y3 total:285 pass:259 dwarn:0 dfail:0 fail:0 skip:26 time:581s
fi-elk-e7500 total:285 pass:225 dwarn:1 dfail:0 fail:0 skip:59 time:417s
fi-gdg-551 total:285 pass:176 dwarn:0 dfail:0 fail:1 skip:108 time:320s
fi-glk-1 total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:538s
fi-hsw-4770 total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:404s
fi-ilk-650 total:285 pass:225 dwarn:0 dfail:0 fail:0 skip:60 time:424s
fi-ivb-3520m total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:469s
fi-ivb-3770 total:285 pass:252 dwarn:0 dfail:0 fail:0 skip:33 time:429s
fi-kbl-7500u total:285 pass:260 dwarn:1 dfail:0 fail:0 skip:24 time:472s
fi-kbl-7567u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:464s
fi-kbl-r total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:508s
fi-pnv-d510 total:285 pass:219 dwarn:1 dfail:0 fail:0 skip:65 time:672s
fi-skl-6260u total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:446s
fi-skl-6600u total:285 pass:258 dwarn:0 dfail:0 fail:0 skip:27 time:538s
fi-skl-6700k2 total:285 pass:261 dwarn:0 dfail:0 fail:0 skip:24 time:505s
fi-skl-6770hq total:285 pass:265 dwarn:0 dfail:0 fail:0 skip:20 time:503s
fi-skl-guc total:285 pass:257 dwarn:0 dfail:0 fail:0 skip:28 time:431s
fi-skl-gvtdvm total:285 pass:262 dwarn:0 dfail:0 fail:0 skip:23 time:447s
fi-snb-2520m total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:563s
fi-snb-2600 total:285 pass:245 dwarn:0 dfail:0 fail:0 skip:40 time:398s
Blacklisted hosts:
fi-cnl-psr total:285 pass:256 dwarn:3 dfail:0 fail:0 skip:26 time:530s
fi-glk-j4005 total:285 pass:256 dwarn:0 dfail:0 fail:0 skip:29 time:485s
29940f138482ff38047287ad288cea1fcf1f73b4 drm-tip: 2018y-04m-03d-13h-23m-36s UTC integration manifest
68cff338df15 drm/i915: Store preemption capability in engine->flags
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8573/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Store preemption capability in engine->flags (rev2)
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
` (3 preceding siblings ...)
2018-04-03 19:22 ` ✓ Fi.CI.BAT: success for drm/i915: Store preemption capability in engine->flags (rev2) Patchwork
@ 2018-04-03 20:22 ` Patchwork
[not found] ` <20180403183537.5522-1-chris@chris-wilson.co.uk>
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2018-04-03 20:22 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Store preemption capability in engine->flags (rev2)
URL : https://patchwork.freedesktop.org/series/40982/
State : success
== Summary ==
---- Possible new issues:
Test kms_draw_crc:
Subgroup draw-method-xrgb8888-mmap-wc-untiled:
skip -> PASS (shard-snb)
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-offscren-pri-indfb-draw-mmap-cpu:
skip -> PASS (shard-snb)
Subgroup fbc-1p-primscrn-spr-indfb-move:
skip -> PASS (shard-snb)
Subgroup fbc-stridechange:
fail -> PASS (shard-snb)
Subgroup fbcpsr-rgb565-draw-blt:
fail -> SKIP (shard-snb)
Subgroup psr-2p-scndscrn-pri-indfb-draw-render:
fail -> SKIP (shard-snb)
Subgroup psr-2p-scndscrn-spr-indfb-onoff:
fail -> SKIP (shard-snb)
Test kms_universal_plane:
Subgroup universal-plane-pipe-a-sanity:
fail -> PASS (shard-snb)
Test prime_vgem:
Subgroup basic-fence-flip:
skip -> PASS (shard-snb)
---- Known issues:
Test kms_flip:
Subgroup 2x-dpms-vs-vblank-race-interruptible:
pass -> FAIL (shard-hsw) fdo#103060
Subgroup plain-flip-fb-recreate-interruptible:
fail -> PASS (shard-hsw) fdo#100368 +1
Test kms_frontbuffer_tracking:
Subgroup fbc-rgb565-draw-mmap-wc:
fail -> PASS (shard-apl) fdo#103167 +1
Test kms_mmap_write_crc:
dmesg-warn -> PASS (shard-hsw) fdo#103286
Test kms_plane_multiple:
Subgroup atomic-pipe-a-tiling-x:
pass -> FAIL (shard-snb) fdo#103166
Test kms_sysfs_edid_timing:
warn -> PASS (shard-apl) fdo#100047
fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103286 https://bugs.freedesktop.org/show_bug.cgi?id=103286
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
shard-apl total:3498 pass:1835 dwarn:1 dfail:0 fail:7 skip:1655 time:12948s
shard-hsw total:3498 pass:1783 dwarn:1 dfail:0 fail:3 skip:1710 time:11469s
shard-snb total:3498 pass:1376 dwarn:1 dfail:0 fail:3 skip:2118 time:7096s
Blacklisted hosts:
shard-kbl total:3443 pass:1928 dwarn:1 dfail:1 fail:7 skip:1505 time:9165s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8573/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/i915: Store preemption capability in engine->flags
[not found] ` <20180403183537.5522-1-chris@chris-wilson.co.uk>
@ 2018-04-03 21:52 ` Daniele Ceraolo Spurio
2018-04-04 8:25 ` Chris Wilson
0 siblings, 1 reply; 8+ messages in thread
From: Daniele Ceraolo Spurio @ 2018-04-03 21:52 UTC (permalink / raw)
To: Chris Wilson, intel-gfx
On 03/04/18 11:35, Chris Wilson wrote:
> Let's avoid having to delve down the pointer chain to see if the i915
> device has support for preemption and store that on the engine, which
> made the decision in the first place!
>
> v2: Refactor common preemption policy between execlists/guc.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Tomasz Lis <tomasz.lis@intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Michał Winiarski <michal.winiarski@intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
<snip>
> +static inline bool
> +__execlists_need_preempt(int prio, int last)
Nitpick: this fits on a single line
Daniele
> +{
> + return prio > max(0, last);
> +}
> +
> static inline void
> execlists_set_active(struct intel_engine_execlists *execlists,
> unsigned int bit)
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2] drm/i915: Store preemption capability in engine->flags
2018-04-03 21:52 ` [PATCH v2] drm/i915: Store preemption capability in engine->flags Daniele Ceraolo Spurio
@ 2018-04-04 8:25 ` Chris Wilson
0 siblings, 0 replies; 8+ messages in thread
From: Chris Wilson @ 2018-04-04 8:25 UTC (permalink / raw)
To: Daniele Ceraolo Spurio, intel-gfx; +Cc: Tomasz
Quoting Daniele Ceraolo Spurio (2018-04-03 22:52:35)
>
>
> On 03/04/18 11:35, Chris Wilson wrote:
> > Let's avoid having to delve down the pointer chain to see if the i915
> > device has support for preemption and store that on the engine, which
> > made the decision in the first place!
> >
> > v2: Refactor common preemption policy between execlists/guc.
> >
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Tomasz Lis <tomasz.lis@intel.com>
> > Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Michał Winiarski <michal.winiarski@intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
>
> <snip>
>
> > +static inline bool
> > +__execlists_need_preempt(int prio, int last)
>
> Nitpick: this fits on a single line
Fixed up and pushed, thanks. The refactor saves me doing in a later
patch for the third user :)
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2018-04-04 8:25 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-31 10:42 [PATCH] drm/i915: Store preemption capability in engine->flags Chris Wilson
2018-03-31 11:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-03-31 11:58 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-02 16:15 ` [PATCH] " Daniele Ceraolo Spurio
2018-04-03 19:22 ` ✓ Fi.CI.BAT: success for drm/i915: Store preemption capability in engine->flags (rev2) Patchwork
2018-04-03 20:22 ` ✓ Fi.CI.IGT: " Patchwork
[not found] ` <20180403183537.5522-1-chris@chris-wilson.co.uk>
2018-04-03 21:52 ` [PATCH v2] drm/i915: Store preemption capability in engine->flags Daniele Ceraolo Spurio
2018-04-04 8:25 ` Chris Wilson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.