All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Xidong Wang <wangxidong_97@163.com>,
	"Jani Nikula" <jani.nikula@linux.intel.com>,
	"Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
	"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
	"David Airlie" <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	"Xidong Wang" <wangxidong_97@163.com>
Subject: Re: [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value
Date: Wed, 04 Apr 2018 21:54:17 +0100	[thread overview]
Message-ID: <152287525774.1494.4981557971786322487@mail.alporthouse.com> (raw)
In-Reply-To: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>

Quoting Xidong Wang (2018-04-04 08:37:54)
> In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed
> with kfree(). I think the expected paired function is kmem_cahce_free().
> 
> Signed-off-by: Xidong Wang <wangxidong_97@163.com>

Thank you for the fix; applied.
-Chris

WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	David Airlie <airlied@linux.ie>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, Xidong Wang <wangxidong_97@163.com>
Subject: Re: [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value
Date: Wed, 04 Apr 2018 21:54:17 +0100	[thread overview]
Message-ID: <152287525774.1494.4981557971786322487@mail.alporthouse.com> (raw)
In-Reply-To: <1522827474-5120-1-git-send-email-wangxidong_97@163.com>

Quoting Xidong Wang (2018-04-04 08:37:54)
> In eb_lookup_vmas(), the return value of kmem_cache_alloc() is freed
> with kfree(). I think the expected paired function is kmem_cahce_free().
> 
> Signed-off-by: Xidong Wang <wangxidong_97@163.com>

Thank you for the fix; applied.
-Chris

  parent reply	other threads:[~2018-04-04 20:54 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-04  7:37 [PATCH 1/1] drm/i915: Do not use kfree() to free kmem_cache_alloc() return value Xidong Wang
2018-04-04  7:56 ` Chris Wilson
2018-04-04  7:56   ` Chris Wilson
2018-04-04  9:38 ` [RESEND] drm/i915: Do no use kfree() to free a " Chris Wilson
2018-04-04 10:32 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-04 11:51 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-04 20:54 ` Chris Wilson [this message]
2018-04-04 20:54   ` [PATCH 1/1] drm/i915: Do not use kfree() to free " Chris Wilson
  -- strict thread matches above, loose matches on Subject: below --
2018-04-04  6:37 [PATCH 1/1] drm/i915:Do " Xidong Wang
2018-04-04  8:16 ` Jani Nikula
2018-04-04  8:16   ` Jani Nikula
2018-04-04 13:02 ` kbuild test robot
2018-04-04 13:02   ` kbuild test robot
2018-04-04 13:24 ` kbuild test robot
2018-04-04 13:24   ` kbuild test robot
2018-04-04 13:44 ` kbuild test robot
2018-04-04 13:44   ` kbuild test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=152287525774.1494.4981557971786322487@mail.alporthouse.com \
    --to=chris@chris-wilson.co.uk \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigo.vivi@intel.com \
    --cc=wangxidong_97@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.