* [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK
@ 2018-04-09 3:40 Yunlei He
2018-04-09 11:00 ` Chao Yu
2018-04-10 4:00 ` Jaegeuk Kim
0 siblings, 2 replies; 3+ messages in thread
From: Yunlei He @ 2018-04-09 3:40 UTC (permalink / raw)
To: jaegeuk, yuchao0, linux-f2fs-devel; +Cc: zhangdianfang
nat bits feature is recover default by fsck, no need to
set SBI_NEED_FSCK flag.
Signed-off-by: Yunlei He <heyunlei@huawei.com>
---
fs/f2fs/f2fs.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
index 1df7f10..0ffaefc2 100644
--- a/fs/f2fs/f2fs.h
+++ b/fs/f2fs/f2fs.h
@@ -1520,8 +1520,6 @@ static inline void disable_nat_bits(struct f2fs_sb_info *sbi, bool lock)
{
unsigned long flags;
- set_sbi_flag(sbi, SBI_NEED_FSCK);
-
if (lock)
spin_lock_irqsave(&sbi->cp_lock, flags);
__clear_ckpt_flags(F2FS_CKPT(sbi), CP_NAT_BITS_FLAG);
--
1.9.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK
2018-04-09 3:40 [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK Yunlei He
@ 2018-04-09 11:00 ` Chao Yu
2018-04-10 4:00 ` Jaegeuk Kim
1 sibling, 0 replies; 3+ messages in thread
From: Chao Yu @ 2018-04-09 11:00 UTC (permalink / raw)
To: Yunlei He, jaegeuk, linux-f2fs-devel; +Cc: zhangdianfang
On 2018/4/9 11:40, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
>
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK
2018-04-09 3:40 [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK Yunlei He
2018-04-09 11:00 ` Chao Yu
@ 2018-04-10 4:00 ` Jaegeuk Kim
1 sibling, 0 replies; 3+ messages in thread
From: Jaegeuk Kim @ 2018-04-10 4:00 UTC (permalink / raw)
To: Yunlei He; +Cc: zhangdianfang, linux-f2fs-devel
On 04/09, Yunlei He wrote:
> nat bits feature is recover default by fsck, no need to
> set SBI_NEED_FSCK flag.
>
> Signed-off-by: Yunlei He <heyunlei@huawei.com>
> ---
> fs/f2fs/f2fs.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index 1df7f10..0ffaefc2 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -1520,8 +1520,6 @@ static inline void disable_nat_bits(struct f2fs_sb_info *sbi, bool lock)
> {
> unsigned long flags;
>
> - set_sbi_flag(sbi, SBI_NEED_FSCK);
> -
In order to support old fsck.f2fs, we need to keep this.
> if (lock)
> spin_lock_irqsave(&sbi->cp_lock, flags);
> __clear_ckpt_flags(F2FS_CKPT(sbi), CP_NAT_BITS_FLAG);
> --
> 1.9.1
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-10 4:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-09 3:40 [PATCH] f2fs: disable nat bits without setting SBI_NEED_FSCK Yunlei He
2018-04-09 11:00 ` Chao Yu
2018-04-10 4:00 ` Jaegeuk Kim
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.