[igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Chris Wilson]

All too frequently, we fail our memory checks to a leak in the driver.
While we give every opportunity for the driver to release the memory
before we fail, if we do dump the meminfo and slabinfo, if available, so
we can assign blame^W^W resolve the problem quickly.

References: https://bugs.freedesktop.org/show_bug.cgi?id=105967
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Martin Peres <martin.peres@linux.intel.com>
Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
---
 lib/intel_os.c | 28 ++++++++++++++++++++++++++--
 1 file changed, 26 insertions(+), 2 deletions(-)

diff --git a/lib/intel_os.c b/lib/intel_os.c
index bb2c16bf..f0f2872b 100644
--- a/lib/intel_os.c
+++ b/lib/intel_os.c
@@ -51,6 +51,7 @@
 #include "drmtest.h"
 #include "igt_aux.h"
 #include "igt_debugfs.h"
+#include "igt_sysfs.h"
 
 /**
  * intel_get_total_ram_mb:
@@ -280,9 +281,32 @@ int __intel_check_memory(uint64_t count, uint64_t size, unsigned mode,
 void intel_require_memory(uint64_t count, uint64_t size, unsigned mode)
 {
 	uint64_t required, total;
+	bool sufficient_memory;
+
+	sufficient_memory = __intel_check_memory(count, size, mode,
+						 &required, &total);
+	if (!sufficient_memory) {
+		int dir = open("/proc", O_RDONLY);
+		char *info;
+
+		info = igt_sysfs_get(dir, "meminfo");
+		if (info) {
+			igt_debug("Insuffucient free memory; /proc/meminfo:\n%s",
+				  info);
+			free(info);
+		}
+
+		info = igt_sysfs_get(dir, "slabinfo");
+		if (info) {
+			igt_debug("Insuffucient free memory; /proc/slabinfo:\n%s",
+				  info);
+			free(info);
+		}
+
+		close(dir);
+	}
 
-	igt_require_f(__intel_check_memory(count, size, mode,
-					    &required, &total),
+	igt_require_f(sufficient_memory,
 		      "Estimated that we need %'llu objects and %'llu MiB for the test, but only have %'llu MiB available (%s%s) and a maximum of %'llu objects\n",
 		      (long long)count,
 		      (long long)((required + ((1<<20) - 1)) >> 20),
-- 
2.17.0

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Petri Latvala]

On Tue, Apr 10, 2018 at 01:20:43PM +0100, Chris Wilson wrote:
> +			igt_debug("Insuffucient free memory; /proc/meminfo:\n%s",
> +				  info);
> +			free(info);
> +		}
> +
> +		info = igt_sysfs_get(dir, "slabinfo");
> +		if (info) {
> +			igt_debug("Insuffucient free memory; /proc/slabinfo:\n%s",

Consistently used incorrect spelling.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Chris Wilson]

Quoting Petri Latvala (2018-04-10 14:08:17)
> On Tue, Apr 10, 2018 at 01:20:43PM +0100, Chris Wilson wrote:
> > +                     igt_debug("Insuffucient free memory; /proc/meminfo:\n%s",
> > +                               info);
> > +                     free(info);
> > +             }
> > +
> > +             info = igt_sysfs_get(dir, "slabinfo");
> > +             if (info) {
> > +                     igt_debug("Insuffucient free memory; /proc/slabinfo:\n%s",
> 
> Consistently used incorrect spelling.

Or maybe I was trying to subconsciously swear?
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Patchwork]

== Series Details ==

Series: lib: Dump meminfo and slabinfo if we complain about insufficient memory
URL   : https://patchwork.freedesktop.org/series/41466/
State : success

== Summary ==

IGT patchset tested on top of latest successful build
7c474e011548d35df6b80ceed81d3e6ca560c71d tests/perf: fix gen8 small cores whitelist expectation

with latest DRM-Tip kernel build CI_DRM_4040
8e7a3b1c5ebd drm-tip: 2018y-04m-10d-10h-47m-52s UTC integration manifest

No testlist changes.

---- Possible new issues:

Test gem_exec_gttfill:
        Subgroup basic:
                skip       -> PASS       (fi-pnv-d510)

---- Known issues:

Test debugfs_test:
        Subgroup read_all_entries:
                incomplete -> PASS       (fi-snb-2520m) fdo#103713

fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713

fi-bdw-5557u     total:285  pass:264  dwarn:0   dfail:0   fail:0   skip:21  time:439s
fi-bdw-gvtdvm    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:446s
fi-blb-e6850     total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:382s
fi-bsw-n3050     total:285  pass:239  dwarn:0   dfail:0   fail:0   skip:46  time:544s
fi-bwr-2160      total:285  pass:180  dwarn:0   dfail:0   fail:0   skip:105 time:299s
fi-bxt-dsi       total:285  pass:255  dwarn:0   dfail:0   fail:0   skip:30  time:518s
fi-bxt-j4205     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:514s
fi-byt-j1900     total:285  pass:250  dwarn:0   dfail:0   fail:0   skip:35  time:521s
fi-byt-n2820     total:285  pass:246  dwarn:0   dfail:0   fail:0   skip:39  time:507s
fi-cfl-8700k     total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:410s
fi-cfl-s3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:562s
fi-cfl-u         total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:515s
fi-cnl-y3        total:285  pass:259  dwarn:0   dfail:0   fail:0   skip:26  time:584s
fi-elk-e7500     total:285  pass:226  dwarn:0   dfail:0   fail:0   skip:59  time:425s
fi-gdg-551       total:285  pass:177  dwarn:0   dfail:0   fail:0   skip:108 time:317s
fi-glk-1         total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:541s
fi-glk-j4005     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:487s
fi-hsw-4770      total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:404s
fi-ilk-650       total:285  pass:225  dwarn:0   dfail:0   fail:0   skip:60  time:424s
fi-ivb-3520m     total:285  pass:256  dwarn:0   dfail:0   fail:0   skip:29  time:474s
fi-ivb-3770      total:285  pass:252  dwarn:0   dfail:0   fail:0   skip:33  time:434s
fi-kbl-7500u     total:285  pass:260  dwarn:1   dfail:0   fail:0   skip:24  time:474s
fi-kbl-7567u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:462s
fi-kbl-r         total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:510s
fi-pnv-d510      total:285  pass:220  dwarn:1   dfail:0   fail:0   skip:64  time:667s
fi-skl-6260u     total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:444s
fi-skl-6600u     total:285  pass:258  dwarn:0   dfail:0   fail:0   skip:27  time:544s
fi-skl-6700k2    total:285  pass:261  dwarn:0   dfail:0   fail:0   skip:24  time:501s
fi-skl-6770hq    total:285  pass:265  dwarn:0   dfail:0   fail:0   skip:20  time:513s
fi-skl-guc       total:285  pass:257  dwarn:0   dfail:0   fail:0   skip:28  time:427s
fi-skl-gvtdvm    total:285  pass:262  dwarn:0   dfail:0   fail:0   skip:23  time:454s
fi-snb-2520m     total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:566s
fi-snb-2600      total:285  pass:245  dwarn:0   dfail:0   fail:0   skip:40  time:405s

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Antonio Argenziano]

On 10/04/18 05:20, Chris Wilson wrote:
> All too frequently, we fail our memory checks to a leak in the driver.
> While we give every opportunity for the driver to release the memory
> before we fail, if we do dump the meminfo and slabinfo, if available, so
> we can assign blame^W^W resolve the problem quickly.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=105967
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
> Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> ---
>   lib/intel_os.c | 28 ++++++++++++++++++++++++++--
>   1 file changed, 26 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/intel_os.c b/lib/intel_os.c
> index bb2c16bf..f0f2872b 100644
> --- a/lib/intel_os.c
> +++ b/lib/intel_os.c
> @@ -51,6 +51,7 @@
>   #include "drmtest.h"
>   #include "igt_aux.h"
>   #include "igt_debugfs.h"
> +#include "igt_sysfs.h"
>   
>   /**
>    * intel_get_total_ram_mb:
> @@ -280,9 +281,32 @@ int __intel_check_memory(uint64_t count, uint64_t size, unsigned mode,
>   void intel_require_memory(uint64_t count, uint64_t size, unsigned mode)
>   {
>   	uint64_t required, total;
> +	bool sufficient_memory;
> +
> +	sufficient_memory = __intel_check_memory(count, size, mode,
> +						 &required, &total);
> +	if (!sufficient_memory) {
> +		int dir = open("/proc", O_RDONLY);

No early exit on dir < 0?

LGTM.
Reviewed-by: Antonio Argenziano <antonio.argenziano@intel.com>

Thanks,
Antonio
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.IGT: warning for lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Patchwork]

== Series Details ==

Series: lib: Dump meminfo and slabinfo if we complain about insufficient memory
URL   : https://patchwork.freedesktop.org/series/41466/
State : warning

== Summary ==

= CI Bug Log - changes from CI_DRM_4040_full -> IGTPW_1241_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1241_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1241_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce the CI noise.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1241_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-dirty-render:
      shard-kbl:          PASS -> SKIP

    igt@perf_pmu@rc6:
      shard-kbl:          SKIP -> PASS +1

    igt@pm_rc6_residency@rc6-accuracy:
      shard-snb:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1241_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@dpms-vs-vblank-race:
      shard-hsw:          PASS -> DMESG-FAIL (fdo#103060)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@2x-long-flip-vs-cursor-legacy:
      shard-hsw:          FAIL (fdo#104873) -> PASS

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-hsw:          FAIL (fdo#105189) -> PASS

    
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#104873 https://bugs.freedesktop.org/show_bug.cgi?id=104873
  fdo#105189 https://bugs.freedesktop.org/show_bug.cgi?id=105189


== Participating hosts (6 -> 4) ==

  Missing    (2): shard-glk shard-glkb 


== Build changes ==

    * IGT: IGT_4418 -> IGTPW_1241

  CI_DRM_4040: 8e7a3b1c5ebd06c5740b0fea76f46ff23d373bd5 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1241: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/
  IGT_4418: 7c474e011548d35df6b80ceed81d3e6ca560c71d @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4418: 45e115f293fd6acc0c9647cf2d3b76be78819ba5 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH igt] lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Chris Wilson]

Quoting Antonio Argenziano (2018-04-10 17:00:52)
> 
> 
> On 10/04/18 05:20, Chris Wilson wrote:
> > All too frequently, we fail our memory checks to a leak in the driver.
> > While we give every opportunity for the driver to release the memory
> > before we fail, if we do dump the meminfo and slabinfo, if available, so
> > we can assign blame^W^W resolve the problem quickly.
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=105967
> > Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Martin Peres <martin.peres@linux.intel.com>
> > Cc: Tomi Sarvela <tomi.p.sarvela@intel.com>
> > ---
> >   lib/intel_os.c | 28 ++++++++++++++++++++++++++--
> >   1 file changed, 26 insertions(+), 2 deletions(-)
> > 
> > diff --git a/lib/intel_os.c b/lib/intel_os.c
> > index bb2c16bf..f0f2872b 100644
> > --- a/lib/intel_os.c
> > +++ b/lib/intel_os.c
> > @@ -51,6 +51,7 @@
> >   #include "drmtest.h"
> >   #include "igt_aux.h"
> >   #include "igt_debugfs.h"
> > +#include "igt_sysfs.h"
> >   
> >   /**
> >    * intel_get_total_ram_mb:
> > @@ -280,9 +281,32 @@ int __intel_check_memory(uint64_t count, uint64_t size, unsigned mode,
> >   void intel_require_memory(uint64_t count, uint64_t size, unsigned mode)
> >   {
> >       uint64_t required, total;
> > +     bool sufficient_memory;
> > +
> > +     sufficient_memory = __intel_check_memory(count, size, mode,
> > +                                              &required, &total);
> > +     if (!sufficient_memory) {
> > +             int dir = open("/proc", O_RDONLY);
> 
> No early exit on dir < 0?

It falls through returning info = NULL and a no-op on close(-1).
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: warning for lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Chris Wilson]

Quoting Patchwork (2018-04-10 17:19:24)
> == Series Details ==
> 
> Series: lib: Dump meminfo and slabinfo if we complain about insufficient memory
> URL   : https://patchwork.freedesktop.org/series/41466/
> State : warning
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_4040_full -> IGTPW_1241_full =
> 
> == Summary - WARNING ==
> 
>   Minor unknown changes coming with IGTPW_1241_full need to be verified
>   manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_1241_full, please notify your bug team to allow them
>   to document this new failure mode, which will reduce the CI noise.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in IGTPW_1241_full:
> 
>   === IGT changes ===
> 
>     ==== Warnings ====
> 
>     igt@gem_mocs_settings@mocs-rc6-dirty-render:
>       shard-kbl:          PASS -> SKIP
> 
>     igt@perf_pmu@rc6:
>       shard-kbl:          SKIP -> PASS +1
> 
>     igt@pm_rc6_residency@rc6-accuracy:
>       shard-snb:          SKIP -> PASS

The good news is that it didn't explode for the tests it had to skipped.
Fixed up the spelling mistake and pushed, thanks.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: warning for lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Petri Latvala]

On Tue, Apr 10, 2018 at 10:12:13PM +0100, Chris Wilson wrote:
> Quoting Patchwork (2018-04-10 17:19:24)
> > == Series Details ==
> > 
> > Series: lib: Dump meminfo and slabinfo if we complain about insufficient memory
> > URL   : https://patchwork.freedesktop.org/series/41466/
> > State : warning
> > 
> > == Summary ==
> > 
> > = CI Bug Log - changes from CI_DRM_4040_full -> IGTPW_1241_full =
> > 
> > == Summary - WARNING ==
> > 
> >   Minor unknown changes coming with IGTPW_1241_full need to be verified
> >   manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in IGTPW_1241_full, please notify your bug team to allow them
> >   to document this new failure mode, which will reduce the CI noise.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/
> > 
> > == Possible new issues ==
> > 
> >   Here are the unknown changes that may have been introduced in IGTPW_1241_full:
> > 
> >   === IGT changes ===
> > 
> >     ==== Warnings ====
> > 
> >     igt@gem_mocs_settings@mocs-rc6-dirty-render:
> >       shard-kbl:          PASS -> SKIP
> > 
> >     igt@perf_pmu@rc6:
> >       shard-kbl:          SKIP -> PASS +1
> > 
> >     igt@pm_rc6_residency@rc6-accuracy:
> >       shard-snb:          SKIP -> PASS
> 
> The good news is that it didn't explode for the tests it had to skipped.
> Fixed up the spelling mistake and pushed, thanks.

Only one of the spelling mistakes though :P


-- 
Petri Latvala



> -Chris
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.IGT: warning for lib: Dump meminfo and slabinfo if we complain about insufficient memory

[Chris Wilson]

Quoting Petri Latvala (2018-04-11 09:46:15)
> On Tue, Apr 10, 2018 at 10:12:13PM +0100, Chris Wilson wrote:
> > Quoting Patchwork (2018-04-10 17:19:24)
> > > == Series Details ==
> > > 
> > > Series: lib: Dump meminfo and slabinfo if we complain about insufficient memory
> > > URL   : https://patchwork.freedesktop.org/series/41466/
> > > State : warning
> > > 
> > > == Summary ==
> > > 
> > > = CI Bug Log - changes from CI_DRM_4040_full -> IGTPW_1241_full =
> > > 
> > > == Summary - WARNING ==
> > > 
> > >   Minor unknown changes coming with IGTPW_1241_full need to be verified
> > >   manually.
> > >   
> > >   If you think the reported changes have nothing to do with the changes
> > >   introduced in IGTPW_1241_full, please notify your bug team to allow them
> > >   to document this new failure mode, which will reduce the CI noise.
> > > 
> > >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1241/
> > > 
> > > == Possible new issues ==
> > > 
> > >   Here are the unknown changes that may have been introduced in IGTPW_1241_full:
> > > 
> > >   === IGT changes ===
> > > 
> > >     ==== Warnings ====
> > > 
> > >     igt@gem_mocs_settings@mocs-rc6-dirty-render:
> > >       shard-kbl:          PASS -> SKIP
> > > 
> > >     igt@perf_pmu@rc6:
> > >       shard-kbl:          SKIP -> PASS +1
> > > 
> > >     igt@pm_rc6_residency@rc6-accuracy:
> > >       shard-snb:          SKIP -> PASS
> > 
> > The good news is that it didn't explode for the tests it had to skipped.
> > Fixed up the spelling mistake and pushed, thanks.
> 
> Only one of the spelling mistakes though :P

Damn it. I thought I changed both. A fun distraction for whoever first
spots the mistake in the output.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev