* [U-Boot] [PATCH] reset: fix bulk API when DM_RESET is disabled
@ 2018-04-12 8:03 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2018-04-12 8:03 UTC (permalink / raw)
To: u-boot
In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
the disabled reset_release_bulk() and reset_get_bulk() used the wrong
struct clk_bulk instead of struct reset_ctl_bulk.
Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
include/reset.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/reset.h b/include/reset.h
index d38f176..ae247ce 100644
--- a/include/reset.h
+++ b/include/reset.h
@@ -243,7 +243,8 @@ static inline int reset_get_by_index(struct udevice *dev, int index,
return -ENOTSUPP;
}
-static inline int reset_get_bulk(struct udevice *dev, struct clk_bulk *bulk)
+static inline int reset_get_bulk(struct udevice *dev,
+ struct reset_ctl_bulk *bulk)
{
return -ENOTSUPP;
}
@@ -284,7 +285,7 @@ static inline int reset_release_all(struct reset_ctl *reset_ctl, int count)
return 0;
}
-static inline int reset_release_bulk(struct clk_bulk *bulk)
+static inline int reset_release_bulk(struct reset_ctl_bulk *bulk)
{
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] reset: fix bulk API when DM_RESET is disabled
@ 2018-04-12 8:03 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2018-04-12 8:03 UTC (permalink / raw)
To: linus-amlogic
In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
the disabled reset_release_bulk() and reset_get_bulk() used the wrong
struct clk_bulk instead of struct reset_ctl_bulk.
Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
include/reset.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/include/reset.h b/include/reset.h
index d38f176..ae247ce 100644
--- a/include/reset.h
+++ b/include/reset.h
@@ -243,7 +243,8 @@ static inline int reset_get_by_index(struct udevice *dev, int index,
return -ENOTSUPP;
}
-static inline int reset_get_bulk(struct udevice *dev, struct clk_bulk *bulk)
+static inline int reset_get_bulk(struct udevice *dev,
+ struct reset_ctl_bulk *bulk)
{
return -ENOTSUPP;
}
@@ -284,7 +285,7 @@ static inline int reset_release_all(struct reset_ctl *reset_ctl, int count)
return 0;
}
-static inline int reset_release_bulk(struct clk_bulk *bulk)
+static inline int reset_release_bulk(struct reset_ctl_bulk *bulk)
{
return 0;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] reset: fix bulk API when DM_RESET is disabled
2018-04-12 8:03 ` Neil Armstrong
@ 2018-04-12 16:41 ` Simon Glass
-1 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2018-04-12 16:41 UTC (permalink / raw)
To: u-boot
On 12 April 2018 at 02:03, Neil Armstrong <narmstrong@baylibre.com> wrote:
> In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
> the disabled reset_release_bulk() and reset_get_bulk() used the wrong
> struct clk_bulk instead of struct reset_ctl_bulk.
>
> Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> include/reset.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
We don't have build coverage for this at the moment I suppose. It
would be a bit of pain to add that with sandbox, although I wonder if
it could be done with some horrible #define hackery in a C file that
includes this header?
- Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] reset: fix bulk API when DM_RESET is disabled
@ 2018-04-12 16:41 ` Simon Glass
0 siblings, 0 replies; 6+ messages in thread
From: Simon Glass @ 2018-04-12 16:41 UTC (permalink / raw)
To: linus-amlogic
On 12 April 2018 at 02:03, Neil Armstrong <narmstrong@baylibre.com> wrote:
> In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
> the disabled reset_release_bulk() and reset_get_bulk() used the wrong
> struct clk_bulk instead of struct reset_ctl_bulk.
>
> Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
> include/reset.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Simon Glass <sjg@chromium.org>
We don't have build coverage for this at the moment I suppose. It
would be a bit of pain to add that with sandbox, although I wonder if
it could be done with some horrible #define hackery in a C file that
includes this header?
- Simon
^ permalink raw reply [flat|nested] 6+ messages in thread
* [U-Boot] [PATCH] reset: fix bulk API when DM_RESET is disabled
2018-04-12 16:41 ` Simon Glass
@ 2018-04-17 7:34 ` Neil Armstrong
-1 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2018-04-17 7:34 UTC (permalink / raw)
To: u-boot
On 12/04/2018 18:41, Simon Glass wrote:
> On 12 April 2018 at 02:03, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
>> the disabled reset_release_bulk() and reset_get_bulk() used the wrong
>> struct clk_bulk instead of struct reset_ctl_bulk.
>>
>> Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
>> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> include/reset.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> We don't have build coverage for this at the moment I suppose. It
> would be a bit of pain to add that with sandbox, although I wonder if
> it could be done with some horrible #define hackery in a C file that
> includes this header?
>
> - Simon
>
It could but it will be horrible indeed.
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] reset: fix bulk API when DM_RESET is disabled
@ 2018-04-17 7:34 ` Neil Armstrong
0 siblings, 0 replies; 6+ messages in thread
From: Neil Armstrong @ 2018-04-17 7:34 UTC (permalink / raw)
To: linus-amlogic
On 12/04/2018 18:41, Simon Glass wrote:
> On 12 April 2018 at 02:03, Neil Armstrong <narmstrong@baylibre.com> wrote:
>> In the commit "reset: Add get/assert/deassert/release for bulk of reset signals"
>> the disabled reset_release_bulk() and reset_get_bulk() used the wrong
>> struct clk_bulk instead of struct reset_ctl_bulk.
>>
>> Fixes: 0c28233903b5 ("reset: Add get/assert/deassert/release for bulk of reset signals")
>> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> ---
>> include/reset.h | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Reviewed-by: Simon Glass <sjg@chromium.org>
>
> We don't have build coverage for this at the moment I suppose. It
> would be a bit of pain to add that with sandbox, although I wonder if
> it could be done with some horrible #define hackery in a C file that
> includes this header?
>
> - Simon
>
It could but it will be horrible indeed.
Neil
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-17 7:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 8:03 [U-Boot] [PATCH] reset: fix bulk API when DM_RESET is disabled Neil Armstrong
2018-04-12 8:03 ` Neil Armstrong
2018-04-12 16:41 ` [U-Boot] " Simon Glass
2018-04-12 16:41 ` Simon Glass
2018-04-17 7:34 ` [U-Boot] " Neil Armstrong
2018-04-17 7:34 ` Neil Armstrong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.