* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
@ 2018-04-16 16:11 Mark Jonas
2018-04-17 3:58 ` Heiko Schocher
0 siblings, 1 reply; 7+ messages in thread
From: Mark Jonas @ 2018-04-16 16:11 UTC (permalink / raw)
To: u-boot
For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
Only the i.MX6 SoloLite is an exemption. So far the code did not
consider that. Additionally, for a few i.MX6 processors the code used
the wrong value for the constant.
This patch fixes the PAD_CTL_SPEED_LOW constant for:
- i.MX6 Solo [1]
- i.MX6 DualLite [1]
- i.MX6 Dual [2]
- i.MX6 Quad [2]
- i.MX6 DualPlus [3]
- i.MX6 QuadPlus [3]
Before, it was already correct for:
- i.MX6 SoloLite [4]
- i.MX6 SoloX [5]
- i.MX6 UtraLite [6]
- i.MX6 ULL [7]
[1] https://www.nxp.com/docs/en/reference-manual/IMX6SDLRM.pdf
[2] https://www.nxp.com/docs/en/reference-manual/IMX6DQRM.pdf
[3] https://www.nxp.com/docs/en/reference-manual/iMX6DQPRM.pdf
[4] https://www.nxp.com/docs/en/reference-manual/IMX6SLRM.pdf
[5] https://www.nxp.com/docs/en/reference-manual/IMX6SXRM.pdf
[6] https://www.nxp.com/docs/en/reference-manual/IMX6ULRM.pdf
[7] https://www.nxp.com/docs/en/reference-manual/IMX6ULLRM.pdf
Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
---
arch/arm/include/asm/mach-imx/iomux-v3.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/include/asm/mach-imx/iomux-v3.h b/arch/arm/include/asm/mach-imx/iomux-v3.h
index 0c0ccf44..09094c9 100644
--- a/arch/arm/include/asm/mach-imx/iomux-v3.h
+++ b/arch/arm/include/asm/mach-imx/iomux-v3.h
@@ -147,10 +147,10 @@ typedef u64 iomux_v3_cfg_t;
#define PAD_CTL_ODE (1 << 11)
-#if defined(CONFIG_MX6SX) || defined(CONFIG_MX6UL) || defined(CONFIG_MX6ULL)
-#define PAD_CTL_SPEED_LOW (0 << 6)
-#else
+#if defined(CONFIG_MX6SL)
#define PAD_CTL_SPEED_LOW (1 << 6)
+#else
+#define PAD_CTL_SPEED_LOW (0 << 6)
#endif
#define PAD_CTL_SPEED_MED (2 << 6)
#define PAD_CTL_SPEED_HIGH (3 << 6)
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-16 16:11 [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant Mark Jonas
@ 2018-04-17 3:58 ` Heiko Schocher
2018-04-26 6:44 ` Jonas Mark
0 siblings, 1 reply; 7+ messages in thread
From: Heiko Schocher @ 2018-04-17 3:58 UTC (permalink / raw)
To: u-boot
Hello Mark,
Am 16.04.2018 um 18:11 schrieb Mark Jonas:
> For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
> Only the i.MX6 SoloLite is an exemption. So far the code did not
> consider that. Additionally, for a few i.MX6 processors the code used
> the wrong value for the constant.
>
> This patch fixes the PAD_CTL_SPEED_LOW constant for:
> - i.MX6 Solo [1]
> - i.MX6 DualLite [1]
> - i.MX6 Dual [2]
> - i.MX6 Quad [2]
> - i.MX6 DualPlus [3]
> - i.MX6 QuadPlus [3]
>
> Before, it was already correct for:
> - i.MX6 SoloLite [4]
> - i.MX6 SoloX [5]
> - i.MX6 UtraLite [6]
> - i.MX6 ULL [7]
>
> [1] https://www.nxp.com/docs/en/reference-manual/IMX6SDLRM.pdf
> [2] https://www.nxp.com/docs/en/reference-manual/IMX6DQRM.pdf
> [3] https://www.nxp.com/docs/en/reference-manual/iMX6DQPRM.pdf
> [4] https://www.nxp.com/docs/en/reference-manual/IMX6SLRM.pdf
> [5] https://www.nxp.com/docs/en/reference-manual/IMX6SXRM.pdf
> [6] https://www.nxp.com/docs/en/reference-manual/IMX6ULRM.pdf
> [7] https://www.nxp.com/docs/en/reference-manual/IMX6ULLRM.pdf
>
> Signed-off-by: Mark Jonas <mark.jonas@de.bosch.com>
> ---
> arch/arm/include/asm/mach-imx/iomux-v3.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Good catch, thanks!
Reviewed-by: Heiko Schocher <hs@denx.de>
bye,
Heiko
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-17 3:58 ` Heiko Schocher
@ 2018-04-26 6:44 ` Jonas Mark
2018-04-26 6:47 ` Stefano Babic
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Jonas Mark @ 2018-04-26 6:44 UTC (permalink / raw)
To: u-boot
Hello,
> > For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
> > Only the i.MX6 SoloLite is an exemption. So far the code did not
> > consider that. Additionally, for a few i.MX6 processors the code used
> > the wrong value for the constant.
[..]
> Good catch, thanks!
>
> Reviewed-by: Heiko Schocher <hs@denx.de>
I am wondering how this will continue now. Is there anything I still
have to do?
Regards,
Mark
Building Technologies, Panel Software Fire (BT-FIR/ENG1)
Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com
Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Gert van Iperen, Andreas Bartz, Thomas Quante, Bernhard Schuster
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-26 6:44 ` Jonas Mark
@ 2018-04-26 6:47 ` Stefano Babic
2018-04-26 6:50 ` Heiko Schocher
2018-04-27 8:47 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2018-04-26 6:47 UTC (permalink / raw)
To: u-boot
On 26/04/2018 08:44, Jonas Mark (BT-FIR/ENG1) wrote:
> Hello,
>
>>> For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
>>> Only the i.MX6 SoloLite is an exemption. So far the code did not
>>> consider that. Additionally, for a few i.MX6 processors the code used
>>> the wrong value for the constant.
>
> [..]
>
>> Good catch, thanks!
>>
>> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> I am wondering how this will continue now. Is there anything I still
> have to do?
You have not - I am quite busy and I know I have a long list of patches
to apply. Please wait, I will take care of it in next days.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-26 6:44 ` Jonas Mark
2018-04-26 6:47 ` Stefano Babic
@ 2018-04-26 6:50 ` Heiko Schocher
2018-04-26 7:08 ` Stefano Babic
2018-04-27 8:47 ` Stefano Babic
2 siblings, 1 reply; 7+ messages in thread
From: Heiko Schocher @ 2018-04-26 6:50 UTC (permalink / raw)
To: u-boot
Hello Mark,
Am 26.04.2018 um 08:44 schrieb Jonas Mark (BT-FIR/ENG1):
> Hello,
>
>>> For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
>>> Only the i.MX6 SoloLite is an exemption. So far the code did not
>>> consider that. Additionally, for a few i.MX6 processors the code used
>>> the wrong value for the constant.
>
> [..]
>
>> Good catch, thanks!
>>
>> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> I am wondering how this will continue now. Is there anything I still
> have to do?
No, just wait until Stefano has time to comment or pick up the patch.
bye,
Heiko
>
> Regards,
> Mark
>
> Building Technologies, Panel Software Fire (BT-FIR/ENG1)
> Bosch Sicherheitssysteme GmbH | Postfach 11 11 | 85626 Grasbrunn | GERMANY | www.boschsecurity.com
>
> Sitz: Stuttgart, Registergericht: Amtsgericht Stuttgart HRB 23118
> Aufsichtsratsvorsitzender: Stefan Hartung; Geschäftsführung: Gert van Iperen, Andreas Bartz, Thomas Quante, Bernhard Schuster
>
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52 Fax: +49-8142-66989-80 Email: hs at denx.de
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-26 6:50 ` Heiko Schocher
@ 2018-04-26 7:08 ` Stefano Babic
0 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2018-04-26 7:08 UTC (permalink / raw)
To: u-boot
On 26/04/2018 08:50, Heiko Schocher wrote:
> Hello Mark,
>
> Am 26.04.2018 um 08:44 schrieb Jonas Mark (BT-FIR/ENG1):
>> Hello,
>>
>>>> For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
>>>> Only the i.MX6 SoloLite is an exemption. So far the code did not
>>>> consider that. Additionally, for a few i.MX6 processors the code used
>>>> the wrong value for the constant.
>>
>> [..]
>>
>>> Good catch, thanks!
>>>
>>> Reviewed-by: Heiko Schocher <hs@denx.de>
>>
>> I am wondering how this will continue now. Is there anything I still
>> have to do?
>
> No, just wait until Stefano has time to comment or pick up the patch.
>
The second you said :-). I have already applied most of patches
delegated to me, but I have still to run full build and check the rest
of patches before pushing to server.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
* [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant
2018-04-26 6:44 ` Jonas Mark
2018-04-26 6:47 ` Stefano Babic
2018-04-26 6:50 ` Heiko Schocher
@ 2018-04-27 8:47 ` Stefano Babic
2 siblings, 0 replies; 7+ messages in thread
From: Stefano Babic @ 2018-04-27 8:47 UTC (permalink / raw)
To: u-boot
On 26/04/2018 08:44, Jonas Mark (BT-FIR/ENG1) wrote:
> Hello,
>
>>> For most i.MX6 processors the PAD_CTL_SPEED_LOW constant is the same.
>>> Only the i.MX6 SoloLite is an exemption. So far the code did not
>>> consider that. Additionally, for a few i.MX6 processors the code used
>>> the wrong value for the constant.
>
> [..]
>
>> Good catch, thanks!
>>
>> Reviewed-by: Heiko Schocher <hs@denx.de>
>
> I am wondering how this will continue now. Is there anything I still
> have to do?
>
I did my homework:
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-04-27 8:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-16 16:11 [U-Boot] [PATCH] arm,imx6: fix PAD_CTL_SPEED_LOW constant Mark Jonas
2018-04-17 3:58 ` Heiko Schocher
2018-04-26 6:44 ` Jonas Mark
2018-04-26 6:47 ` Stefano Babic
2018-04-26 6:50 ` Heiko Schocher
2018-04-26 7:08 ` Stefano Babic
2018-04-27 8:47 ` Stefano Babic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.