[Fuego] [PATCH] ftc: create log folder to avoid errors on run-test

[Fuego] [PATCH] ftc: create log folder to avoid errors on run-test

[Daniel Sangorrin]

Calling ftc run-test resulted in the following error:

$ ftc run-test -b raspi3 -t Benchmark.iperf3 -s udp
Notice: non-Jenkins test request detected
Running test 'Benchmark.iperf3' on board 'raspi3' using spec 'udp'
Warning: no matching Jenkins job found.  Not populating Jenkins build directory
!!! >>> Ready to run test! <<< !!!
Traceback (most recent call last):
  File "/usr/local/bin/ftc", line 4305, in <module>
    main()
  File "/usr/local/bin/ftc", line 4265, in main
    do_run_test(conf, options)
  File "/usr/local/bin/ftc", line 3157, in do_run_test
    build_number = find_next_build_number_by_log_scan(logs_dir)
  File "/usr/local/bin/ftc", line 2611, in find_next_build_number_by_log_scan
    entries = os.listdir(logs_dir)
OSError: [Errno 2] No such file or directory: '/fuego-rw/logs/Benchmark.iperf3'

Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
---
 engine/scripts/ftc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/engine/scripts/ftc b/engine/scripts/ftc
index 6910798..9be2595 100755
--- a/engine/scripts/ftc
+++ b/engine/scripts/ftc
@@ -3154,6 +3154,8 @@ def do_run_test(conf, options):
             print "Error: problem writing to file %s" % filename
     else:
         logs_dir = conf.FUEGO_RW + "/logs/%s" % test_name
+        if not os.path.isdir(logs_dir):
+             os.mkdir(logs_dir)
         build_number = find_next_build_number_by_log_scan(logs_dir)
 
     build_data.build_number = build_number
-- 
2.7.4

Re: [Fuego] [PATCH] ftc: create log folder to avoid errors on run-test

[Tim.Bird]

> -----Original Message-----
> From: Daniel Sangorrin
> 
> Calling ftc run-test resulted in the following error:
> 
> $ ftc run-test -b raspi3 -t Benchmark.iperf3 -s udp
> Notice: non-Jenkins test request detected
> Running test 'Benchmark.iperf3' on board 'raspi3' using spec 'udp'
> Warning: no matching Jenkins job found.  Not populating Jenkins build
> directory
> !!! >>> Ready to run test! <<< !!!
> Traceback (most recent call last):
>   File "/usr/local/bin/ftc", line 4305, in <module>
>     main()
>   File "/usr/local/bin/ftc", line 4265, in main
>     do_run_test(conf, options)
>   File "/usr/local/bin/ftc", line 3157, in do_run_test
>     build_number = find_next_build_number_by_log_scan(logs_dir)
>   File "/usr/local/bin/ftc", line 2611, in find_next_build_number_by_log_scan
>     entries = os.listdir(logs_dir)
> OSError: [Errno 2] No such file or directory: '/fuego-
> rw/logs/Benchmark.iperf3'
> 
> Signed-off-by: Daniel Sangorrin <daniel.sangorrin@toshiba.co.jp>
> ---
>  engine/scripts/ftc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/engine/scripts/ftc b/engine/scripts/ftc
> index 6910798..9be2595 100755
> --- a/engine/scripts/ftc
> +++ b/engine/scripts/ftc
> @@ -3154,6 +3154,8 @@ def do_run_test(conf, options):
>              print "Error: problem writing to file %s" % filename
>      else:
>          logs_dir = conf.FUEGO_RW + "/logs/%s" % test_name
> +        if not os.path.isdir(logs_dir):
> +             os.mkdir(logs_dir)
>          build_number = find_next_build_number_by_log_scan(logs_dir)
> 
>      build_data.build_number = build_number
> --
> 2.7.4

Nice bugfix.  Thanks!

Applied and pushed.

BTW - this patch wasn't in your bitbucket repo.  I got it from the mail list,
but it's a little easier for me if it's in your online repo.
 
 -- Tim