[PATCH] devtools: improve kernel script execution check

[PATCH] devtools: improve kernel script execution check

[Juhamatti Kuusisaari]

Handle properly a case where DPDK_PATCH_PATH is set
to point to a directory.

Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
---
 devtools/checkpatches.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 7676a6b..2bb5458 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -75,7 +75,7 @@ while getopts hn:qv ARG ; do
 done
 shift $(($OPTIND - 1))
 
-if [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
+if [ ! -f "$DPDK_CHECKPATCH_PATH" ] || [ ! -x "$DPDK_CHECKPATCH_PATH" ] ; then
 	print_usage >&2
 	echo
 	echo 'Cannot execute DPDK_CHECKPATCH_PATH' >&2
-- 
2.8.1

Re: [PATCH] devtools: improve kernel script execution check

[Ferruh Yigit]

On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> Handle properly a case where DPDK_PATCH_PATH is set
> to point to a directory.
> 
> Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [PATCH] devtools: improve kernel script execution check

[Thomas Monjalon]

18/04/2018 15:30, Ferruh Yigit:
> On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> > Handle properly a case where DPDK_PATCH_PATH is set
> > to point to a directory.
> > 
> > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Funny bug, I didn't thought that "test -x" is positive for directories.
It makes sense.

Applied, thanks

Re: [PATCH] devtools: improve kernel script execution check

[Thomas Monjalon]

18/04/2018 16:06, Thomas Monjalon:
> 18/04/2018 15:30, Ferruh Yigit:
> > On 4/18/2018 1:21 PM, Juhamatti Kuusisaari wrote:
> > > Handle properly a case where DPDK_PATCH_PATH is set
> > > to point to a directory.
> > > 
> > > Signed-off-by: Juhamatti Kuusisaari <juhamatti.kuusisaari@coriant.com>
> > 
> > Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
> Funny bug, I didn't thought that "test -x" is positive for directories.
> It makes sense.
> 
> Applied, thanks

No, sorry, not applied yet.

Please, could you send a v2 fixing devtools/get-maintainer.sh too?

Thanks