[PATCH 1/2] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

[PATCH 1/2] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

[Hui Wang]

Otherwise, the pin will be regarded as microphone, and the jack name
is "Mic Phantom", it is always on in the pulseaudio even nothing is
plugged into the jack. So the UI is confusing to users since the
microphone always shows up in the UI even there is no microphone
plugged.

After adding this flag, the jack name is "Headset Mic Phantom", then
the pulseaudio can handle its detection correctly.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index aef1f52..c3b63b7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6370,6 +6370,8 @@ static const struct hda_fixup alc269_fixups[] = {
 			{ 0x19, 0x01a1913c }, /* use as headset mic, without its own jack detect */
 			{ }
 		},
+		.chained = true,
+		.chain_id = ALC269_FIXUP_HEADSET_MIC
 	},
 };
 
-- 
2.7.4

[PATCH 2/2] ALSA: hda/realtek - adjust the location of one mic

[Hui Wang]

There are two front mics on this machine, if we don't adjust the
location for one of them, they will have the same mixer name,
pulseaudio can't handle this situation.

After applying this FIXUP, they will have different mixer name,
then pulseaudio can handle them correctly.

Cc: <stable@vger.kernel.org>
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index c3b63b7..fc77bf7 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -6575,6 +6575,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
 	SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
 	SND_PCI_QUIRK(0x17aa, 0x310c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
+	SND_PCI_QUIRK(0x17aa, 0x3138, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x313c, "ThinkCentre Station", ALC294_FIXUP_LENOVO_MIC_LOCATION),
 	SND_PCI_QUIRK(0x17aa, 0x3112, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
 	SND_PCI_QUIRK(0x17aa, 0x3902, "Lenovo E50-80", ALC269_FIXUP_DMIC_THINKPAD_ACPI),
-- 
2.7.4

Re: [PATCH 1/2] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

[Takashi Iwai]

On Thu, 19 Apr 2018 07:29:04 +0200,
Hui Wang wrote:
> 
> Otherwise, the pin will be regarded as microphone, and the jack name
> is "Mic Phantom", it is always on in the pulseaudio even nothing is
> plugged into the jack. So the UI is confusing to users since the
> microphone always shows up in the UI even there is no microphone
> plugged.
> 
> After adding this flag, the jack name is "Headset Mic Phantom", then
> the pulseaudio can handle its detection correctly.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Applied now.
But at the next time, please put "Fixes:" tag pointing to the commit
that introduced the problem.  In this case, it was f0ba9d699e5c.


thanks,

Takashi

Re: [PATCH 2/2] ALSA: hda/realtek - adjust the location of one mic

[Takashi Iwai]

On Thu, 19 Apr 2018 07:29:05 +0200,
Hui Wang wrote:
> 
> There are two front mics on this machine, if we don't adjust the
> location for one of them, they will have the same mixer name,
> pulseaudio can't handle this situation.
> 
> After applying this FIXUP, they will have different mixer name,
> then pulseaudio can handle them correctly.
> 
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Hui Wang <hui.wang@canonical.com>

Applied, thanks.


Takashi

Re: [alsa-devel] [PATCH 1/2] ALSA: hda/realtek - set PINCFG_HEADSET_MIC to parse_flags

[Hui Wang]

On 2018年04月19日 17:46, Takashi Iwai wrote:
> On Thu, 19 Apr 2018 07:29:04 +0200,
> Hui Wang wrote:
>> Otherwise, the pin will be regarded as microphone, and the jack name
>> is "Mic Phantom", it is always on in the pulseaudio even nothing is
>> plugged into the jack. So the UI is confusing to users since the
>> microphone always shows up in the UI even there is no microphone
>> plugged.
>>
>> After adding this flag, the jack name is "Headset Mic Phantom", then
>> the pulseaudio can handle its detection correctly.
>>
>> Cc: <stable@vger.kernel.org>
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> Applied now.
> But at the next time, please put "Fixes:" tag pointing to the commit
> that introduced the problem.  In this case, it was f0ba9d699e5c.
Got it. Thanks.

>
> thanks,
>
> Takashi
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>