All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post
Date: Thu, 19 Apr 2018 17:45:05 +0100	[thread overview]
Message-ID: <1524156319-11465-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com>

This is called just before os_setup_post.  Currently none of the
accelerators provide this hook, but the Xen one is going to provide
one in a moment.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
v7: New patch in this version of the series
---
 accel/accel.c          | 9 +++++++++
 include/sysemu/accel.h | 3 +++
 vl.c                   | 1 +
 3 files changed, 13 insertions(+)

diff --git a/accel/accel.c b/accel/accel.c
index 93e2434..9cfab11 100644
--- a/accel/accel.c
+++ b/accel/accel.c
@@ -126,6 +126,15 @@ void accel_register_compat_props(AccelState *accel)
     register_compat_props_array(class->global_props);
 }
 
+void accel_setup_post(MachineState *ms)
+{
+    AccelState *accel = ms->accelerator;
+    AccelClass *acc = ACCEL_GET_CLASS(accel);
+    if (acc->setup_post) {
+        acc->setup_post(ms, accel);
+    }
+}
+
 static void register_accel_types(void)
 {
     type_register_static(&accel_type);
diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
index 5a632ce..637358f 100644
--- a/include/sysemu/accel.h
+++ b/include/sysemu/accel.h
@@ -40,6 +40,7 @@ typedef struct AccelClass {
     const char *name;
     int (*available)(void);
     int (*init_machine)(MachineState *ms);
+    void (*setup_post)(MachineState *ms, AccelState *accel);
     bool *allowed;
     /*
      * Array of global properties that would be applied when specific
@@ -68,5 +69,7 @@ extern unsigned long tcg_tb_size;
 void configure_accelerator(MachineState *ms);
 /* Register accelerator specific global properties */
 void accel_register_compat_props(AccelState *accel);
+/* Called just before os_setup_post (ie just before drop OS privs) */
+void accel_setup_post(MachineState *ms);
 
 #endif
diff --git a/vl.c b/vl.c
index fce1fd1..36c5bd4 100644
--- a/vl.c
+++ b/vl.c
@@ -4729,6 +4729,7 @@ int main(int argc, char **argv, char **envp)
         vm_start();
     }
 
+    accel_setup_post(current_machine);
     os_setup_post();
 
     main_loop();
-- 
2.1.4

WARNING: multiple messages have this Message-ID (diff)
From: Ian Jackson <ian.jackson@eu.citrix.com>
To: qemu-devel@nongnu.org
Cc: Juergen Gross <jgross@suse.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	Ian Jackson <Ian.Jackson@eu.citrix.com>,
	Ross Lagerwall <ross.lagerwall@citrix.com>,
	Anthony PERARD <anthony.perard@citrix.com>,
	xen-devel@lists.xenproject.org
Subject: [PATCH 02/16] AccelClass: Introduce accel_setup_post
Date: Thu, 19 Apr 2018 17:45:05 +0100	[thread overview]
Message-ID: <1524156319-11465-3-git-send-email-ian.jackson@eu.citrix.com> (raw)
In-Reply-To: <1524156319-11465-1-git-send-email-ian.jackson@eu.citrix.com>

This is called just before os_setup_post.  Currently none of the
accelerators provide this hook, but the Xen one is going to provide
one in a moment.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
---
v7: New patch in this version of the series
---
 accel/accel.c          | 9 +++++++++
 include/sysemu/accel.h | 3 +++
 vl.c                   | 1 +
 3 files changed, 13 insertions(+)

diff --git a/accel/accel.c b/accel/accel.c
index 93e2434..9cfab11 100644
--- a/accel/accel.c
+++ b/accel/accel.c
@@ -126,6 +126,15 @@ void accel_register_compat_props(AccelState *accel)
     register_compat_props_array(class->global_props);
 }
 
+void accel_setup_post(MachineState *ms)
+{
+    AccelState *accel = ms->accelerator;
+    AccelClass *acc = ACCEL_GET_CLASS(accel);
+    if (acc->setup_post) {
+        acc->setup_post(ms, accel);
+    }
+}
+
 static void register_accel_types(void)
 {
     type_register_static(&accel_type);
diff --git a/include/sysemu/accel.h b/include/sysemu/accel.h
index 5a632ce..637358f 100644
--- a/include/sysemu/accel.h
+++ b/include/sysemu/accel.h
@@ -40,6 +40,7 @@ typedef struct AccelClass {
     const char *name;
     int (*available)(void);
     int (*init_machine)(MachineState *ms);
+    void (*setup_post)(MachineState *ms, AccelState *accel);
     bool *allowed;
     /*
      * Array of global properties that would be applied when specific
@@ -68,5 +69,7 @@ extern unsigned long tcg_tb_size;
 void configure_accelerator(MachineState *ms);
 /* Register accelerator specific global properties */
 void accel_register_compat_props(AccelState *accel);
+/* Called just before os_setup_post (ie just before drop OS privs) */
+void accel_setup_post(MachineState *ms);
 
 #endif
diff --git a/vl.c b/vl.c
index fce1fd1..36c5bd4 100644
--- a/vl.c
+++ b/vl.c
@@ -4729,6 +4729,7 @@ int main(int argc, char **argv, char **envp)
         vm_start();
     }
 
+    accel_setup_post(current_machine);
     os_setup_post();
 
     main_loop();
-- 
2.1.4


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2018-04-19 16:45 UTC|newest]

Thread overview: 81+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-19 16:45 [Qemu-devel] [PATCH v7 00/16] xen: xen-domid-restrict improvements Ian Jackson
2018-04-19 16:45 ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 01/16] checkpatch: Add xendevicemodel_handle to the list of types Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` Ian Jackson [this message]
2018-04-19 16:45   ` [PATCH 02/16] AccelClass: Introduce accel_setup_post Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 03/16] xen: link against xentoolcore Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-23 15:05   ` [Qemu-devel] " Anthony PERARD
2018-04-23 15:05     ` Anthony PERARD
2018-04-24 14:28     ` [Qemu-devel] " Ian Jackson
2018-04-24 14:28       ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 04/16] xen: restrict: use xentoolcore_restrict_all Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 05/16] xen: defer call to xen_restrict until just before os_setup_post Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-23 14:28   ` [Qemu-devel] " Anthony PERARD
2018-04-23 14:28     ` Anthony PERARD
2018-04-23 15:58   ` [Qemu-devel] " Anthony PERARD
2018-04-23 15:58     ` Anthony PERARD
2018-04-24 15:08     ` Ian Jackson
2018-04-24 15:08     ` [Qemu-devel] " Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 06/16] xen: destroy_hvm_domain: Move reason into a variable Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 07/16] xen: move xc_interface compatibility fallback further up the file Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 08/16] xen: destroy_hvm_domain: Try xendevicemodel_shutdown Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 09/16] os-posix: cleanup: Replace fprintfs with error_report in change_process_uid Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 10/16] os-posix: Provide new -runas <uid>:<gid> facility Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-20 12:56   ` [Qemu-devel] " Markus Armbruster
2018-04-20 12:56     ` Markus Armbruster
2018-04-19 16:45 ` [Qemu-devel] [PATCH 11/16] xen: Use newly added dmops for mapping VGA memory Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 12/16] xen: Remove now-obsolete xen_xc_domain_add_to_physmap Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-23 15:38   ` [Qemu-devel] " Anthony PERARD
2018-04-23 15:38   ` Anthony PERARD
2018-04-19 16:45 ` [Qemu-devel] [PATCH 13/16] xen: Expect xenstore write to fail when restricted Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 14/16] os-posix: cleanup: Replace fprintf with error_report in remaining call sites Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 20:25   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-04-19 20:25   ` Philippe Mathieu-Daudé
2018-04-20 10:19     ` Ian Jackson
2018-04-20 10:19       ` Ian Jackson
2018-04-19 16:45 ` [Qemu-devel] [PATCH 15/16] os-posix: cleanup: Replace perror with error_report Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-19 20:31   ` [Qemu-devel] " Philippe Mathieu-Daudé
2018-04-19 20:31     ` Philippe Mathieu-Daudé
2018-04-24 14:53     ` Ian Jackson
2018-04-24 14:53       ` Ian Jackson
2018-04-24 15:18       ` Daniel P. Berrangé
2018-04-24 15:18         ` Daniel P. Berrangé
2018-04-24 15:40         ` Eric Blake
2018-04-24 15:40           ` Eric Blake
2018-04-24 15:43           ` Eric Blake
2018-04-24 15:43             ` Eric Blake
2018-04-24 15:54             ` Daniel P. Berrangé
2018-04-24 15:54               ` Daniel P. Berrangé
2018-04-24 16:20     ` Markus Armbruster
2018-04-24 16:20       ` Markus Armbruster
2018-04-19 16:45 ` [Qemu-devel] [PATCH 16/16] configure: do_compiler: Dump some extra info under bash Ian Jackson
2018-04-19 16:45   ` Ian Jackson
2018-04-23 16:21   ` [Qemu-devel] " Anthony PERARD
2018-04-23 16:21     ` Anthony PERARD
2018-04-23 16:38     ` [Qemu-devel] " Daniel P. Berrangé
2018-04-23 17:12       ` Ian Jackson
2018-04-23 17:12       ` Ian Jackson
2018-04-23 16:38     ` Daniel P. Berrangé
2018-04-23 16:38     ` Ian Jackson
2018-04-23 16:38       ` Ian Jackson
2018-04-23 20:28       ` [Qemu-devel] " Eric Blake
2018-04-23 20:28         ` Eric Blake
2018-04-24 15:05         ` Ian Jackson
2018-04-24 15:05           ` Ian Jackson
2018-04-19 17:03 ` [Qemu-devel] [PATCH v7 00/16] xen: xen-domid-restrict improvements no-reply
2018-04-19 17:03   ` no-reply
2018-04-24 17:58 [Qemu-devel] [PATCH v8 " Ian Jackson
2018-04-24 17:58 ` [Qemu-devel] [PATCH 02/16] AccelClass: Introduce accel_setup_post Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524156319-11465-3-git-send-email-ian.jackson@eu.citrix.com \
    --to=ian.jackson@eu.citrix.com \
    --cc=anthony.perard@citrix.com \
    --cc=jgross@suse.com \
    --cc=qemu-devel@nongnu.org \
    --cc=ross.lagerwall@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.