[PATCH 0/2] staging: wilc1000: TODO list updates

[PATCH 0/2] staging: wilc1000: TODO list updates

[Ajay Singh]

Updated the TODO list by removing items, which are already addressed.
Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is
not present in the driver.

Ajay Singh (2):
  staging: wilc1000: remove registering of ndo_do_ioctl callback
  staging: wilc1000: updated TODO list

 drivers/staging/wilc1000/TODO         |  8 -----
 drivers/staging/wilc1000/linux_wlan.c | 63 -----------------------------------
 2 files changed, 71 deletions(-)

-- 
2.7.4

[PATCH 1/2] staging: wilc1000: remove registering of ndo_do_ioctl callback

[Ajay Singh]

Remove registering of ndo_do_ioctl in wilc_netdev_ops structure.
As RSSI information is already avaliable through cfg80211, so remove
the IOCTL call use to fetch the same information. Wext support is not
present in the driver. Its also done to address the TODO list item
mentioned below:

"use wext-core handling instead of private SIOCSIWPRIV implementation"

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---
 drivers/staging/wilc1000/linux_wlan.c | 63 -----------------------------------
 1 file changed, 63 deletions(-)

diff --git a/drivers/staging/wilc1000/linux_wlan.c b/drivers/staging/wilc1000/linux_wlan.c
index 38a83bd..08871f5 100644
--- a/drivers/staging/wilc1000/linux_wlan.c
+++ b/drivers/staging/wilc1000/linux_wlan.c
@@ -37,7 +37,6 @@ static void wlan_deinitialize_threads(struct net_device *dev);
 static void linux_wlan_tx_complete(void *priv, int status);
 static int  mac_init_fn(struct net_device *ndev);
 static struct net_device_stats *mac_stats(struct net_device *dev);
-static int  mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd);
 static int wilc_mac_open(struct net_device *ndev);
 static int wilc_mac_close(struct net_device *ndev);
 static void wilc_set_multicast_list(struct net_device *dev);
@@ -49,7 +48,6 @@ static const struct net_device_ops wilc_netdev_ops = {
 	.ndo_open = wilc_mac_open,
 	.ndo_stop = wilc_mac_close,
 	.ndo_start_xmit = wilc_mac_xmit,
-	.ndo_do_ioctl = mac_ioctl,
 	.ndo_get_stats = mac_stats,
 	.ndo_set_rx_mode  = wilc_set_multicast_list,
 
@@ -1049,67 +1047,6 @@ static int wilc_mac_close(struct net_device *ndev)
 	return 0;
 }
 
-static int mac_ioctl(struct net_device *ndev, struct ifreq *req, int cmd)
-{
-	u8 *buff = NULL;
-	s8 rssi;
-	u32 size = 0;
-	struct wilc_vif *vif;
-	s32 ret = 0;
-	struct wilc *wilc;
-
-	vif = netdev_priv(ndev);
-	wilc = vif->wilc;
-
-	if (!wilc->initialized)
-		return 0;
-
-	switch (cmd) {
-	case SIOCSIWPRIV:
-	{
-		struct iwreq *wrq = (struct iwreq *)req;
-
-		size = wrq->u.data.length;
-
-		if (size && wrq->u.data.pointer) {
-			buff = memdup_user(wrq->u.data.pointer,
-					   wrq->u.data.length);
-			if (IS_ERR(buff))
-				return PTR_ERR(buff);
-
-			if (strncasecmp(buff, "RSSI", size) == 0) {
-				ret = wilc_get_rssi(vif, &rssi);
-				netdev_info(ndev, "RSSI :%d\n", rssi);
-
-				rssi += 5;
-
-				snprintf(buff, size, "rssi %d", rssi);
-
-				if (copy_to_user(wrq->u.data.pointer, buff, size)) {
-					netdev_err(ndev, "failed to copy\n");
-					ret = -EFAULT;
-					goto done;
-				}
-			}
-		}
-	}
-	break;
-
-	default:
-	{
-		netdev_info(ndev, "Command - %d - has been received\n", cmd);
-		ret = -EOPNOTSUPP;
-		goto done;
-	}
-	}
-
-done:
-
-	kfree(buff);
-
-	return ret;
-}
-
 void wilc_frmw_to_linux(struct wilc *wilc, u8 *buff, u32 size, u32 pkt_offset)
 {
 	unsigned int frame_len = 0;
-- 
2.7.4

[PATCH 2/2] staging: wilc1000: updated TODO list

[Ajay Singh]

Removed the items from WILC1000 TODO list, which are already addressed
to keep it updated. The removed items are already taken care by
previously submitted patches.

Signed-off-by: Ajay Singh <ajay.kathat@microchip.com>
---

If someone feels differently please update for this patch. There are
pending fixes for soft-ap, p2p mode and suspend/resume operation. Along
with code refactor and cleanup patches will include patches with fixes.

If there any input for TODO to address, which can help to make this
driver ready to mainline please suggest.


 drivers/staging/wilc1000/TODO | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/wilc1000/TODO b/drivers/staging/wilc1000/TODO
index c441beb..d123324 100644
--- a/drivers/staging/wilc1000/TODO
+++ b/drivers/staging/wilc1000/TODO
@@ -1,7 +1,4 @@
 TODO:
-- remove the defined feature as kernel versions
-- remove OS wrapper functions
-- remove custom debug and tracing functions
 - rework comments and function headers(also coding style)
 - Move handling for each individual members of 'union message_body' out
   into a separate 'struct work_struct' and completely remove the multiplexer
@@ -9,13 +6,8 @@ TODO:
   implementation of each message handler into the callsite of the function
   that currently queues the 'host_if_msg'.
 - make spi and sdio components coexist in one build
-- turn compile-time platform configuration (BEAGLE_BOARD,
-  PANDA_BOARD, PLAT_WMS8304, PLAT_RKXXXX, CUSTOMER_PLATFORM, ...)
-  into run-time options that are read from DT
 - support soft-ap and p2p mode
 - support resume/suspend function
-- replace SIOCDEVPRIVATE commands with generic API functions
-- use wext-core handling instead of private SIOCSIWPRIV implementation
 - convert all uses of the old GPIO API from <linux/gpio.h> to the
   GPIO descriptor API in <linux/gpio/consumer.h> and look up GPIO
   lines from device tree, ACPI or board files, board files should
-- 
2.7.4

Re: [PATCH 0/2] staging: wilc1000: TODO list updates

[Claudiu Beznea]

Reviewed-by: Claudiu Beznea <claudiu.beznea@microchip.com>

On 24.04.2018 19:07, Ajay Singh wrote:
> Updated the TODO list by removing items, which are already addressed.
> Also remove the code to handle IOCTL(SIOCSIWPRIV) as Wext support is
> not present in the driver.
> 
> Ajay Singh (2):
>   staging: wilc1000: remove registering of ndo_do_ioctl callback
>   staging: wilc1000: updated TODO list
> 
>  drivers/staging/wilc1000/TODO         |  8 -----
>  drivers/staging/wilc1000/linux_wlan.c | 63 -----------------------------------
>  2 files changed, 71 deletions(-)
>