* [PATCH] doc: update eal option usage for FreeBSD
@ 2018-04-26 15:48 Reshma Pattan
2018-04-27 9:20 ` Burakov, Anatoly
2018-04-27 12:59 ` [PATCH v2] " Reshma Pattan
0 siblings, 2 replies; 6+ messages in thread
From: Reshma Pattan @ 2018-04-26 15:48 UTC (permalink / raw)
To: john.mcnamara, dev; +Cc: Reshma Pattan
EAL option -m is supported in FreeBSD,
so move it under supported heading from non
supported heading.
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
doc/guides/freebsd_gsg/build_sample_apps.rst | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps.rst
index 90f050232..ac92260f1 100644
--- a/doc/guides/freebsd_gsg/build_sample_apps.rst
+++ b/doc/guides/freebsd_gsg/build_sample_apps.rst
@@ -128,6 +128,10 @@ The EAL options for FreeBSD are as follows:
* ``--proc-type``:
The type of process instance.
+* ``-m MB``:
+ Memory to allocate from hugepages, regardless of processor socket.
+ It is recommended that ``--socket-mem`` be used instead of this option.
+
Other options, specific to Linux and are not supported under FreeBSD are as follows:
* ``socket-mem``:
@@ -142,10 +146,6 @@ Other options, specific to Linux and are not supported under FreeBSD are as foll
* ``--file-prefix``:
The prefix text used for hugepage filenames.
-* ``-m MB``:
- Memory to allocate from hugepages, regardless of processor socket.
- It is recommended that ``--socket-mem`` be used instead of this option.
-
The ``-c`` or ``-l`` option is mandatory; the others are optional.
Copy the DPDK application binary to your target, then run the application
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] doc: update eal option usage for FreeBSD
2018-04-26 15:48 [PATCH] doc: update eal option usage for FreeBSD Reshma Pattan
@ 2018-04-27 9:20 ` Burakov, Anatoly
2018-04-27 9:22 ` Pattan, Reshma
2018-04-27 12:59 ` [PATCH v2] " Reshma Pattan
1 sibling, 1 reply; 6+ messages in thread
From: Burakov, Anatoly @ 2018-04-27 9:20 UTC (permalink / raw)
To: Reshma Pattan, john.mcnamara, dev
On 26-Apr-18 4:48 PM, Reshma Pattan wrote:
> EAL option -m is supported in FreeBSD,
> so move it under supported heading from non
> supported heading.
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> doc/guides/freebsd_gsg/build_sample_apps.rst | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps.rst
> index 90f050232..ac92260f1 100644
> --- a/doc/guides/freebsd_gsg/build_sample_apps.rst
> +++ b/doc/guides/freebsd_gsg/build_sample_apps.rst
> @@ -128,6 +128,10 @@ The EAL options for FreeBSD are as follows:
> * ``--proc-type``:
> The type of process instance.
>
> +* ``-m MB``:
> + Memory to allocate from hugepages, regardless of processor socket.
> + It is recommended that ``--socket-mem`` be used instead of this option.
> +
--socket-mem is not supported on FreeBSD (because no NUMA support), so
the comment about recommending it is wrong.
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] doc: update eal option usage for FreeBSD
2018-04-27 9:20 ` Burakov, Anatoly
@ 2018-04-27 9:22 ` Pattan, Reshma
0 siblings, 0 replies; 6+ messages in thread
From: Pattan, Reshma @ 2018-04-27 9:22 UTC (permalink / raw)
To: Burakov, Anatoly, Mcnamara, John, dev
> -----Original Message-----
> From: Burakov, Anatoly
> Sent: Friday, April 27, 2018 10:21 AM
> To: Pattan, Reshma <reshma.pattan@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: update eal option usage for FreeBSD
>
> On 26-Apr-18 4:48 PM, Reshma Pattan wrote:
> > EAL option -m is supported in FreeBSD, so move it under supported
> > heading from non supported heading.
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
> > doc/guides/freebsd_gsg/build_sample_apps.rst | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst
> > b/doc/guides/freebsd_gsg/build_sample_apps.rst
> > index 90f050232..ac92260f1 100644
> > --- a/doc/guides/freebsd_gsg/build_sample_apps.rst
> > +++ b/doc/guides/freebsd_gsg/build_sample_apps.rst
> > @@ -128,6 +128,10 @@ The EAL options for FreeBSD are as follows:
> > * ``--proc-type``:
> > The type of process instance.
> >
> > +* ``-m MB``:
> > + Memory to allocate from hugepages, regardless of processor socket.
> > + It is recommended that ``--socket-mem`` be used instead of this option.
> > +
>
> --socket-mem is not supported on FreeBSD (because no NUMA support), so
> the comment about recommending it is wrong.
Ohh yes, my bad :-( I will recorrect it.
>
> --
> Thanks,
> Anatoly
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] doc: update eal option usage for FreeBSD
2018-04-26 15:48 [PATCH] doc: update eal option usage for FreeBSD Reshma Pattan
2018-04-27 9:20 ` Burakov, Anatoly
@ 2018-04-27 12:59 ` Reshma Pattan
2018-04-27 13:14 ` Burakov, Anatoly
1 sibling, 1 reply; 6+ messages in thread
From: Reshma Pattan @ 2018-04-27 12:59 UTC (permalink / raw)
To: john.mcnamara, anatoly.burakov, dev; +Cc: Reshma Pattan
EAL option -m is supported in FreeBSD,
so move it under supported heading from non
supported heading.
Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
---
v2: remove recommendation of socket-mem option.
---
doc/guides/freebsd_gsg/build_sample_apps.rst | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps.rst
index 90f050232..a085b6187 100644
--- a/doc/guides/freebsd_gsg/build_sample_apps.rst
+++ b/doc/guides/freebsd_gsg/build_sample_apps.rst
@@ -128,6 +128,9 @@ The EAL options for FreeBSD are as follows:
* ``--proc-type``:
The type of process instance.
+* ``-m MB``:
+ Memory to allocate from hugepages, regardless of processor socket.
+
Other options, specific to Linux and are not supported under FreeBSD are as follows:
* ``socket-mem``:
@@ -142,10 +145,6 @@ Other options, specific to Linux and are not supported under FreeBSD are as foll
* ``--file-prefix``:
The prefix text used for hugepage filenames.
-* ``-m MB``:
- Memory to allocate from hugepages, regardless of processor socket.
- It is recommended that ``--socket-mem`` be used instead of this option.
-
The ``-c`` or ``-l`` option is mandatory; the others are optional.
Copy the DPDK application binary to your target, then run the application
--
2.14.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] doc: update eal option usage for FreeBSD
2018-04-27 12:59 ` [PATCH v2] " Reshma Pattan
@ 2018-04-27 13:14 ` Burakov, Anatoly
2018-04-27 22:08 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Burakov, Anatoly @ 2018-04-27 13:14 UTC (permalink / raw)
To: Reshma Pattan, john.mcnamara, dev
On 27-Apr-18 1:59 PM, Reshma Pattan wrote:
> EAL option -m is supported in FreeBSD,
> so move it under supported heading from non
> supported heading.
>
> Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> ---
> v2: remove recommendation of socket-mem option.
> ---
Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] doc: update eal option usage for FreeBSD
2018-04-27 13:14 ` Burakov, Anatoly
@ 2018-04-27 22:08 ` Thomas Monjalon
0 siblings, 0 replies; 6+ messages in thread
From: Thomas Monjalon @ 2018-04-27 22:08 UTC (permalink / raw)
To: Reshma Pattan; +Cc: dev, Burakov, Anatoly, john.mcnamara
27/04/2018 15:14, Burakov, Anatoly:
> On 27-Apr-18 1:59 PM, Reshma Pattan wrote:
> > EAL option -m is supported in FreeBSD,
> > so move it under supported heading from non
> > supported heading.
> >
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
> > v2: remove recommendation of socket-mem option.
> > ---
>
> Reviewed-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-04-27 22:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 15:48 [PATCH] doc: update eal option usage for FreeBSD Reshma Pattan
2018-04-27 9:20 ` Burakov, Anatoly
2018-04-27 9:22 ` Pattan, Reshma
2018-04-27 12:59 ` [PATCH v2] " Reshma Pattan
2018-04-27 13:14 ` Burakov, Anatoly
2018-04-27 22:08 ` Thomas Monjalon
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.