All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header
@ 2018-04-26 19:27 Manasi Navare
  2018-04-27  9:27 ` ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Manasi Navare @ 2018-04-26 19:27 UTC (permalink / raw)
  To: intel-gfx; +Cc: Jani Nikula, dri-devel

No functional changes in this patch.

The SDP Header is a generic header for secondary data packets for
both eDP and DP so call it dp_sdp_header. This header gets used for
different SDP types already defined.
Also header bytes 2 and 3 are secondary data packet specific header bytes.
So change the comment to indicate the same.

Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: dri-devel@lists.freedesktop.org
Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
---
 include/drm/drm_dp_helper.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
index 91c9bcd..2d55036 100644
--- a/include/drm/drm_dp_helper.h
+++ b/include/drm/drm_dp_helper.h
@@ -977,18 +977,18 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw);
 #define DP_SDP_VSC_EXT_CEA		0x21 /* DP 1.4 */
 /* 0x80+ CEA-861 infoframe types */
 
-struct edp_sdp_header {
+struct dp_sdp_header {
 	u8 HB0; /* Secondary Data Packet ID */
 	u8 HB1; /* Secondary Data Packet Type */
-	u8 HB2; /* 7:5 reserved, 4:0 revision number */
-	u8 HB3; /* 7:5 reserved, 4:0 number of valid data bytes */
+	u8 HB2; /* Secondary Data Packet Specific header, Byte 0 */
+	u8 HB3; /* Secondary Data packet Specific header, Byte 1 */
 } __packed;
 
 #define EDP_SDP_HEADER_REVISION_MASK		0x1F
 #define EDP_SDP_HEADER_VALID_PAYLOAD_BYTES	0x1F
 
 struct edp_vsc_psr {
-	struct edp_sdp_header sdp_header;
+	struct dp_sdp_header sdp_header;
 	u8 DB0; /* Stereo Interface */
 	u8 DB1; /* 0 - PSR State; 1 - Update RFB; 2 - CRC Valid */
 	u8 DB2; /* CRC value bits 7:0 of the R or Cr component */
-- 
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* ✓ Fi.CI.BAT: success for drm/dp: Rename the edp_sdp_header as dp_sdp_header
  2018-04-26 19:27 [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header Manasi Navare
@ 2018-04-27  9:27 ` Patchwork
  2018-04-27 11:48 ` ✓ Fi.CI.IGT: " Patchwork
  2018-04-27 14:12 ` [PATCH] " Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-27  9:27 UTC (permalink / raw)
  To: Manasi Navare; +Cc: intel-gfx

== Series Details ==

Series: drm/dp: Rename the edp_sdp_header as dp_sdp_header
URL   : https://patchwork.freedesktop.org/series/42363/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4106 -> Patchwork_8819 =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_8819 need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_8819, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42363/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_8819:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_gttfill@basic:
      fi-pnv-d510:        SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_8819 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-cnl-psr:         PASS -> FAIL (fdo#100368)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
      fi-cnl-y3:          PASS -> DMESG-FAIL (fdo#103191)

    
    ==== Possible fixes ====

    igt@prime_vgem@basic-fence-flip:
      fi-ilk-650:         FAIL (fdo#104008) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#104008 https://bugs.freedesktop.org/show_bug.cgi?id=104008


== Participating hosts (39 -> 35) ==

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-bxt-dsi fi-skl-6700hq 


== Build changes ==

    * Linux: CI_DRM_4106 -> Patchwork_8819

  CI_DRM_4106: dd4a65248ce636039848b97f0b8e4704aa2f32b2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4450: 0350f0e7f6a0e07281445fc3082aa70419f4aac7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8819: 031193daa609e6a5e124b1413dc736583c0dd58b @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4450: b57600ba58ae0cdbad86826fd653aa0191212f27 @ git://anongit.freedesktop.org/piglit


== Linux commits ==

031193daa609 drm/dp: Rename the edp_sdp_header as dp_sdp_header

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8819/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* ✓ Fi.CI.IGT: success for drm/dp: Rename the edp_sdp_header as dp_sdp_header
  2018-04-26 19:27 [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header Manasi Navare
  2018-04-27  9:27 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-04-27 11:48 ` Patchwork
  2018-04-27 14:12 ` [PATCH] " Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2018-04-27 11:48 UTC (permalink / raw)
  To: Manasi Navare; +Cc: intel-gfx

== Series Details ==

Series: drm/dp: Rename the edp_sdp_header as dp_sdp_header
URL   : https://patchwork.freedesktop.org/series/42363/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4106_full -> Patchwork_8819_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_8819_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_8819_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42363/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_8819_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_exec_schedule@deep-render:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in Patchwork_8819_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_exec_suspend@basic-s3-devices:
      shard-hsw:          PASS -> DMESG-WARN (fdo#106086)

    igt@kms_cursor_legacy@flip-vs-cursor-legacy:
      shard-hsw:          PASS -> FAIL (fdo#102670)

    igt@kms_flip@2x-dpms-vs-vblank-race-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#103060)

    igt@kms_flip@basic-flip-vs-wf_vblank:
      shard-hsw:          PASS -> FAIL (fdo#103928)

    igt@kms_flip@flip-vs-expired-vblank-interruptible:
      shard-glk:          PASS -> FAIL (fdo#102887, fdo#105363)

    igt@kms_flip@plain-flip-fb-recreate-interruptible:
      shard-hsw:          PASS -> FAIL (fdo#100368)

    igt@kms_flip@wf_vblank-ts-check-interruptible:
      shard-apl:          PASS -> FAIL (fdo#100368)

    igt@pm_rpm@universal-planes-dpms:
      shard-kbl:          PASS -> DMESG-WARN (fdo#105602, fdo#103558) +7

    
    ==== Possible fixes ====

    igt@kms_flip@plain-flip-ts-check-interruptible:
      shard-glk:          FAIL (fdo#100368) -> PASS

    igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
      shard-glk:          DMESG-WARN (fdo#106247) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-hsw:          FAIL (fdo#103925) -> PASS

    igt@kms_vblank@pipe-a-accuracy-idle:
      shard-hsw:          FAIL (fdo#102583) -> PASS

    
  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102583 https://bugs.freedesktop.org/show_bug.cgi?id=102583
  fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
  fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
  fdo#103060 https://bugs.freedesktop.org/show_bug.cgi?id=103060
  fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
  fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
  fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
  fdo#106086 https://bugs.freedesktop.org/show_bug.cgi?id=106086
  fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247


== Participating hosts (9 -> 5) ==

  Missing    (4): shard-glkb pig-skl-6600 pig-glk-j4005 pig-hsw-4770r 


== Build changes ==

    * Linux: CI_DRM_4106 -> Patchwork_8819

  CI_DRM_4106: dd4a65248ce636039848b97f0b8e4704aa2f32b2 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4450: 0350f0e7f6a0e07281445fc3082aa70419f4aac7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8819: 031193daa609e6a5e124b1413dc736583c0dd58b @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4450: b57600ba58ae0cdbad86826fd653aa0191212f27 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8819/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header
  2018-04-26 19:27 [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header Manasi Navare
  2018-04-27  9:27 ` ✓ Fi.CI.BAT: success for " Patchwork
  2018-04-27 11:48 ` ✓ Fi.CI.IGT: " Patchwork
@ 2018-04-27 14:12 ` Ville Syrjälä
  2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2018-04-27 14:12 UTC (permalink / raw)
  To: Manasi Navare; +Cc: Jani Nikula, intel-gfx, dri-devel

On Thu, Apr 26, 2018 at 12:27:48PM -0700, Manasi Navare wrote:
> No functional changes in this patch.
> 
> The SDP Header is a generic header for secondary data packets for
> both eDP and DP so call it dp_sdp_header. This header gets used for
> different SDP types already defined.
> Also header bytes 2 and 3 are secondary data packet specific header bytes.
> So change the comment to indicate the same.
> 
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Jani Nikula <jani.nikula@intel.com>
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>

Pushed to drm-misc-next. Thanks for the patch.

> ---
>  include/drm/drm_dp_helper.h | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index 91c9bcd..2d55036 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -977,18 +977,18 @@ int drm_dp_bw_code_to_link_rate(u8 link_bw);
>  #define DP_SDP_VSC_EXT_CEA		0x21 /* DP 1.4 */
>  /* 0x80+ CEA-861 infoframe types */
>  
> -struct edp_sdp_header {
> +struct dp_sdp_header {
>  	u8 HB0; /* Secondary Data Packet ID */
>  	u8 HB1; /* Secondary Data Packet Type */
> -	u8 HB2; /* 7:5 reserved, 4:0 revision number */
> -	u8 HB3; /* 7:5 reserved, 4:0 number of valid data bytes */
> +	u8 HB2; /* Secondary Data Packet Specific header, Byte 0 */
> +	u8 HB3; /* Secondary Data packet Specific header, Byte 1 */
>  } __packed;
>  
>  #define EDP_SDP_HEADER_REVISION_MASK		0x1F
>  #define EDP_SDP_HEADER_VALID_PAYLOAD_BYTES	0x1F
>  
>  struct edp_vsc_psr {
> -	struct edp_sdp_header sdp_header;
> +	struct dp_sdp_header sdp_header;
>  	u8 DB0; /* Stereo Interface */
>  	u8 DB1; /* 0 - PSR State; 1 - Update RFB; 2 - CRC Valid */
>  	u8 DB2; /* CRC value bits 7:0 of the R or Cr component */
> -- 
> 2.7.4

-- 
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-04-27 14:12 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-26 19:27 [PATCH] drm/dp: Rename the edp_sdp_header as dp_sdp_header Manasi Navare
2018-04-27  9:27 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-04-27 11:48 ` ✓ Fi.CI.IGT: " Patchwork
2018-04-27 14:12 ` [PATCH] " Ville Syrjälä

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.