* [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
@ 2018-04-27 7:20 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2018-04-27 7:20 UTC (permalink / raw)
To: shawnguo, kernel, fabio.estevam, robh+dt, mark.rutland, haibo.chen
Cc: Linux-imx, linux-arm-kernel, devicetree, linux-kernel
From: Haibo Chen <haibo.chen@nxp.com>
Add egalax touch screen support on i2c2 bus.
Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index 6b94f24..2f6e474 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -131,6 +131,12 @@
&iomuxc {
imx6x-sabreauto {
+ pinctrl_egalax_int: egalax_intgrp {
+ fsl,pins = <
+ MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
+ >;
+ };
+
pinctrl_led: ledgrp {
fsl,pins = <
MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
@@ -274,6 +280,16 @@
pinctrl-0 = <&pinctrl_i2c2_1>;
status = "okay";
+ egalax_ts@04 {
+ compatible = "eeti,egalax_ts";
+ reg = <0x04>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_egalax_int>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
+ };
+
max7322: gpio@68 {
compatible = "maxim,max7322";
reg = <0x68>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
@ 2018-04-27 7:20 ` Anson Huang
0 siblings, 0 replies; 4+ messages in thread
From: Anson Huang @ 2018-04-27 7:20 UTC (permalink / raw)
To: linux-arm-kernel
From: Haibo Chen <haibo.chen@nxp.com>
Add egalax touch screen support on i2c2 bus.
Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
index 6b94f24..2f6e474 100644
--- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
+++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
@@ -131,6 +131,12 @@
&iomuxc {
imx6x-sabreauto {
+ pinctrl_egalax_int: egalax_intgrp {
+ fsl,pins = <
+ MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
+ >;
+ };
+
pinctrl_led: ledgrp {
fsl,pins = <
MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
@@ -274,6 +280,16 @@
pinctrl-0 = <&pinctrl_i2c2_1>;
status = "okay";
+ egalax_ts at 04 {
+ compatible = "eeti,egalax_ts";
+ reg = <0x04>;
+ pinctrl-names = "default";
+ pinctrl-0 = <&pinctrl_egalax_int>;
+ interrupt-parent = <&gpio6>;
+ interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
+ wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
+ };
+
max7322: gpio at 68 {
compatible = "maxim,max7322";
reg = <0x68>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
2018-04-27 7:20 ` Anson Huang
@ 2018-05-04 8:27 ` Shawn Guo
-1 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-05-04 8:27 UTC (permalink / raw)
To: Anson Huang
Cc: kernel, fabio.estevam, robh+dt, mark.rutland, haibo.chen,
devicetree, Linux-imx, linux-arm-kernel, linux-kernel
On Fri, Apr 27, 2018 at 03:20:50PM +0800, Anson Huang wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 6b94f24..2f6e474 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -131,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_egalax_int: egalax_intgrp {
General recommendation: use hyphen instead of underscore in the node
node.
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
> + >;
> + };
> +
> pinctrl_led: ledgrp {
> fsl,pins = <
> MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> @@ -274,6 +280,16 @@
> pinctrl-0 = <&pinctrl_i2c2_1>;
> status = "okay";
>
> + egalax_ts@04 {
Use generic node name - touchscreen, as recommended by Devicetree
Specification, and drop leading zeros in unit-address.
Shawn
> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_egalax_int>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
> + };
> +
> max7322: gpio@68 {
> compatible = "maxim,max7322";
> reg = <0x68>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support
@ 2018-05-04 8:27 ` Shawn Guo
0 siblings, 0 replies; 4+ messages in thread
From: Shawn Guo @ 2018-05-04 8:27 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Apr 27, 2018 at 03:20:50PM +0800, Anson Huang wrote:
> From: Haibo Chen <haibo.chen@nxp.com>
>
> Add egalax touch screen support on i2c2 bus.
>
> Signed-off-by: Haibo Chen <haibo.chen@freescale.com>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> this patch is based on patch (ARM: dts: imx6sx-sabreauto: add debug LED support) I sent out for review.
> arch/arm/boot/dts/imx6sx-sabreauto.dts | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6sx-sabreauto.dts b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> index 6b94f24..2f6e474 100644
> --- a/arch/arm/boot/dts/imx6sx-sabreauto.dts
> +++ b/arch/arm/boot/dts/imx6sx-sabreauto.dts
> @@ -131,6 +131,12 @@
> &iomuxc {
> imx6x-sabreauto {
>
> + pinctrl_egalax_int: egalax_intgrp {
General recommendation: use hyphen instead of underscore in the node
node.
> + fsl,pins = <
> + MX6SX_PAD_SD4_RESET_B__GPIO6_IO_22 0x80000000
> + >;
> + };
> +
> pinctrl_led: ledgrp {
> fsl,pins = <
> MX6SX_PAD_CSI_PIXCLK__GPIO1_IO_24 0x17059
> @@ -274,6 +280,16 @@
> pinctrl-0 = <&pinctrl_i2c2_1>;
> status = "okay";
>
> + egalax_ts at 04 {
Use generic node name - touchscreen, as recommended by Devicetree
Specification, and drop leading zeros in unit-address.
Shawn
> + compatible = "eeti,egalax_ts";
> + reg = <0x04>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_egalax_int>;
> + interrupt-parent = <&gpio6>;
> + interrupts = <22 IRQ_TYPE_EDGE_FALLING>;
> + wakeup-gpios = <&gpio6 22 GPIO_ACTIVE_HIGH>;
> + };
> +
> max7322: gpio at 68 {
> compatible = "maxim,max7322";
> reg = <0x68>;
> --
> 2.7.4
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-04 8:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-27 7:20 [PATCH] ARM: dts: imx6sx-sabreauto: add egalax touch screen support Anson Huang
2018-04-27 7:20 ` Anson Huang
2018-05-04 8:27 ` Shawn Guo
2018-05-04 8:27 ` Shawn Guo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.