All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/userptr: reject zero user_size
@ 2018-05-02 18:16 Matthew Auld
  2018-05-02 18:45 ` Chris Wilson
                   ` (5 more replies)
  0 siblings, 6 replies; 12+ messages in thread
From: Matthew Auld @ 2018-05-02 18:16 UTC (permalink / raw)
  To: intel-gfx

Operating on a zero sized GEM userptr object will lead to explosions.

Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into video memory (userptr) ioctl")
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/i915_gem_userptr.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_userptr.c b/drivers/gpu/drm/i915/i915_gem_userptr.c
index d596a8302ca3..854bd51b9478 100644
--- a/drivers/gpu/drm/i915/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/i915_gem_userptr.c
@@ -778,6 +778,9 @@ i915_gem_userptr_ioctl(struct drm_device *dev,
 			    I915_USERPTR_UNSYNCHRONIZED))
 		return -EINVAL;
 
+	if (!args->user_size)
+		return -EINVAL;
+
 	if (offset_in_page(args->user_ptr | args->user_size))
 		return -EINVAL;
 
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 12+ messages in thread
* [PATCH] drm/i915/userptr: reject zero user_size
@ 2018-09-02 21:55 Loic
  2018-09-03 16:17 ` Greg KH
  0 siblings, 1 reply; 12+ messages in thread
From: Loic @ 2018-09-02 21:55 UTC (permalink / raw)
  To: stable; +Cc: matthew.auld

Hello,

Tested without any problem so please picked up this.

 From: Matthew Auld

[ Upstream commit c11c7bfd213495784b22ef82a69b6489f8d0092f ]

Operating on a zero sized GEM userptr object will lead to explosions.

Fixes: 5cc9ed4b9a7a ("drm/i915: Introduce mapping of user pages into 
video memory (userptr) ioctl")
Testcase: igt/gem_userptr_blits/input-checking
Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: 
https://patchwork.freedesktop.org/patch/msgid/20180502195021.30900-1-matthew.auld@intel.com
---
  drivers/gpu/drm/i915/i915_gem_userptr.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/i915/i915_gem_userptr.c 
b/drivers/gpu/drm/i915/i915_gem_userptr.c
index d596a8302ca3c..854bd51b9478a 100644
--- a/drivers/gpu/drm/i915/i915_gem_userptr.c
+++ b/drivers/gpu/drm/i915/i915_gem_userptr.c
@@ -778,6 +778,9 @@ i915_gem_userptr_ioctl(struct drm_device *dev,
  			    I915_USERPTR_UNSYNCHRONIZED))
  		return -EINVAL;

+	if (!args->user_size)
+		return -EINVAL;
+
  	if (offset_in_page(args->user_ptr | args->user_size))
  		return -EINVAL;

-- 
2.17.1

^ permalink raw reply related	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2018-09-07 13:42 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 18:16 [PATCH] drm/i915/userptr: reject zero user_size Matthew Auld
2018-05-02 18:45 ` Chris Wilson
2018-05-02 18:52 ` ✓ Fi.CI.BAT: success for " Patchwork
2018-05-02 18:53 ` [PATCH] " Chris Wilson
2018-05-02 19:50 ` Matthew Auld
2018-05-08 11:25   ` Chris Wilson
2018-05-02 20:38 ` ✓ Fi.CI.BAT: success for drm/i915/userptr: reject zero user_size (rev2) Patchwork
2018-05-03  3:33 ` ✓ Fi.CI.IGT: " Patchwork
2018-09-02 21:55 [PATCH] drm/i915/userptr: reject zero user_size Loic
2018-09-03 16:17 ` Greg KH
2018-09-03 19:56   ` Loic
2018-09-07  9:01     ` Greg KH

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.