All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Whitespace fixes
@ 2018-05-02 23:19 Brad Love
  2018-05-02 23:19 ` [PATCH 1/2] intel-ipu3: Kconfig coding style issue Brad Love
  2018-05-02 23:19 ` [PATCH 2/2] cec: " Brad Love
  0 siblings, 2 replies; 5+ messages in thread
From: Brad Love @ 2018-05-02 23:19 UTC (permalink / raw)
  To: linux-media, sakari.ailus, hverkuil; +Cc: Brad Love

In intel/ipu3 and media Kconfig files there
are whitespace issues, which cause failure when
doing menuconfig on older kernels during backport
operations. The kernel rules are applied to both
Kconfigs. Initial spacing of one tab, then help is
further indented by two spaces.

Brad Love (2):
  intel-ipu3: Kconfig coding style issue
  cec: Kconfig coding style issue

 drivers/media/Kconfig                 | 12 ++++++------
 drivers/media/pci/intel/ipu3/Kconfig  | 12 ++++++------
 2 files changed, 12 insertions(+), 12 deletions(-)

-- 
2.7.4

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/2] intel-ipu3: Kconfig coding style issue
  2018-05-02 23:19 [PATCH 0/2] Whitespace fixes Brad Love
@ 2018-05-02 23:19 ` Brad Love
  2018-05-03  7:32   ` Sakari Ailus
  2018-05-02 23:19 ` [PATCH 2/2] cec: " Brad Love
  1 sibling, 1 reply; 5+ messages in thread
From: Brad Love @ 2018-05-02 23:19 UTC (permalink / raw)
  To: linux-media, sakari.ailus, hverkuil; +Cc: Brad Love

Kconfig Help statements are two-spaced after a single tab.

The incorrect spacing breaks menuconfig on older kernels.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 drivers/media/pci/intel/ipu3/Kconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/pci/intel/ipu3/Kconfig b/drivers/media/pci/intel/ipu3/Kconfig
index a82d3fe..7f5b7a5 100644
--- a/drivers/media/pci/intel/ipu3/Kconfig
+++ b/drivers/media/pci/intel/ipu3/Kconfig
@@ -10,10 +10,10 @@ config VIDEO_IPU3_CIO2
 	select VIDEOBUF2_DMA_SG
 
 	---help---
-	This is the Intel IPU3 CIO2 CSI-2 receiver unit, found in Intel
-	Skylake and Kaby Lake SoCs and used for capturing images and
-	video from a camera sensor.
+	  This is the Intel IPU3 CIO2 CSI-2 receiver unit, found in Intel
+	  Skylake and Kaby Lake SoCs and used for capturing images and
+	  video from a camera sensor.
 
-	Say Y or M here if you have a Skylake/Kaby Lake SoC with MIPI CSI-2
-	connected camera.
-	The module will be called ipu3-cio2.
+	  Say Y or M here if you have a Skylake/Kaby Lake SoC with MIPI CSI-2
+	  connected camera.
+	  The module will be called ipu3-cio2.
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH 2/2] cec: Kconfig coding style issue
  2018-05-02 23:19 [PATCH 0/2] Whitespace fixes Brad Love
  2018-05-02 23:19 ` [PATCH 1/2] intel-ipu3: Kconfig coding style issue Brad Love
@ 2018-05-02 23:19 ` Brad Love
  2018-05-03  7:33   ` Sakari Ailus
  1 sibling, 1 reply; 5+ messages in thread
From: Brad Love @ 2018-05-02 23:19 UTC (permalink / raw)
  To: linux-media, sakari.ailus, hverkuil; +Cc: Brad Love

Use tabs instead of spaces and help is two-spaced after single tab.

The incorrect spacing breaks menuconfig on older kernels.

Signed-off-by: Brad Love <brad@nextdimension.cc>
---
 drivers/media/Kconfig | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 37124c3..8add62a 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -78,13 +78,13 @@ config MEDIA_SDR_SUPPORT
 	  Say Y when you have a software defined radio device.
 
 config MEDIA_CEC_SUPPORT
-       bool "HDMI CEC support"
-       ---help---
-	 Enable support for HDMI CEC (Consumer Electronics Control),
-	 which is an optional HDMI feature.
+	bool "HDMI CEC support"
+	---help---
+	  Enable support for HDMI CEC (Consumer Electronics Control),
+	  which is an optional HDMI feature.
 
-	 Say Y when you have an HDMI receiver, transmitter or a USB CEC
-	 adapter that supports HDMI CEC.
+	  Say Y when you have an HDMI receiver, transmitter or a USB CEC
+	  adapter that supports HDMI CEC.
 
 source "drivers/media/cec/Kconfig"
 
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] intel-ipu3: Kconfig coding style issue
  2018-05-02 23:19 ` [PATCH 1/2] intel-ipu3: Kconfig coding style issue Brad Love
@ 2018-05-03  7:32   ` Sakari Ailus
  0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2018-05-03  7:32 UTC (permalink / raw)
  To: Brad Love; +Cc: linux-media, hverkuil

On Wed, May 02, 2018 at 06:19:29PM -0500, Brad Love wrote:
> Kconfig Help statements are two-spaced after a single tab.
> 
> The incorrect spacing breaks menuconfig on older kernels.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] cec: Kconfig coding style issue
  2018-05-02 23:19 ` [PATCH 2/2] cec: " Brad Love
@ 2018-05-03  7:33   ` Sakari Ailus
  0 siblings, 0 replies; 5+ messages in thread
From: Sakari Ailus @ 2018-05-03  7:33 UTC (permalink / raw)
  To: Brad Love; +Cc: linux-media, hverkuil

On Wed, May 02, 2018 at 06:19:30PM -0500, Brad Love wrote:
> Use tabs instead of spaces and help is two-spaced after single tab.
> 
> The incorrect spacing breaks menuconfig on older kernels.
> 
> Signed-off-by: Brad Love <brad@nextdimension.cc>

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
sakari.ailus@linux.intel.com

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2018-05-03  7:33 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-02 23:19 [PATCH 0/2] Whitespace fixes Brad Love
2018-05-02 23:19 ` [PATCH 1/2] intel-ipu3: Kconfig coding style issue Brad Love
2018-05-03  7:32   ` Sakari Ailus
2018-05-02 23:19 ` [PATCH 2/2] cec: " Brad Love
2018-05-03  7:33   ` Sakari Ailus

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.