* [U-Boot] [PATCH] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected
@ 2018-05-03 11:45 Alex Kiernan
2018-05-03 18:16 ` Joe Hershberger
2018-05-11 11:08 ` [U-Boot] " Tom Rini
0 siblings, 2 replies; 3+ messages in thread
From: Alex Kiernan @ 2018-05-03 11:45 UTC (permalink / raw)
To: u-boot
Attempting to build with both DEBUG and CONFIG_USE_TINY_PRINTF along
with CONFIG_SPL_YMODEM_SUPPORT fails at link time:
common/built-in.o: In function `zm_dprintf':
common/xyzModem.c:190: undefined reference to `vsprintf'
Disable Ymodem debug if we don't have full vsprintf support.
Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
---
common/xyzModem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/xyzModem.c b/common/xyzModem.c
index a0c5dfe..8f830bb 100644
--- a/common/xyzModem.c
+++ b/common/xyzModem.c
@@ -172,7 +172,7 @@ parse_num (char *s, unsigned long *val, char **es, char *delim)
}
-#ifdef DEBUG
+#if defined(DEBUG) && !defined(CONFIG_USE_TINY_PRINTF)
/*
* Note: this debug setup works by storing the strings in a fixed buffer
*/
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected
2018-05-03 11:45 [U-Boot] [PATCH] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected Alex Kiernan
@ 2018-05-03 18:16 ` Joe Hershberger
2018-05-11 11:08 ` [U-Boot] " Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Joe Hershberger @ 2018-05-03 18:16 UTC (permalink / raw)
To: u-boot
On Thu, May 3, 2018 at 6:45 AM, Alex Kiernan <alex.kiernan@gmail.com> wrote:
> Attempting to build with both DEBUG and CONFIG_USE_TINY_PRINTF along
> with CONFIG_SPL_YMODEM_SUPPORT fails at link time:
>
> common/built-in.o: In function `zm_dprintf':
> common/xyzModem.c:190: undefined reference to `vsprintf'
>
> Disable Ymodem debug if we don't have full vsprintf support.
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected
2018-05-03 11:45 [U-Boot] [PATCH] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected Alex Kiernan
2018-05-03 18:16 ` Joe Hershberger
@ 2018-05-11 11:08 ` Tom Rini
1 sibling, 0 replies; 3+ messages in thread
From: Tom Rini @ 2018-05-11 11:08 UTC (permalink / raw)
To: u-boot
On Thu, May 03, 2018 at 11:45:08AM +0000, Alex Kiernan wrote:
> Attempting to build with both DEBUG and CONFIG_USE_TINY_PRINTF along
> with CONFIG_SPL_YMODEM_SUPPORT fails at link time:
>
> common/built-in.o: In function `zm_dprintf':
> common/xyzModem.c:190: undefined reference to `vsprintf'
>
> Disable Ymodem debug if we don't have full vsprintf support.
>
> Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
> Reviewed-by: Joe Hershberger <joe.hershberger@ni.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20180511/b9a2c1fa/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-11 11:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 11:45 [U-Boot] [PATCH] Fix Ymodem build when DEBUG and CONFIG_USE_TINY_PRINTF are selected Alex Kiernan
2018-05-03 18:16 ` Joe Hershberger
2018-05-11 11:08 ` [U-Boot] " Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.