* [Buildroot] [PATCH 1/2] Makefile: add tainting support
@ 2018-05-03 21:34 Angelo Compagnucci
2018-05-03 21:34 ` [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules Angelo Compagnucci
2018-05-04 19:14 ` [Buildroot] [PATCH 1/2] Makefile: add tainting support Arnout Vandecappelle
0 siblings, 2 replies; 4+ messages in thread
From: Angelo Compagnucci @ 2018-05-03 21:34 UTC (permalink / raw)
To: buildroot
From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Packages who harms the build reproducibility can declare
FOO_TAINTS variable.
If a package taints the build it will be added to a list
of tainting packages.
The build ends with a warning if the tainting packages
list is not empty.
Moreover, legal info will show a warning in presence
of a tainting package.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
Makefile | 11 +++++++++++
package/pkg-generic.mk | 9 +++++++++
2 files changed, 20 insertions(+)
diff --git a/Makefile b/Makefile
index c024c65..1b3d987 100644
--- a/Makefile
+++ b/Makefile
@@ -758,12 +758,22 @@ endif
touch $(TARGET_DIR)/usr
+# Check here if there are packages declaring they harm
+# the reproducibility of the build
+.PHONY: check-tainted
+check-tainted:
+ifneq ($(BR2_TAINTED_BY),)
+ $(error Buildroot is tainted (by: $(BR2_TAINTED_BY)).)
+endif
+
.PHONY: target-post-image
target-post-image: $(TARGETS_ROOTFS) target-finalize
@rm -f $(ROOTFS_COMMON_TAR)
@$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
$(call MESSAGE,"Executing post-image script $(s)"); \
$(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
+ @if [ ! -z "$(BR2_TAINTED_BY)" ]; then \
+ echo "WARNING: Buildroot is tainted (by: $(BR2_TAINTED_BY))"; fi
.PHONY: source
source: $(foreach p,$(PACKAGES),$(p)-all-source)
@@ -1070,6 +1080,7 @@ help:
@echo ' source - download all sources needed for offline-build'
@echo ' external-deps - list external packages used'
@echo ' legal-info - generate info about license compliance'
+ @echo ' check-tainted - check if any selected package harms build reproducibility'
@echo ' printvars - dump all the internal variables'
@echo
@echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build'
diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
index a303dc2..a71ed6a 100644
--- a/package/pkg-generic.mk
+++ b/package/pkg-generic.mk
@@ -542,6 +542,10 @@ ifndef $(2)_REDISTRIBUTE
endif
endif
+ifdef $(2)_TAINTS
+ BR2_TAINTED_BY+=$$($(2)_RAWNAME)
+endif
+
$(2)_REDISTRIBUTE ?= YES
$(2)_REDIST_SOURCES_DIR = $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))/$$($(2)_BASENAME_RAW)
@@ -900,6 +904,11 @@ else
$(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep))
endif # license files
+# Save a legal warning if tainted
+ifeq ($$(call qstrip,$$($(2)_TAINTS)),YES)
+ $(Q)$$(call legal-warning-pkg,$$($(2)_RAWNAME),unknown license for additional modules or dependencies)
+endif
+
ifeq ($$($(2)_SITE_METHOD),local)
# Packages without a tarball: don't save and warn
@$$(call legal-warning-nosource,$$($(2)_RAWNAME),local)
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules
2018-05-03 21:34 [Buildroot] [PATCH 1/2] Makefile: add tainting support Angelo Compagnucci
@ 2018-05-03 21:34 ` Angelo Compagnucci
2018-05-04 19:14 ` [Buildroot] [PATCH 1/2] Makefile: add tainting support Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Angelo Compagnucci @ 2018-05-03 21:34 UTC (permalink / raw)
To: buildroot
From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
This patch enables the tainting of the build when an
external module is added.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
package/nodejs/nodejs.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index 2642525..3cb9209 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -160,6 +160,7 @@ NPM = $(TARGET_CONFIGURE_OPTS) \
# We can only call NPM if there's something to install.
#
ifneq ($(NODEJS_MODULES_LIST),)
+NODEJS_TAINTS = YES
define NODEJS_INSTALL_MODULES
# If you're having trouble with module installation, adding -d to the
# npm install call below and setting npm_config_rollback=false can both
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/2] Makefile: add tainting support
2018-05-03 21:34 [Buildroot] [PATCH 1/2] Makefile: add tainting support Angelo Compagnucci
2018-05-03 21:34 ` [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules Angelo Compagnucci
@ 2018-05-04 19:14 ` Arnout Vandecappelle
1 sibling, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2018-05-04 19:14 UTC (permalink / raw)
To: buildroot
Hi Angelo,
Some nits that were already present in v1 but I didn't review before...
On 03-05-18 23:34, Angelo Compagnucci wrote:
> From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
>
> Packages who harms the build reproducibility can declare
> FOO_TAINTS variable.
> If a package taints the build it will be added to a list
> of tainting packages.
> The build ends with a warning if the tainting packages
> list is not empty.
> Moreover, legal info will show a warning in presence
> of a tainting package.
Commit message wrapping is a bit weird. Wrap at 72 columns.
>
> Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
> ---
> Makefile | 11 +++++++++++
> package/pkg-generic.mk | 9 +++++++++
> 2 files changed, 20 insertions(+)
>
> diff --git a/Makefile b/Makefile
> index c024c65..1b3d987 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -758,12 +758,22 @@ endif
>
> touch $(TARGET_DIR)/usr
>
> +# Check here if there are packages declaring they harm
> +# the reproducibility of the build
As Thomas said, reproducibility is not the only issue here.
Also, wrap at 80 columns.
But really the comment is not necessary IMO.
> +.PHONY: check-tainted
> +check-tainted:
> +ifneq ($(BR2_TAINTED_BY),)
> + $(error Buildroot is tainted (by: $(BR2_TAINTED_BY)).)
^^^^^^^^^ Your configuration
> +endif
> +
> .PHONY: target-post-image
> target-post-image: $(TARGETS_ROOTFS) target-finalize
> @rm -f $(ROOTFS_COMMON_TAR)
> @$(foreach s, $(call qstrip,$(BR2_ROOTFS_POST_IMAGE_SCRIPT)), \
> $(call MESSAGE,"Executing post-image script $(s)"); \
> $(EXTRA_ENV) $(s) $(BINARIES_DIR) $(call qstrip,$(BR2_ROOTFS_POST_SCRIPT_ARGS))$(sep))
> + @if [ ! -z "$(BR2_TAINTED_BY)" ]; then \
Personally I'd prefer $(if $(BR2_TAINTED_BY), at echo ...) here. But if you keep
the shell condition:
> + echo "WARNING: Buildroot is tainted (by: $(BR2_TAINTED_BY))"; fi
fi should be on a separate line.
>
> .PHONY: source
> source: $(foreach p,$(PACKAGES),$(p)-all-source)
> @@ -1070,6 +1080,7 @@ help:
> @echo ' source - download all sources needed for offline-build'
> @echo ' external-deps - list external packages used'
> @echo ' legal-info - generate info about license compliance'
> + @echo ' check-tainted - check if any selected package harms build reproducibility'
Not just reproducibility. but I don't really have a suggestion to improve that
isn't very long...
> @echo ' printvars - dump all the internal variables'
> @echo
> @echo ' make V=0|1 - 0 => quiet build (default), 1 => verbose build'
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index a303dc2..a71ed6a 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -542,6 +542,10 @@ ifndef $(2)_REDISTRIBUTE
> endif
> endif
>
> +ifdef $(2)_TAINTS
> + BR2_TAINTED_BY+=$$($(2)_RAWNAME)
We normally don't indent inside make conditions.
> +endif
> +
> $(2)_REDISTRIBUTE ?= YES
>
> $(2)_REDIST_SOURCES_DIR = $$(REDIST_SOURCES_DIR_$$(call UPPERCASE,$(4)))/$$($(2)_BASENAME_RAW)
> @@ -900,6 +904,11 @@ else
> $(Q)$$(foreach F,$$($(2)_LICENSE_FILES),$$(call legal-license-file,$$($(2)_RAWNAME),$$($(2)_BASENAME_RAW),$$($(2)_PKGDIR),$$(F),$$($(2)_DIR)/$$(F),$$(call UPPERCASE,$(4)))$$(sep))
> endif # license files
>
> +# Save a legal warning if tainted
Comment is useless IMO, the code speaks for itself.
> +ifeq ($$(call qstrip,$$($(2)_TAINTS)),YES)
> + $(Q)$$(call legal-warning-pkg,$$($(2)_RAWNAME),unknown license for additional modules or dependencies)
Er, this explanation is very specific... I think we could also add taints if
e.g. a git (or github-helper) download doesn't specify a full sha1, because then
we're also not guaranteed to have reproducibility.
So for the legal warning, I'd rather think of something separate.
But actually, that can be changed if/when we actually do add taints for other
situations as well. So this bit is OK as it is for me.
Regards,
Arnout
> +endif
> +
> ifeq ($$($(2)_SITE_METHOD),local)
> # Packages without a tarball: don't save and warn
> @$$(call legal-warning-nosource,$$($(2)_RAWNAME),local)
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules
2018-03-06 8:48 [Buildroot] [PATCH 0/2] Tainting support Angelo Compagnucci
@ 2018-03-06 8:48 ` Angelo Compagnucci
0 siblings, 0 replies; 4+ messages in thread
From: Angelo Compagnucci @ 2018-03-06 8:48 UTC (permalink / raw)
To: buildroot
From: Angelo Compagnucci <angelo.compagnucci@gmail.com>
This patch enables the tainting of the build if when an
external module is added.
Signed-off-by: Angelo Compagnucci <angelo@amarulasolutions.com>
---
package/nodejs/nodejs.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/nodejs/nodejs.mk b/package/nodejs/nodejs.mk
index a72b9a7..9733701 100644
--- a/package/nodejs/nodejs.mk
+++ b/package/nodejs/nodejs.mk
@@ -160,6 +160,7 @@ NPM = $(TARGET_CONFIGURE_OPTS) \
# We can only call NPM if there's something to install.
#
ifneq ($(NODEJS_MODULES_LIST),)
+NODEJS_TAINTS = YES
define NODEJS_INSTALL_MODULES
# If you're having trouble with module installation, adding -d to the
# npm install call below and setting npm_config_rollback=false can both
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-04 19:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-03 21:34 [Buildroot] [PATCH 1/2] Makefile: add tainting support Angelo Compagnucci
2018-05-03 21:34 ` [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules Angelo Compagnucci
2018-05-04 19:14 ` [Buildroot] [PATCH 1/2] Makefile: add tainting support Arnout Vandecappelle
-- strict thread matches above, loose matches on Subject: below --
2018-03-06 8:48 [Buildroot] [PATCH 0/2] Tainting support Angelo Compagnucci
2018-03-06 8:48 ` [Buildroot] [PATCH 2/2] package/nodejs: taint the build on external modules Angelo Compagnucci
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.