[PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[Chris Wilson]

Unsafe module parameters are just that, unsafe. If the user is foolish
enough to try them and the kernel breaks, they get to keep both pieces.
Don't ask them to file a bug report if they broke it themselves.

References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Cc: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
---
 drivers/gpu/drm/i915/i915_drv.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 9b782045ae17..9c449b8d8eab 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/drivers/gpu/drm/i915/i915_drv.c
@@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
 		   __builtin_return_address(0), &vaf);
 
 	if (is_error && !shown_bug_once) {
-		dev_notice(kdev, "%s", FDO_BUG_MSG);
+		/*
+		 * Ask the user to file a bug report for the error, except
+		 * if they may have caused the bug by fiddling with unsafe
+		 * module parameters.
+		 */
+		if (!test_taint(TAINT_USER))
+			dev_notice(kdev, "%s", FDO_BUG_MSG);
 		shown_bug_once = true;
 	}
 
-- 
2.17.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.BAT: success for drm/i915: Don't request a bug report for unsafe module parameters

[Patchwork]

== Series Details ==

Series: drm/i915: Don't request a bug report for unsafe module parameters
URL   : https://patchwork.freedesktop.org/series/42775/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4149 -> Patchwork_8918 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42775/revisions/1/mbox/

== Known issues ==

  Here are the changes found in Patchwork_8918 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_module_reload@basic-reload:
      fi-bsw-n3050:       PASS -> DMESG-FAIL (fdo#106373)

    igt@kms_frontbuffer_tracking@basic:
      fi-hsw-4200u:       PASS -> DMESG-FAIL (fdo#102614)

    
    ==== Possible fixes ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       INCOMPLETE (fdo#103713) -> PASS

    igt@gem_exec_suspend@basic-s4-devices:
      fi-skl-guc:         FAIL (fdo#104699, fdo#105900) -> PASS +1

    igt@kms_flip@basic-flip-vs-wf_vblank:
      fi-cnl-psr:         FAIL (fdo#100368) -> PASS

    igt@kms_frontbuffer_tracking@basic:
      {fi-hsw-peppy}:     DMESG-FAIL (fdo#106103, fdo#102614) -> PASS

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-ivb-3520m:       DMESG-WARN (fdo#106084) -> PASS

    
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
  fdo#102614 https://bugs.freedesktop.org/show_bug.cgi?id=102614
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#104699 https://bugs.freedesktop.org/show_bug.cgi?id=104699
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106084 https://bugs.freedesktop.org/show_bug.cgi?id=106084
  fdo#106103 https://bugs.freedesktop.org/show_bug.cgi?id=106103
  fdo#106373 https://bugs.freedesktop.org/show_bug.cgi?id=106373


== Participating hosts (40 -> 36) ==

  Missing    (4): fi-ctg-p8600 fi-ilk-m540 fi-skl-6700hq fi-pnv-d510 


== Build changes ==

    * Linux: CI_DRM_4149 -> Patchwork_8918

  CI_DRM_4149: 6c2ec0dee7d19b798a1de1101175f5a076549cd9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4461: f772d9a910130b3aec8efa4f09ed723618fae656 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8918: 57072c4242cfc686b0af19d50939988f115681bc @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4461: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit


== Linux commits ==

57072c4242cf drm/i915: Don't request a bug report for unsafe module parameters

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8918/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

✓ Fi.CI.IGT: success for drm/i915: Don't request a bug report for unsafe module parameters

[Patchwork]

== Series Details ==

Series: drm/i915: Don't request a bug report for unsafe module parameters
URL   : https://patchwork.freedesktop.org/series/42775/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4149_full -> Patchwork_8918_full =

== Summary - WARNING ==

  Minor unknown changes coming with Patchwork_8918_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_8918_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/42775/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in Patchwork_8918_full:

  === IGT changes ===

    ==== Warnings ====

    igt@gem_mocs_settings@mocs-rc6-bsd1:
      shard-kbl:          SKIP -> PASS

    igt@gem_mocs_settings@mocs-rc6-vebox:
      shard-kbl:          PASS -> SKIP +1

    
== Known issues ==

  Here are the changes found in Patchwork_8918_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_sysfs_edid_timing:
      shard-apl:          PASS -> WARN (fdo#100047)

    igt@kms_vblank@pipe-c-ts-continuation-suspend:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    
    ==== Possible fixes ====

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#106023, fdo#103665) -> PASS

    igt@kms_flip@absolute-wf_vblank-interruptible:
      shard-glk:          FAIL (fdo#106087) -> PASS

    igt@kms_setmode@basic:
      shard-kbl:          FAIL (fdo#99912) -> PASS

    igt@prime_vgem@basic-fence-flip:
      shard-kbl:          DMESG-WARN (fdo#106247) -> PASS

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106087 https://bugs.freedesktop.org/show_bug.cgi?id=106087
  fdo#106247 https://bugs.freedesktop.org/show_bug.cgi?id=106247
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (6 -> 6) ==

  No changes in participating hosts


== Build changes ==

    * Linux: CI_DRM_4149 -> Patchwork_8918

  CI_DRM_4149: 6c2ec0dee7d19b798a1de1101175f5a076549cd9 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_4461: f772d9a910130b3aec8efa4f09ed723618fae656 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_8918: 57072c4242cfc686b0af19d50939988f115681bc @ git://anongit.freedesktop.org/gfx-ci/linux
  piglit_4461: 55207ea5154dfaa6d2c128124c50e3be4f9b6440 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_8918/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[Jani Nikula]

On Sun, 06 May 2018, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Unsafe module parameters are just that, unsafe. If the user is foolish
> enough to try them and the kernel breaks, they get to keep both pieces.
> Don't ask them to file a bug report if they broke it themselves.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
> Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

Acked-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/i915/i915_drv.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 9b782045ae17..9c449b8d8eab 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  		   __builtin_return_address(0), &vaf);
>  
>  	if (is_error && !shown_bug_once) {
> -		dev_notice(kdev, "%s", FDO_BUG_MSG);
> +		/*
> +		 * Ask the user to file a bug report for the error, except
> +		 * if they may have caused the bug by fiddling with unsafe
> +		 * module parameters.
> +		 */
> +		if (!test_taint(TAINT_USER))
> +			dev_notice(kdev, "%s", FDO_BUG_MSG);
>  		shown_bug_once = true;
>  	}

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[Joonas Lahtinen]

Quoting Chris Wilson (2018-05-06 21:31:47)
> Unsafe module parameters are just that, unsafe. If the user is foolish
> enough to try them and the kernel breaks, they get to keep both pieces.
> Don't ask them to file a bug report if they broke it themselves.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
> Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
>  drivers/gpu/drm/i915/i915_drv.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 9b782045ae17..9c449b8d8eab 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>                    __builtin_return_address(0), &vaf);
>  
>         if (is_error && !shown_bug_once) {
> -               dev_notice(kdev, "%s", FDO_BUG_MSG);
> +               /*
> +                * Ask the user to file a bug report for the error, except
> +                * if they may have caused the bug by fiddling with unsafe
> +                * module parameters.
> +                */
> +               if (!test_taint(TAINT_USER))
> +                       dev_notice(kdev, "%s", FDO_BUG_MSG);

We cold even have FDO_TAINT_MSG.

Reviewed-by: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>

Regards, Joonas

>                 shown_bug_once = true;
>         }
>  
> -- 
> 2.17.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[Rodrigo Vivi]

On Sun, May 06, 2018 at 07:31:47PM +0100, Chris Wilson wrote:
> Unsafe module parameters are just that, unsafe. If the user is foolish
> enough to try them and the kernel breaks, they get to keep both pieces.
> Don't ask them to file a bug report if they broke it themselves.
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
> Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.com>
> Cc: Jani Nikula <jani.nikula@linux.intel.com>
> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>

I believe there are cases where having the reports would be extremely useful,
like on PSR case.
But of course prioritized as "Lowest".

Better than not having anything and suddenly, when we switch
things on, we start having so many reports at once.

So, probably a different message would be worth trying?

> ---
>  drivers/gpu/drm/i915/i915_drv.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
> index 9b782045ae17..9c449b8d8eab 100644
> --- a/drivers/gpu/drm/i915/i915_drv.c
> +++ b/drivers/gpu/drm/i915/i915_drv.c
> @@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>  		   __builtin_return_address(0), &vaf);
>  
>  	if (is_error && !shown_bug_once) {
> -		dev_notice(kdev, "%s", FDO_BUG_MSG);
> +		/*
> +		 * Ask the user to file a bug report for the error, except
> +		 * if they may have caused the bug by fiddling with unsafe
> +		 * module parameters.
> +		 */
> +		if (!test_taint(TAINT_USER))
> +			dev_notice(kdev, "%s", FDO_BUG_MSG);
>  		shown_bug_once = true;
>  	}
>  
> -- 
> 2.17.0
> 
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH] drm/i915: Don't request a bug report for unsafe module parameters

[Jani Nikula]

On Mon, 07 May 2018, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Sun, May 06, 2018 at 07:31:47PM +0100, Chris Wilson wrote:
>> Unsafe module parameters are just that, unsafe. If the user is foolish
>> enough to try them and the kernel breaks, they get to keep both pieces.
>> Don't ask them to file a bug report if they broke it themselves.
>> 
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=106423
>> Fixes: d15d7538c6d2 ("drm/i915: Tune down init error message due to failure injection")
>> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Imre Deak <imre.deak@intel.com>
>> Cc: Jani Nikula <jani.nikula@linux.intel.com>
>> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
>> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> I believe there are cases where having the reports would be extremely useful,
> like on PSR case.
> But of course prioritized as "Lowest".
>
> Better than not having anything and suddenly, when we switch
> things on, we start having so many reports at once.
>
> So, probably a different message would be worth trying?

AFAICT this only gets used via i915_load_error() when driver load fails.

BR,
Jani.


>
>> ---
>>  drivers/gpu/drm/i915/i915_drv.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
>> index 9b782045ae17..9c449b8d8eab 100644
>> --- a/drivers/gpu/drm/i915/i915_drv.c
>> +++ b/drivers/gpu/drm/i915/i915_drv.c
>> @@ -101,7 +101,13 @@ __i915_printk(struct drm_i915_private *dev_priv, const char *level,
>>  		   __builtin_return_address(0), &vaf);
>>  
>>  	if (is_error && !shown_bug_once) {
>> -		dev_notice(kdev, "%s", FDO_BUG_MSG);
>> +		/*
>> +		 * Ask the user to file a bug report for the error, except
>> +		 * if they may have caused the bug by fiddling with unsafe
>> +		 * module parameters.
>> +		 */
>> +		if (!test_taint(TAINT_USER))
>> +			dev_notice(kdev, "%s", FDO_BUG_MSG);
>>  		shown_bug_once = true;
>>  	}
>>  
>> -- 
>> 2.17.0
>> 

-- 
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx