* [PATCH] um: remove unused vdso-syms.lds
@ 2018-05-11 3:47 Masahiro Yamada
2018-05-14 7:37 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Masahiro Yamada @ 2018-05-11 3:47 UTC (permalink / raw)
To: Jeff Dike, Richard Weinberger, user-mode-linux-devel
Cc: Ingo Molnar, Nicholas Piggin, x86, Masahiro Yamada,
H. Peter Anvin, user-mode-linux-user, linux-kernel,
Thomas Gleixner, Philippe Ombredanne, Kate Stewart,
Greg Kroah-Hartman
This file contains symbol values, and was originally linked into
vmlinux, but I have no idea what it was actually used for.
Since commit 827880ec260b ("x86/um: thin archives build fix"), it is
not even linked. Now it is completely orphan, and no problem has
been reported. It is a proof that this file was not needed in the
first place.
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---
arch/x86/um/vdso/.gitignore | 1 -
arch/x86/um/vdso/Makefile | 16 ----------------
2 files changed, 17 deletions(-)
diff --git a/arch/x86/um/vdso/.gitignore b/arch/x86/um/vdso/.gitignore
index 9cac6d0..f8b69d8 100644
--- a/arch/x86/um/vdso/.gitignore
+++ b/arch/x86/um/vdso/.gitignore
@@ -1,2 +1 @@
-vdso-syms.lds
vdso.lds
diff --git a/arch/x86/um/vdso/Makefile b/arch/x86/um/vdso/Makefile
index 1000335..426681e 100644
--- a/arch/x86/um/vdso/Makefile
+++ b/arch/x86/um/vdso/Makefile
@@ -53,22 +53,6 @@ $(vobjs): KBUILD_CFLAGS += $(CFL)
CFLAGS_REMOVE_vdso-note.o = -pg -fprofile-arcs -ftest-coverage
CFLAGS_REMOVE_um_vdso.o = -pg -fprofile-arcs -ftest-coverage
-targets += vdso-syms.lds
-extra-$(VDSO64-y) += vdso-syms.lds
-
-#
-# Match symbols in the DSO that look like VDSO*; produce a file of constants.
-#
-sed-vdsosym := -e 's/^00*/0/' \
- -e 's/^\([0-9a-fA-F]*\) . \(VDSO[a-zA-Z0-9_]*\)$$/\2 = 0x\1;/p'
-quiet_cmd_vdsosym = VDSOSYM $@
-define cmd_vdsosym
- $(NM) $< | LC_ALL=C sed -n $(sed-vdsosym) | LC_ALL=C sort > $@
-endef
-
-$(obj)/%-syms.lds: $(obj)/%.so.dbg FORCE
- $(call if_changed,vdsosym)
-
#
# The DSO images are built using a special linker script.
#
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] um: remove unused vdso-syms.lds
2018-05-11 3:47 [PATCH] um: remove unused vdso-syms.lds Masahiro Yamada
@ 2018-05-14 7:37 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2018-05-14 7:37 UTC (permalink / raw)
To: Masahiro Yamada
Cc: Jeff Dike, Richard Weinberger, user-mode-linux-devel,
Ingo Molnar, Nicholas Piggin, x86, H. Peter Anvin,
user-mode-linux-user, linux-kernel, Thomas Gleixner,
Philippe Ombredanne, Kate Stewart, Greg Kroah-Hartman
* Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
> This file contains symbol values, and was originally linked into
> vmlinux, but I have no idea what it was actually used for.
>
> Since commit 827880ec260b ("x86/um: thin archives build fix"), it is
> not even linked. Now it is completely orphan, and no problem has
> been reported. It is a proof that this file was not needed in the
> first place.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/x86/um/vdso/.gitignore | 1 -
> arch/x86/um/vdso/Makefile | 16 ----------------
> 2 files changed, 17 deletions(-)
Acked-by: Ingo Molnar <mingo@kernel.org>
Thanks,
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-14 7:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 3:47 [PATCH] um: remove unused vdso-syms.lds Masahiro Yamada
2018-05-14 7:37 ` Ingo Molnar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.