* Fix underflow on Hawaii on 18.20 release branch
@ 2018-05-11 14:54 mikita.lipski-5C7GfCeVMHo
[not found] ` <1526050474-21081-1-git-send-email-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: mikita.lipski-5C7GfCeVMHo @ 2018-05-11 14:54 UTC (permalink / raw)
To: rex.zhu-5C7GfCeVMHo, alexander.deucher-5C7GfCeVMHo,
tim.writer-5C7GfCeVMHo, jerry.zhang-5C7GfCeVMHo,
amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW
Thanks
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread[parent not found: <1526050474-21081-1-git-send-email-mikita.lipski-5C7GfCeVMHo@public.gmane.org>]
* [PATCH] drm/amdgpu: Fix display corruption on CI with dpm enabled [not found] ` <1526050474-21081-1-git-send-email-mikita.lipski-5C7GfCeVMHo@public.gmane.org> @ 2018-05-11 14:54 ` mikita.lipski-5C7GfCeVMHo 0 siblings, 0 replies; 4+ messages in thread From: mikita.lipski-5C7GfCeVMHo @ 2018-05-11 14:54 UTC (permalink / raw) To: rex.zhu-5C7GfCeVMHo, alexander.deucher-5C7GfCeVMHo, tim.writer-5C7GfCeVMHo, jerry.zhang-5C7GfCeVMHo, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Rex Zhu From: Rex Zhu <Rex.Zhu@amd.com> with dpm enabled, need to get active crtcs in dc/no-dc mode. caused by 'commit ebb649667a31 ("drm/amdgpu: Set pm_display_cfg in non-dc mode")' Reviewed-by: Huang Rui <ray.huang@amd.com> Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> --- drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c index 2c82126..b455da4 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c @@ -1878,26 +1878,26 @@ void amdgpu_pm_compute_clocks(struct amdgpu_device *adev) amdgpu_fence_wait_empty(ring); } - if (!amdgpu_device_has_dc_support(adev)) { - mutex_lock(&adev->pm.mutex); - amdgpu_dpm_get_active_displays(adev); - adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs; - adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev); - adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev); - /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */ - if (adev->pm.pm_display_cfg.vrefresh > 120) - adev->pm.pm_display_cfg.min_vblank_time = 0; - if (adev->powerplay.pp_funcs->display_configuration_change) - adev->powerplay.pp_funcs->display_configuration_change( - adev->powerplay.pp_handle, - &adev->pm.pm_display_cfg); - mutex_unlock(&adev->pm.mutex); - } - if (adev->powerplay.pp_funcs->dispatch_tasks) { + if (!amdgpu_device_has_dc_support(adev)) { + mutex_lock(&adev->pm.mutex); + amdgpu_dpm_get_active_displays(adev); + adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs; + adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev); + adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev); + /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */ + if (adev->pm.pm_display_cfg.vrefresh > 120) + adev->pm.pm_display_cfg.min_vblank_time = 0; + if (adev->powerplay.pp_funcs->display_configuration_change) + adev->powerplay.pp_funcs->display_configuration_change( + adev->powerplay.pp_handle, + &adev->pm.pm_display_cfg); + mutex_unlock(&adev->pm.mutex); + } amdgpu_dpm_dispatch_task(adev, AMD_PP_TASK_DISPLAY_CONFIG_CHANGE, NULL); } else { mutex_lock(&adev->pm.mutex); + amdgpu_dpm_get_active_displays(adev); /* update battery/ac status */ if (power_supply_is_system_supplied() > 0) adev->pm.dpm.ac_power = true; -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] drm/amdgpu: Fix display corruption on CI with dpm enabled
@ 2018-04-27 6:18 Rex Zhu
[not found] ` <1524809920-5754-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
0 siblings, 1 reply; 4+ messages in thread
From: Rex Zhu @ 2018-04-27 6:18 UTC (permalink / raw)
To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW; +Cc: Rex Zhu
with dpm enabled, need to get active crtcs in dc/no-dc mode.
caused by
'commit ebb649667a31 ("drm/amdgpu: Set pm_display_cfg in non-dc mode")'
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
index 2c82126..b455da4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
@@ -1878,26 +1878,26 @@ void amdgpu_pm_compute_clocks(struct amdgpu_device *adev)
amdgpu_fence_wait_empty(ring);
}
- if (!amdgpu_device_has_dc_support(adev)) {
- mutex_lock(&adev->pm.mutex);
- amdgpu_dpm_get_active_displays(adev);
- adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs;
- adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev);
- adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev);
- /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */
- if (adev->pm.pm_display_cfg.vrefresh > 120)
- adev->pm.pm_display_cfg.min_vblank_time = 0;
- if (adev->powerplay.pp_funcs->display_configuration_change)
- adev->powerplay.pp_funcs->display_configuration_change(
- adev->powerplay.pp_handle,
- &adev->pm.pm_display_cfg);
- mutex_unlock(&adev->pm.mutex);
- }
-
if (adev->powerplay.pp_funcs->dispatch_tasks) {
+ if (!amdgpu_device_has_dc_support(adev)) {
+ mutex_lock(&adev->pm.mutex);
+ amdgpu_dpm_get_active_displays(adev);
+ adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs;
+ adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev);
+ adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev);
+ /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */
+ if (adev->pm.pm_display_cfg.vrefresh > 120)
+ adev->pm.pm_display_cfg.min_vblank_time = 0;
+ if (adev->powerplay.pp_funcs->display_configuration_change)
+ adev->powerplay.pp_funcs->display_configuration_change(
+ adev->powerplay.pp_handle,
+ &adev->pm.pm_display_cfg);
+ mutex_unlock(&adev->pm.mutex);
+ }
amdgpu_dpm_dispatch_task(adev, AMD_PP_TASK_DISPLAY_CONFIG_CHANGE, NULL);
} else {
mutex_lock(&adev->pm.mutex);
+ amdgpu_dpm_get_active_displays(adev);
/* update battery/ac status */
if (power_supply_is_system_supplied() > 0)
adev->pm.dpm.ac_power = true;
--
1.9.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1524809920-5754-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amdgpu: Fix display corruption on CI with dpm enabled [not found] ` <1524809920-5754-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org> @ 2018-04-27 10:09 ` Huang Rui 0 siblings, 0 replies; 4+ messages in thread From: Huang Rui @ 2018-04-27 10:09 UTC (permalink / raw) To: Rex Zhu; +Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW On Fri, Apr 27, 2018 at 02:18:40PM +0800, Rex Zhu wrote: > with dpm enabled, need to get active crtcs in dc/no-dc mode. > > caused by > 'commit ebb649667a31 ("drm/amdgpu: Set pm_display_cfg in non-dc mode")' > > Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> Reviewed-by: Huang Rui <ray.huang@amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > index 2c82126..b455da4 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c > @@ -1878,26 +1878,26 @@ void amdgpu_pm_compute_clocks(struct amdgpu_device *adev) > amdgpu_fence_wait_empty(ring); > } > > - if (!amdgpu_device_has_dc_support(adev)) { > - mutex_lock(&adev->pm.mutex); > - amdgpu_dpm_get_active_displays(adev); > - adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs; > - adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev); > - adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev); > - /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */ > - if (adev->pm.pm_display_cfg.vrefresh > 120) > - adev->pm.pm_display_cfg.min_vblank_time = 0; > - if (adev->powerplay.pp_funcs->display_configuration_change) > - adev->powerplay.pp_funcs->display_configuration_change( > - adev->powerplay.pp_handle, > - &adev->pm.pm_display_cfg); > - mutex_unlock(&adev->pm.mutex); > - } > - > if (adev->powerplay.pp_funcs->dispatch_tasks) { > + if (!amdgpu_device_has_dc_support(adev)) { > + mutex_lock(&adev->pm.mutex); > + amdgpu_dpm_get_active_displays(adev); > + adev->pm.pm_display_cfg.num_display = adev->pm.dpm.new_active_crtcs; > + adev->pm.pm_display_cfg.vrefresh = amdgpu_dpm_get_vrefresh(adev); > + adev->pm.pm_display_cfg.min_vblank_time = amdgpu_dpm_get_vblank_time(adev); > + /* we have issues with mclk switching with refresh rates over 120 hz on the non-DC code. */ > + if (adev->pm.pm_display_cfg.vrefresh > 120) > + adev->pm.pm_display_cfg.min_vblank_time = 0; > + if (adev->powerplay.pp_funcs->display_configuration_change) > + adev->powerplay.pp_funcs->display_configuration_change( > + adev->powerplay.pp_handle, > + &adev->pm.pm_display_cfg); > + mutex_unlock(&adev->pm.mutex); > + } > amdgpu_dpm_dispatch_task(adev, AMD_PP_TASK_DISPLAY_CONFIG_CHANGE, NULL); > } else { > mutex_lock(&adev->pm.mutex); > + amdgpu_dpm_get_active_displays(adev); > /* update battery/ac status */ > if (power_supply_is_system_supplied() > 0) > adev->pm.dpm.ac_power = true; > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-11 14:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-11 14:54 Fix underflow on Hawaii on 18.20 release branch mikita.lipski-5C7GfCeVMHo
[not found] ` <1526050474-21081-1-git-send-email-mikita.lipski-5C7GfCeVMHo@public.gmane.org>
2018-05-11 14:54 ` [PATCH] drm/amdgpu: Fix display corruption on CI with dpm enabled mikita.lipski-5C7GfCeVMHo
-- strict thread matches above, loose matches on Subject: below --
2018-04-27 6:18 Rex Zhu
[not found] ` <1524809920-5754-1-git-send-email-Rex.Zhu-5C7GfCeVMHo@public.gmane.org>
2018-04-27 10:09 ` Huang Rui
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.