* [PATCH] ARM: dts: at91-sama5d2_xplained: Use IRQ_TYPE specifier
@ 2018-05-13 23:22 ` Hernán Gonzalez
0 siblings, 0 replies; 4+ messages in thread
From: Hernán Gonzalez @ 2018-05-13 23:22 UTC (permalink / raw)
To: nicolas.ferre
Cc: alexandre.belloni, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel, Hernán Gonzalez
GPIO_ACTIVE_LOW was being used to specify an interrupt, use
IRQ_TYPE_EDGE_RISING instead. This improves DT readability.
Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index e4bbb7e..fcc85d7 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -232,7 +232,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
interrupt-parent = <&pioA>;
- interrupts = <PIN_PB13 GPIO_ACTIVE_LOW>;
+ interrupts = <PIN_PB13 IRQ_TYPE_EDGE_RISING>;
active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: at91-sama5d2_xplained: Use IRQ_TYPE specifier
@ 2018-05-13 23:22 ` Hernán Gonzalez
0 siblings, 0 replies; 4+ messages in thread
From: Hernán Gonzalez @ 2018-05-13 23:22 UTC (permalink / raw)
To: linux-arm-kernel
GPIO_ACTIVE_LOW was being used to specify an interrupt, use
IRQ_TYPE_EDGE_RISING instead. This improves DT readability.
Signed-off-by: Hern?n Gonzalez <hernan@vanguardiasur.com.ar>
---
arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
index e4bbb7e..fcc85d7 100644
--- a/arch/arm/boot/dts/at91-sama5d2_xplained.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_xplained.dts
@@ -232,7 +232,7 @@
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
interrupt-parent = <&pioA>;
- interrupts = <PIN_PB13 GPIO_ACTIVE_LOW>;
+ interrupts = <PIN_PB13 IRQ_TYPE_EDGE_RISING>;
active-semi,chglev-gpios = <&pioA PIN_PA12 GPIO_ACTIVE_HIGH>;
active-semi,lbo-gpios = <&pioA PIN_PC8 GPIO_ACTIVE_LOW>;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: at91-sama5d2_xplained: Use IRQ_TYPE specifier
2018-05-13 23:22 ` Hernán Gonzalez
@ 2018-05-14 13:30 ` Alexandre Belloni
-1 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2018-05-14 13:30 UTC (permalink / raw)
To: Hernán Gonzalez
Cc: nicolas.ferre, robh+dt, mark.rutland, linux-arm-kernel,
devicetree, linux-kernel
On 13/05/2018 20:22:04-0300, Hernán Gonzalez wrote:
> GPIO_ACTIVE_LOW was being used to specify an interrupt, use
> IRQ_TYPE_EDGE_RISING instead. This improves DT readability.
>
> Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] ARM: dts: at91-sama5d2_xplained: Use IRQ_TYPE specifier
@ 2018-05-14 13:30 ` Alexandre Belloni
0 siblings, 0 replies; 4+ messages in thread
From: Alexandre Belloni @ 2018-05-14 13:30 UTC (permalink / raw)
To: linux-arm-kernel
On 13/05/2018 20:22:04-0300, Hern?n Gonzalez wrote:
> GPIO_ACTIVE_LOW was being used to specify an interrupt, use
> IRQ_TYPE_EDGE_RISING instead. This improves DT readability.
>
> Signed-off-by: Hern?n Gonzalez <hernan@vanguardiasur.com.ar>
> ---
> arch/arm/boot/dts/at91-sama5d2_xplained.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks.
--
Alexandre Belloni, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-05-14 13:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-13 23:22 [PATCH] ARM: dts: at91-sama5d2_xplained: Use IRQ_TYPE specifier Hernán Gonzalez
2018-05-13 23:22 ` Hernán Gonzalez
2018-05-14 13:30 ` Alexandre Belloni
2018-05-14 13:30 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.