All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride
@ 2018-05-14 21:09 Andre McCurdy
  2018-05-14 22:23 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Andre McCurdy @ 2018-05-14 21:09 UTC (permalink / raw)
  To: openembedded-core

The comment appears to have been accidentally left behind when the
fail-fast over-ride was removed by:

  http://git.openembedded.org/openembedded-core/commit/?id=83ce96f44516c8a4a44c8c0140949256f8422014

Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
---
 meta/conf/bitbake.conf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index a21b728..a74d8cf 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -733,8 +733,8 @@ DISTRO_NAME ??= "OpenEmbedded"
 # '<foo>_qemuarm' and then '<foo>' will be overriden with that value from '<foo>_qemuarm'.
 # And finally '<foo>_forcevariable' overrides any standard variable, with the highest priority.
 #
-# This works for  functions as well, they are really just environment variables.
-# Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
+# This works for functions as well, they are really just environment variables.
+#
 OVERRIDES = "${TARGET_OS}:${TRANSLATED_TARGET_ARCH}:build-${BUILD_OS}:pn-${PN}:${MACHINEOVERRIDES}:${DISTROOVERRIDES}:${CLASSOVERRIDE}:forcevariable"
 CLASSOVERRIDE ?= "class-target"
 DISTROOVERRIDES ?= "${@d.getVar('DISTRO') or ''}"
-- 
1.9.1



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride
  2018-05-14 21:09 [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride Andre McCurdy
@ 2018-05-14 22:23 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2018-05-14 22:23 UTC (permalink / raw)
  To: Andre McCurdy, openembedded-core

On Mon, 2018-05-14 at 14:09 -0700, Andre McCurdy wrote:
> The comment appears to have been accidentally left behind when the
> fail-fast over-ride was removed by:
> 
>   http://git.openembedded.org/openembedded-core/commit/?id=83ce96f445
> 16c8a4a44c8c0140949256f8422014
> 
> Signed-off-by: Andre McCurdy <armccurdy@gmail.com>
> ---
>  meta/conf/bitbake.conf | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a21b728..a74d8cf 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -733,8 +733,8 @@ DISTRO_NAME ??= "OpenEmbedded"
>  # '_qemuarm' and then '' will be overriden with that value from '_qemuarm'.
>  # And finally '_forcevariable' overrides any standard variable, with the highest priority.
>  #
> -# This works for  functions as well, they are really just environment variables.
> -# Default OVERRIDES to make compilation fail fast in case of build system misconfiguration.
> +# This works for functions as well, they are really just environment variables.

If we're going to fix the comment, could you remove the word
"environment" from there too please? :)

Cheers,

Richard


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-14 22:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-14 21:09 [PATCH] bitbake.conf: drop obsolete comment referring to the fail-fast over-ride Andre McCurdy
2018-05-14 22:23 ` Richard Purdie

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.